From ec7efac4a967c650ae1cd8cebe28e7c69cbe3864 Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Mon, 7 Dec 2009 20:51:49 +0000 Subject: [PATCH] Fix backcompat for hotplug of SCSI controllers SCSI controllers have no trouble existing without any attached disks. This could be achieved with the (legacy) monitor syntax pci_add pci_addr=auto storage if=scsi This is now denied with scsi requires a backing file/device. failed to add if=scsi There is no need for this denial and it breaks compatability with existing QEMU usage, so remove the check for presence of a drive. Signed-off-by: Daniel P. Berrange Signed-off-by: Anthony Liguori --- hw/pci-hotplug.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/pci-hotplug.c b/hw/pci-hotplug.c index f10c868eee..ba13d2bce0 100644 --- a/hw/pci-hotplug.c +++ b/hw/pci-hotplug.c @@ -199,14 +199,10 @@ static PCIDevice *qemu_pci_hot_add_storage(Monitor *mon, switch (type) { case IF_SCSI: - if (!dinfo) { - monitor_printf(mon, "scsi requires a backing file/device.\n"); - return NULL; - } dev = pci_create(bus, devfn, "lsi53c895a"); if (qdev_init(&dev->qdev) < 0) dev = NULL; - if (dev) { + if (dev && dinfo) { if (scsi_hot_add(&dev->qdev, dinfo, 0) != 0) { qdev_unplug(&dev->qdev); dev = NULL; -- 2.11.0