From ed3d4a8075ac6f2437e100bc063bad82ff3a8671 Mon Sep 17 00:00:00 2001 From: Jes Sorensen Date: Thu, 21 Oct 2010 17:15:48 +0200 Subject: [PATCH] Switch migrate_set_speed() to take an 'o' argument rather than a float. Clarify default value of MB in migration speed argument in monitor, if no suffix is specified. This differ from previous default of bytes, but is consistent with the rest of the places where we accept a size argument. Signed-off-by: Jes Sorensen Signed-off-by: Anthony Liguori --- hmp-commands.hx | 5 +++-- migration.c | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 81999aa1a9..e5585ba0e9 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -754,9 +754,10 @@ ETEXI { .name = "migrate_set_speed", - .args_type = "value:f", + .args_type = "value:o", .params = "value", - .help = "set maximum speed (in bytes) for migrations", + .help = "set maximum speed (in bytes) for migrations. " + "Defaults to MB if no size suffix is specified, ie. B/K/M/G/T", .user_print = monitor_user_noop, .mhandler.cmd_new = do_migrate_set_speed, }, diff --git a/migration.c b/migration.c index 468d51749f..9ee8b179c0 100644 --- a/migration.c +++ b/migration.c @@ -132,10 +132,10 @@ int do_migrate_cancel(Monitor *mon, const QDict *qdict, QObject **ret_data) int do_migrate_set_speed(Monitor *mon, const QDict *qdict, QObject **ret_data) { - double d; + int64_t d; FdMigrationState *s; - d = qdict_get_double(qdict, "value"); + d = qdict_get_int(qdict, "value"); d = MAX(0, MIN(UINT32_MAX, d)); max_throttle = d; -- 2.11.0