From ef30c5eeaf72fb5237aac223434296c6a164e1d2 Mon Sep 17 00:00:00 2001 From: obrien Date: Tue, 19 Mar 2002 21:03:40 +0000 Subject: [PATCH] 2002-03-18 David O'Brien * emultempl/elf32.em: Use lbasename vs. basename to fix problem where the contents of the buffer returned from basename function will are getting overwritten while still being used. Approved by: Alan Modra Message-ID: <20020318032031.GD1089@bubble.sa.bigpond.net.au> --- ld/ChangeLog | 6 ++++++ ld/emultempl/elf32.em | 11 ++++------- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/ld/ChangeLog b/ld/ChangeLog index 378c00db55..3b5588430f 100644 --- a/ld/ChangeLog +++ b/ld/ChangeLog @@ -1,3 +1,9 @@ +2002-03-18 David O'Brien + + * emultempl/elf32.em: Use lbasename vs. basename to fix problem where + the contents of the buffer returned from basename function will are + getting overwritten while still being used. + Mon Mar 18 17:38:39 CET 2002 Jan Hubicka Andreas Jaeger Andreas Schwab diff --git a/ld/emultempl/elf32.em b/ld/emultempl/elf32.em index 675a32811d..077a8fc0f3 100644 --- a/ld/emultempl/elf32.em +++ b/ld/emultempl/elf32.em @@ -165,7 +165,7 @@ gld${EMULATION_NAME}_vercheck (s) soname = bfd_elf_get_dt_soname (s->the_bfd); if (soname == NULL) - soname = basename (bfd_get_filename (s->the_bfd)); + soname = lbasename (bfd_get_filename (s->the_bfd)); for (l = global_vercheck_needed; l != NULL; l = l->next) { @@ -247,7 +247,7 @@ gld${EMULATION_NAME}_stat_needed (s) soname = bfd_elf_get_dt_soname (s->the_bfd); if (soname == NULL) - soname = basename (s->filename); + soname = lbasename (s->filename); if (strncmp (soname, global_needed->name, suffix - global_needed->name) == 0) einfo ("%P: warning: %s, needed by %B, may conflict with %s\n", @@ -351,7 +351,7 @@ cat >>e${EMULATION_NAME}.c <filename); + soname = lbasename (abfd->filename); if (trace_file_tries) info_msg (_("found %s at %s\n"), soname, name); @@ -369,9 +369,6 @@ cat >>e${EMULATION_NAME}.c <filename); - /* Tell the ELF backend that the output file needs a DT_NEEDED entry for this file if it is used to resolve the reference in a regular object. */ @@ -976,7 +973,7 @@ gld${EMULATION_NAME}_open_dynamic_archive (arch, search, entry) /* Rather than duplicating the logic above. Just use the filename we recorded earlier. */ - filename = xstrdup (basename (entry->filename)); + filename = lbasename (entry->filename); bfd_elf_set_dt_needed_name (entry->the_bfd, filename); } -- 2.11.0