From efb73a96b559f88a168b1cfbd5a3ad865ab8f937 Mon Sep 17 00:00:00 2001 From: Joel Fernandes Date: Fri, 2 Jun 2017 10:19:28 -0700 Subject: [PATCH] atrace: Set saved_cmdline_size to 8192 This increases the size of the table tracking comms and pids and prevents overwriting them easily. Bug: 38167231 Change-Id: I69b9000e4f9d0c2c7969efd38e02d8c1bffdad5c Signed-off-by: Joel Fernandes (cherry picked from commit ed80bd04cc3bf80082b1d733ef06d90a29c6270a) --- cmds/atrace/atrace.cpp | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/cmds/atrace/atrace.cpp b/cmds/atrace/atrace.cpp index d3e0cd480d..1a803f39bc 100644 --- a/cmds/atrace/atrace.cpp +++ b/cmds/atrace/atrace.cpp @@ -215,6 +215,9 @@ static const char* k_traceClockPath = static const char* k_traceBufferSizePath = "buffer_size_kb"; +static const char* k_traceCmdlineSizePath = + "saved_cmdlines_size"; + static const char* k_tracingOverwriteEnablePath = "options/overwrite"; @@ -437,6 +440,12 @@ static bool setTraceBufferSizeKB(int size) return writeStr(k_traceBufferSizePath, str); } +// Set the default size of cmdline hashtable +static bool setCmdlineSize() +{ + return writeStr(k_traceCmdlineSizePath, "8192"); +} + // Set the clock to the best available option while tracing. Use 'boot' if it's // available; otherwise, use 'mono'. If neither are available use 'global'. // Any write to the trace_clock sysfs file will reset the buffer, so only @@ -757,6 +766,7 @@ static bool setUpTrace() ok &= setCategoriesEnableFromFile(g_categoriesFile); ok &= setTraceOverwriteEnable(g_traceOverwrite); ok &= setTraceBufferSizeKB(g_traceBufferSizeKB); + ok &= setCmdlineSize(); ok &= setClock(); ok &= setPrintTgidEnableIfPresent(true); ok &= setKernelTraceFuncs(g_kernelTraceFuncs); -- 2.11.0