From f265dbc44768b10e7fa45a104801e9222ae8c089 Mon Sep 17 00:00:00 2001 From: Matthew Fritze Date: Tue, 4 Oct 2016 13:39:27 -0700 Subject: [PATCH] Fix bug preventing users from clicking settings suggestions twice In an attempt to fix a monkey test crash which would open a suggestion, click back and tap the same one again. The change unfortunately prevented this for all users, but was not caught because of a debug flag set on my device. A unit test will be added to master to catch such cases, as tracked by this bug: b/31937112 Change-Id: Ib1cff07e54903df687454bdbf2ed1416485ab34f Fixes: 31926102 Test: Manual --- src/com/android/settings/SettingsActivity.java | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/com/android/settings/SettingsActivity.java b/src/com/android/settings/SettingsActivity.java index 9ccdb1db31..9245003de7 100644 --- a/src/com/android/settings/SettingsActivity.java +++ b/src/com/android/settings/SettingsActivity.java @@ -1273,11 +1273,7 @@ public class SettingsActivity extends SettingsDrawerActivity if (intent == null || ActivityManager.isUserAMonkey()) { return; } - final ComponentName componentName = intent.getComponent(); - if (componentName.equals(mCurrentSuggestion)) { - return; - } - mCurrentSuggestion = componentName; + mCurrentSuggestion = intent.getComponent(); startActivityForResult(intent, REQUEST_SUGGESTION); } -- 2.11.0