From f329e08a3e890167dbeb33a4f7ed60054071e843 Mon Sep 17 00:00:00 2001 From: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com> Date: Thu, 30 Aug 2018 11:13:34 +0800 Subject: [PATCH] Fix version test (#1301) * :white_check_mark: Add version comparison test * :art: Macros revision len * :white_check_mark: Add version flag test * Update comments * Update comments * Fix typo * Fix test --- version/version_test.go | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/version/version_test.go b/version/version_test.go index 195dbfe0..d05f0116 100644 --- a/version/version_test.go +++ b/version/version_test.go @@ -1,10 +1,7 @@ package version import ( - "fmt" - "math/rand" "testing" - "time" gover "github.com/hashicorp/go-version" ) @@ -16,17 +13,13 @@ func TestRevisionLen(t *testing.T) { } func TestCompare(t *testing.T) { - rand.Seed(time.Now().UnixNano()) - i := rand.Uint64() - rev := fmt.Sprintf("%16x", i)[:revisionLen] - v1, err := gover.NewVersion(Version) if err != nil { - t.Error("Version 1 format error.") + t.Fatal("Version 1 format error.") } - v2, err := gover.NewVersion(Version + "+" + rev) + v2, err := gover.NewVersion(Version + "+f873dfca") if err != nil { - t.Error("Version 2 format error.") + t.Fatal("Version 2 format error.") } if v1.GreaterThan(v2) || v1.GreaterThan(v2) { t.Error("Version comparison error.") -- 2.11.0