From f36d22b0035b98c163f987a05cfeb577e186ed3b Mon Sep 17 00:00:00 2001 From: Paul Semel Date: Thu, 7 Jun 2018 10:05:25 +0000 Subject: [PATCH] [llvm-strip] Expose --strip-unneeded option Differential Revision: https://reviews.llvm.org/D47818 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@334182 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/tools/llvm-objcopy/strip-unneeded.test | 7 +++++++ tools/llvm-objcopy/StripOpts.td | 3 +++ tools/llvm-objcopy/llvm-objcopy.cpp | 6 +++--- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/test/tools/llvm-objcopy/strip-unneeded.test b/test/tools/llvm-objcopy/strip-unneeded.test index 448bc533038..8f96035e095 100644 --- a/test/tools/llvm-objcopy/strip-unneeded.test +++ b/test/tools/llvm-objcopy/strip-unneeded.test @@ -1,7 +1,14 @@ # RUN: yaml2obj %s > %t +# RUN: cp %t %t1 # RUN: llvm-objcopy --strip-unneeded %t %t2 +# Verify that llvm-objcopy has not modified the input. +# RUN: cmp %t %t1 # RUN: llvm-readobj -symbols %t2 | FileCheck %s +# Verify that llvm-strip modifies the symbol table the same way. +# RUN: llvm-strip --strip-unneeded %t +# RUN: cmp %t %t2 + !ELF FileHeader: Class: ELFCLASS64 diff --git a/tools/llvm-objcopy/StripOpts.td b/tools/llvm-objcopy/StripOpts.td index 27fdfee8f5b..5825f23297c 100644 --- a/tools/llvm-objcopy/StripOpts.td +++ b/tools/llvm-objcopy/StripOpts.td @@ -41,3 +41,6 @@ def discard_all : Flag<["-", "--"], "discard-all">, HelpText<"Remove all local symbols except file and section symbols">; def x : Flag<["-"], "x">, Alias; + +def strip_unneeded : Flag<["-", "--"], "strip-unneeded">, + HelpText<"Remove all symbols not needed by relocations">; diff --git a/tools/llvm-objcopy/llvm-objcopy.cpp b/tools/llvm-objcopy/llvm-objcopy.cpp index 46769838aba..bf58f342ee4 100644 --- a/tools/llvm-objcopy/llvm-objcopy.cpp +++ b/tools/llvm-objcopy/llvm-objcopy.cpp @@ -583,12 +583,12 @@ CopyConfig ParseStripOptions(ArrayRef ArgsArr) { Config.OutputFilename = InputArgs.getLastArgValue(STRIP_output, Positional[0]); - // Strip debug info only. Config.StripDebug = InputArgs.hasArg(STRIP_strip_debug); Config.DiscardAll = InputArgs.hasArg(STRIP_discard_all); - - if (!Config.StripDebug && !Config.DiscardAll) + Config.StripUnneeded = InputArgs.hasArg(STRIP_strip_unneeded); + + if (!Config.StripDebug && !Config.StripUnneeded && !Config.DiscardAll) Config.StripAll = true; for (auto Arg : InputArgs.filtered(STRIP_remove_section)) -- 2.11.0