From f4d803d4637fabc82fbb3a18b563d50c0826b1f3 Mon Sep 17 00:00:00 2001 From: Julia Reynolds Date: Thu, 2 Jun 2016 10:57:02 -0400 Subject: [PATCH] Fix leak on density change. Bug: 29064258 Change-Id: I9d579cc17fe4554a6a4aa57c409cef72bdee74bd --- .../SystemUI/src/com/android/systemui/volume/VolumeDialog.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/volume/VolumeDialog.java b/packages/SystemUI/src/com/android/systemui/volume/VolumeDialog.java index f2cd885d68ce..c6992aad068e 100644 --- a/packages/SystemUI/src/com/android/systemui/volume/VolumeDialog.java +++ b/packages/SystemUI/src/com/android/systemui/volume/VolumeDialog.java @@ -106,14 +106,14 @@ public class VolumeDialog implements TunerService.Tunable { private ViewGroup mDialogContentView; private ImageButton mExpandButton; private final List mRows = new ArrayList<>(); - private final SpTexts mSpTexts; + private SpTexts mSpTexts; private final SparseBooleanArray mDynamic = new SparseBooleanArray(); private final KeyguardManager mKeyguard; private final AudioManager mAudioManager; private final AccessibilityManager mAccessibilityMgr; private int mExpandButtonAnimationDuration; private ZenFooter mZenFooter; - private final LayoutTransition mLayoutTransition; + private LayoutTransition mLayoutTransition; private final Object mSafetyWarningLock = new Object(); private final Accessibility mAccessibility = new Accessibility(); private final ColorStateList mActiveSliderTint; @@ -149,14 +149,11 @@ public class VolumeDialog implements TunerService.Tunable { mCallback = callback; mWindowType = windowType; mZenModeController = zenModeController; - mSpTexts = new SpTexts(mContext); mKeyguard = (KeyguardManager) context.getSystemService(Context.KEYGUARD_SERVICE); mAudioManager = (AudioManager) context.getSystemService(Context.AUDIO_SERVICE); mAccessibilityMgr = (AccessibilityManager) mContext.getSystemService(Context.ACCESSIBILITY_SERVICE); mActiveSliderTint = loadColorStateList(R.color.system_accent_color); mInactiveSliderTint = loadColorStateList(R.color.volume_slider_inactive); - mLayoutTransition = new LayoutTransition(); - mLayoutTransition.setDuration(new ValueAnimator().getDuration() / 2); initDialog(); @@ -173,6 +170,9 @@ public class VolumeDialog implements TunerService.Tunable { private void initDialog() { mDialog = new CustomDialog(mContext); + mSpTexts = new SpTexts(mContext); + mLayoutTransition = new LayoutTransition(); + mLayoutTransition.setDuration(new ValueAnimator().getDuration() / 2); mHovering = false; mShowing = false; final Window window = mDialog.getWindow(); -- 2.11.0