From f51a08da6d1d591c021c1aa0ee6dd23f7caf3639 Mon Sep 17 00:00:00 2001 From: Valentin Ilie Date: Sat, 21 Sep 2013 12:30:15 +0300 Subject: [PATCH] usb: gadget: mv_u3d_core: fix memory leaks When trb_hw is NULL, trb should be free'd before return. Signed-off-by: Valentin Ilie Signed-off-by: Felipe Balbi --- drivers/usb/gadget/mv_u3d_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/gadget/mv_u3d_core.c b/drivers/usb/gadget/mv_u3d_core.c index 561b30efb8ee..4d31177d5d99 100644 --- a/drivers/usb/gadget/mv_u3d_core.c +++ b/drivers/usb/gadget/mv_u3d_core.c @@ -310,6 +310,7 @@ static struct mv_u3d_trb *mv_u3d_build_trb_one(struct mv_u3d_req *req, */ trb_hw = dma_pool_alloc(u3d->trb_pool, GFP_ATOMIC, dma); if (!trb_hw) { + kfree(trb); dev_err(u3d->dev, "%s, dma_pool_alloc fail\n", __func__); return NULL; @@ -454,6 +455,7 @@ static int mv_u3d_req_to_trb(struct mv_u3d_req *req) trb_hw = kcalloc(trb_num, sizeof(*trb_hw), GFP_ATOMIC); if (!trb_hw) { + kfree(trb); dev_err(u3d->dev, "%s, trb_hw alloc fail\n", __func__); return -ENOMEM; -- 2.11.0