From f51e5a202e3cd6656f91fd61fda0bf206aa895e3 Mon Sep 17 00:00:00 2001 From: Amitoj Kaur Chawla Date: Tue, 16 Feb 2016 19:14:12 +0530 Subject: [PATCH] staging: lustre: osc: osc_request: Declare local function and structure as static Declare osc_cleanup() function and osc_obd_ops structure as static since they are defined and called only in this file. Removed osc_cleanup() function prototype since it wasn't required. This fixes the following sparse warnings: drivers/staging/lustre/lustre/osc/osc_request.c:3210:5: warning: symbol 'osc_cleanup' was not declared. Should it be static? drivers/staging/lustre/lustre/osc/osc_request.c:3259:16: warning: symbol 'osc_obd_ops' was not declared. Should it be static? Signed-off-by: Amitoj Kaur Chawla Reviewed-by: Arnd Bergmann Signed-off-by: Greg Kroah-Hartman --- drivers/staging/lustre/lustre/osc/osc_request.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/osc/osc_request.c b/drivers/staging/lustre/lustre/osc/osc_request.c index 23a11c49d945..43b11c61c2f0 100644 --- a/drivers/staging/lustre/lustre/osc/osc_request.c +++ b/drivers/staging/lustre/lustre/osc/osc_request.c @@ -104,7 +104,6 @@ struct osc_enqueue_args { static void osc_release_ppga(struct brw_page **ppga, u32 count); static int brw_interpret(const struct lu_env *env, struct ptlrpc_request *req, void *data, int rc); -static int osc_cleanup(struct obd_device *obd); /* Pack OSC object metadata for disk storage (LE byte order). */ static int osc_packmd(struct obd_export *exp, struct lov_mds_md **lmmp, @@ -3205,7 +3204,7 @@ static int osc_precleanup(struct obd_device *obd, enum obd_cleanup_stage stage) return 0; } -int osc_cleanup(struct obd_device *obd) +static int osc_cleanup(struct obd_device *obd) { struct client_obd *cli = &obd->u.cli; int rc; @@ -3254,7 +3253,7 @@ static int osc_process_config(struct obd_device *obd, u32 len, void *buf) return osc_process_config_base(obd, buf); } -struct obd_ops osc_obd_ops = { +static struct obd_ops osc_obd_ops = { .owner = THIS_MODULE, .setup = osc_setup, .precleanup = osc_precleanup, -- 2.11.0