From f77786ef310c064636790d72f404b54888648a19 Mon Sep 17 00:00:00 2001
From: Nicolas Capens <capn@google.com>
Date: Tue, 25 Aug 2015 15:14:36 -0400
Subject: [PATCH] Log parameters of invalid surface creation.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Change-Id: I8be27042263ae80da3e01dce6c84dcf43645a232
Reviewed-on: https://swiftshader-review.googlesource.com/3911
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <capn@google.com>
Tested-by: Nicolas Capens <capn@google.com>
---
 src/OpenGL/libGL/Device.cpp       | 4 ++--
 src/OpenGL/libGLES_CM/Device.cpp  | 4 ++--
 src/OpenGL/libGLES_CM/Texture.cpp | 2 +-
 src/OpenGL/libGLESv2/Device.cpp   | 4 ++--
 src/OpenGL/libGLESv2/Texture.cpp  | 2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/OpenGL/libGL/Device.cpp b/src/OpenGL/libGL/Device.cpp
index 9f2d23181..4d05d315f 100644
--- a/src/OpenGL/libGL/Device.cpp
+++ b/src/OpenGL/libGL/Device.cpp
@@ -254,7 +254,7 @@ namespace gl
 	{
 		if(width == 0 || height == 0 || height > OUTLINE_RESOLUTION)
 		{
-			ERR("Invalid parameters");
+			ERR("Invalid parameters: %dx%d", width, height);
 			return 0;
 		}
 		
@@ -298,7 +298,7 @@ namespace gl
 	{
 		if(height > OUTLINE_RESOLUTION)
 		{
-			ERR("Invalid parameters");
+			ERR("Invalid parameters: %dx%d", width, height);
 			return 0;
 		}
 
diff --git a/src/OpenGL/libGLES_CM/Device.cpp b/src/OpenGL/libGLES_CM/Device.cpp
index ebe6cc68b..5066de36d 100644
--- a/src/OpenGL/libGLES_CM/Device.cpp
+++ b/src/OpenGL/libGLES_CM/Device.cpp
@@ -212,7 +212,7 @@ namespace es1
 	{
 		if(width == 0 || height == 0 || height > OUTLINE_RESOLUTION)
 		{
-			ERR("Invalid parameters");
+			ERR("Invalid parameters: %dx%d", width, height);
 			return 0;
 		}
 		
@@ -256,7 +256,7 @@ namespace es1
 	{
 		if(height > OUTLINE_RESOLUTION)
 		{
-			ERR("Invalid parameters");
+			ERR("Invalid parameters: %dx%d", width, height);
 			return 0;
 		}
 
diff --git a/src/OpenGL/libGLES_CM/Texture.cpp b/src/OpenGL/libGLES_CM/Texture.cpp
index 818c1b8ea..4e97a29d2 100644
--- a/src/OpenGL/libGLES_CM/Texture.cpp
+++ b/src/OpenGL/libGLES_CM/Texture.cpp
@@ -796,7 +796,7 @@ egl::Image *createDepthStencil(unsigned int width, unsigned int height, sw::Form
 {
 	if(width == 0 || height == 0 || height > OUTLINE_RESOLUTION)
 	{
-		ERR("Invalid parameters");
+		ERR("Invalid parameters: %dx%d", width, height);
 		return 0;
 	}
 
diff --git a/src/OpenGL/libGLESv2/Device.cpp b/src/OpenGL/libGLESv2/Device.cpp
index e89be78d5..119072201 100644
--- a/src/OpenGL/libGLESv2/Device.cpp
+++ b/src/OpenGL/libGLESv2/Device.cpp
@@ -221,7 +221,7 @@ namespace es2
 	{
 		if(width == 0 || height == 0 || height > OUTLINE_RESOLUTION)
 		{
-			ERR("Invalid parameters");
+			ERR("Invalid parameters: %dx%d", width, height);
 			return 0;
 		}
 		
@@ -265,7 +265,7 @@ namespace es2
 	{
 		if(height > OUTLINE_RESOLUTION)
 		{
-			ERR("Invalid parameters");
+			ERR("Invalid parameters: %dx%d", width, height);
 			return 0;
 		}
 
diff --git a/src/OpenGL/libGLESv2/Texture.cpp b/src/OpenGL/libGLESv2/Texture.cpp
index 955150399..b0e85534c 100644
--- a/src/OpenGL/libGLESv2/Texture.cpp
+++ b/src/OpenGL/libGLESv2/Texture.cpp
@@ -1904,7 +1904,7 @@ egl::Image *createDepthStencil(unsigned int width, unsigned int height, sw::Form
 {
 	if(width == 0 || height == 0 || height > OUTLINE_RESOLUTION)
 	{
-		ERR("Invalid parameters");
+		ERR("Invalid parameters: %dx%d", width, height);
 		return 0;
 	}
 		
-- 
2.11.0