From f8765177034a521b98ae404c8286d2d28f152310 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Tue, 20 Nov 2018 10:35:12 +0100 Subject: [PATCH] Revert "staging: greybus: remove multiple blank lines" This reverts commit fcb733b546ea943dd2e312cc3b556159cb44345a. Johan writes: This patch removes the double newlines that were used as section headers in the lengthy protocol header file, and therefore hurts readability. So I'm reverting it. Reported-by: Johan Hovold Cc: Ioannis Valasakis Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/greybus_protocols.h | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/staging/greybus/greybus_protocols.h b/drivers/staging/greybus/greybus_protocols.h index a0eb72cb225b..2431d660b334 100644 --- a/drivers/staging/greybus/greybus_protocols.h +++ b/drivers/staging/greybus/greybus_protocols.h @@ -65,6 +65,7 @@ #define GB_CONTROL_BUNDLE_ID 0 #define GB_CONTROL_CPORT_ID 0 + /* * All operation messages (both requests and responses) begin with * a header that encodes the size of the message (header included). @@ -94,6 +95,7 @@ struct gb_operation_msg_hdr { __u8 pad[2]; /* must be zero (ignore when read) */ } __packed; + /* Generic request types */ #define GB_REQUEST_TYPE_CPORT_SHUTDOWN 0x00 #define GB_REQUEST_TYPE_INVALID 0x7f @@ -102,6 +104,7 @@ struct gb_cport_shutdown_request { __u8 phase; } __packed; + /* Control Protocol */ /* Greybus control request types */ @@ -246,6 +249,7 @@ struct gb_apb_request_cport_flags { #define GB_APB_CPORT_FLAG_HIGH_PRIO 0x02 } __packed; + /* Firmware Download Protocol */ /* Request Types */ @@ -282,6 +286,7 @@ struct gb_fw_download_release_firmware_request { } __packed; /* firmware download release firmware response has no payload */ + /* Firmware Management Protocol */ /* Request Types */ @@ -363,6 +368,7 @@ struct gb_fw_mgmt_backend_fw_updated_request { } __packed; /* firmware management backend firmware updated response has no payload */ + /* Component Authentication Protocol (CAP) */ /* Request Types */ @@ -399,6 +405,7 @@ struct gb_cap_authenticate_response { __u8 signature[0]; } __packed; + /* Bootrom Protocol */ /* Version of the Greybus bootrom protocol we support */ @@ -467,6 +474,7 @@ struct gb_bootrom_get_vid_pid_response { __le32 product_id; } __packed; + /* Power Supply */ /* Greybus power supply request types */ @@ -640,6 +648,7 @@ struct gb_power_supply_event_request { #define GB_POWER_SUPPLY_UPDATE 0x01 } __packed; + /* HID */ /* Greybus HID operation types */ @@ -685,6 +694,7 @@ struct gb_hid_input_report_request { __u8 report[0]; } __packed; + /* I2C */ /* Greybus i2c request types */ @@ -720,6 +730,7 @@ struct gb_i2c_transfer_response { __u8 data[0]; /* inbound data */ } __packed; + /* GPIO */ /* Greybus GPIO request types */ @@ -818,6 +829,7 @@ struct gb_gpio_irq_event_request { } __packed; /* irq event has no response */ + /* PWM */ /* Greybus PWM operation types */ @@ -1305,6 +1317,7 @@ struct gb_svc_intf_oops_request { } __packed; /* intf_oops response has no payload */ + /* RAW */ /* Greybus raw request types */ @@ -1315,6 +1328,7 @@ struct gb_raw_send_request { __u8 data[0]; } __packed; + /* UART */ /* Greybus UART operation types */ @@ -2190,6 +2204,7 @@ struct gb_audio_send_data_request { __u8 data[0]; } __packed; + /* Log */ /* operations */ -- 2.11.0