From f902d7bc49797ec277b4576c921dfffa15d741dd Mon Sep 17 00:00:00 2001 From: Gilles Debunne Date: Tue, 25 Jan 2011 09:09:46 -0800 Subject: [PATCH] TextLine cache is used, even for long lines of text. Bug 3381368 The 250 characters limit is passed for long URLs. There are only 3 TextLine objects, so their total size is not an issue. Recycle long lines as well to make sure we fill the cache and avoid object creation. Change-Id: I843bf623594312a0fcf0edbb13b7cd64cce0ddd1 --- core/java/android/text/TextLine.java | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/core/java/android/text/TextLine.java b/core/java/android/text/TextLine.java index a6fd2f11ab38..90279d1f63c9 100644 --- a/core/java/android/text/TextLine.java +++ b/core/java/android/text/TextLine.java @@ -90,13 +90,11 @@ class TextLine { tl.mText = null; tl.mPaint = null; tl.mDirections = null; - if (tl.mLen < 250) { - synchronized(cached) { - for (int i = 0; i < cached.length; ++i) { - if (cached[i] == null) { - cached[i] = tl; - break; - } + synchronized(cached) { + for (int i = 0; i < cached.length; ++i) { + if (cached[i] == null) { + cached[i] = tl; + break; } } } -- 2.11.0