From fa319e6d918b84f93fb5457af5d1cca6421ac517 Mon Sep 17 00:00:00 2001 From: Glenn Kasten Date: Mon, 29 Jul 2013 17:17:38 -0700 Subject: [PATCH] Remove CC_LIKELY and CC_UNLIKELY where not needed Only keep them in performance-sensitive code Change-Id: Ib257ddd7bc39ce9896997ffae008c524ac743d01 --- services/audioflinger/AudioFlinger.cpp | 1 - services/audioflinger/Threads.cpp | 11 +++++------ services/audioflinger/Tracks.cpp | 1 - 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/services/audioflinger/AudioFlinger.cpp b/services/audioflinger/AudioFlinger.cpp index cc5af87b7b..b30e2cf17e 100644 --- a/services/audioflinger/AudioFlinger.cpp +++ b/services/audioflinger/AudioFlinger.cpp @@ -37,7 +37,6 @@ #include #include -#include #include #include diff --git a/services/audioflinger/Threads.cpp b/services/audioflinger/Threads.cpp index 3d8fd45a2a..e71c66e9d7 100644 --- a/services/audioflinger/Threads.cpp +++ b/services/audioflinger/Threads.cpp @@ -25,7 +25,6 @@ #include #include #include -#include #include #include #include @@ -1754,7 +1753,7 @@ void AudioFlinger::PlaybackThread::threadLoop_removeTracks( const Vector< sp >& tracksToRemove) { size_t count = tracksToRemove.size(); - if (CC_UNLIKELY(count)) { + if (count) { for (size_t i = 0 ; i < count ; i++) { const sp& track = tracksToRemove.itemAt(i); if (!track->isOutputTrack()) { @@ -2282,7 +2281,7 @@ if (mType == MIXER) { void AudioFlinger::PlaybackThread::removeTracks_l(const Vector< sp >& tracksToRemove) { size_t count = tracksToRemove.size(); - if (CC_UNLIKELY(count)) { + if (count) { for (size_t i=0 ; i& track = tracksToRemove.itemAt(i); mActiveTracks.remove(track); @@ -3551,7 +3550,7 @@ void AudioFlinger::DirectOutputThread::threadLoop_mix() AudioBufferProvider::Buffer buffer; buffer.frameCount = frameCount; mActiveTrack->getNextBuffer(&buffer); - if (CC_UNLIKELY(buffer.raw == NULL)) { + if (buffer.raw == NULL) { memset(curBuf, 0, frameCount * mFrameSize); break; } @@ -3852,7 +3851,7 @@ AudioFlinger::PlaybackThread::mixer_state AudioFlinger::OffloadThread::prepareTr track->mFillingUpStatus = Track::FS_ACTIVE; mLeftVolFloat = mRightVolFloat = 0; if (track->mState == TrackBase::RESUMING) { - if (CC_UNLIKELY(mPausedBytesRemaining)) { + if (mPausedBytesRemaining) { // Need to continue write that was interrupted mCurrentWriteLength = mPausedWriteLength; mBytesRemaining = mPausedBytesRemaining; @@ -4274,7 +4273,7 @@ bool AudioFlinger::RecordThread::threadLoop() buffer.frameCount = mFrameCount; status_t status = mActiveTrack->getNextBuffer(&buffer); - if (CC_LIKELY(status == NO_ERROR)) { + if (status == NO_ERROR) { readOnce = true; size_t framesOut = buffer.frameCount; if (mResampler == NULL) { diff --git a/services/audioflinger/Tracks.cpp b/services/audioflinger/Tracks.cpp index a6c4bda104..4ea135561a 100644 --- a/services/audioflinger/Tracks.cpp +++ b/services/audioflinger/Tracks.cpp @@ -21,7 +21,6 @@ #include "Configuration.h" #include -#include #include #include -- 2.11.0