From fa93d0e1c661693a9940deaef4d03d15988ae9b3 Mon Sep 17 00:00:00 2001 From: Sanjoy Das Date: Fri, 15 May 2015 00:26:21 +0000 Subject: [PATCH] [PlaceSafepoints] Fix a bug that came in with rL236672. Transfer the calling convention from the invoke being replaced by PlaceStatepoints to the new invoke to gc.statepoint created. Add a test case that would have caught this issue. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@237414 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Scalar/PlaceSafepoints.cpp | 2 ++ .../statepoint-calling-conventions.ll | 42 ++++++++++++++++++++++ 2 files changed, 44 insertions(+) create mode 100644 test/Transforms/PlaceSafepoints/statepoint-calling-conventions.ll diff --git a/lib/Transforms/Scalar/PlaceSafepoints.cpp b/lib/Transforms/Scalar/PlaceSafepoints.cpp index 53eed86b81f..319e5c79da4 100644 --- a/lib/Transforms/Scalar/PlaceSafepoints.cpp +++ b/lib/Transforms/Scalar/PlaceSafepoints.cpp @@ -951,6 +951,8 @@ static Value *ReplaceWithStatepoint(const CallSite &CS, /* to replace */ ToReplace->getUnwindDest(), makeArrayRef(CS.arg_begin(), CS.arg_end()), None, None, "safepoint_token"); + Invoke->setCallingConv(ToReplace->getCallingConv()); + // In case if we can handle this set of attributes - set up function // attributes directly on statepoint and return attributes later for // gc_result intrinsic. diff --git a/test/Transforms/PlaceSafepoints/statepoint-calling-conventions.ll b/test/Transforms/PlaceSafepoints/statepoint-calling-conventions.ll new file mode 100644 index 00000000000..e31c2aa5166 --- /dev/null +++ b/test/Transforms/PlaceSafepoints/statepoint-calling-conventions.ll @@ -0,0 +1,42 @@ +; RUN: opt -place-safepoints -S < %s | FileCheck %s + +; Ensure that the gc.statepoint calls / invokes we generate carry over +; the right calling conventions. + +define i64 addrspace(1)* @test_invoke_format(i64 addrspace(1)* %obj, i64 addrspace(1)* %obj1) gc "statepoint-example" { +; CHECK-LABEL: @test_invoke_format( +; CHECK-LABEL: entry: +; CHECK: invoke coldcc i32 (i64, i32, i64 addrspace(1)* (i64 addrspace(1)*)*, i32, i32, ...) @llvm.experimental.gc.statepoint.p0f_p1i64p1i64f(i64 2882400000, i32 0, i64 addrspace(1)* (i64 addrspace(1)*)* @callee, i32 1, i32 0, i64 addrspace(1)* %obj, i32 0, i32 0) +entry: + %ret_val = invoke coldcc i64 addrspace(1)* @callee(i64 addrspace(1)* %obj) + to label %normal_return unwind label %exceptional_return + +normal_return: + ret i64 addrspace(1)* %ret_val + +exceptional_return: + %landing_pad4 = landingpad {i8*, i32} personality i32 ()* @personality + cleanup + ret i64 addrspace(1)* %obj1 +} + +define i64 addrspace(1)* @test_call_format(i64 addrspace(1)* %obj, i64 addrspace(1)* %obj1) gc "statepoint-example" { +; CHECK-LABEL: @test_call_format( +; CHECK-LABEL: entry: +; CHECK: call coldcc i32 (i64, i32, i64 addrspace(1)* (i64 addrspace(1)*)*, i32, i32, ...) @llvm.experimental.gc.statepoint.p0f_p1i64p1i64f(i64 2882400000, i32 0, i64 addrspace(1)* (i64 addrspace(1)*)* @callee, i32 1, i32 0, i64 addrspace(1)* %obj, i32 0, i32 0) +entry: + %ret_val = call coldcc i64 addrspace(1)* @callee(i64 addrspace(1)* %obj) + ret i64 addrspace(1)* %ret_val +} + +; This function is inlined when inserting a poll. +declare void @do_safepoint() +define void @gc.safepoint_poll() { +; CHECK-LABEL: gc.safepoint_poll +entry: + call void @do_safepoint() + ret void +} + +declare coldcc i64 addrspace(1)* @callee(i64 addrspace(1)*) +declare i32 @personality() -- 2.11.0