From faf67e3fe2451e75d0369906a579d3e1386a5064 Mon Sep 17 00:00:00 2001 From: Felipe Leme Date: Mon, 28 Mar 2016 11:15:22 -0700 Subject: [PATCH] Increased estimated max progress of bugreports. The initial estimate was based on earlier work done before new sections were added, and it was too slow. Ideally we should have a per-device estimate, but for N we'll just increase the common max. BUG: 26373682 Change-Id: I1a8ce7f09fc6588ac1513a20fa1149aab8c38351 --- cmds/dumpstate/dumpstate.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/cmds/dumpstate/dumpstate.h b/cmds/dumpstate/dumpstate.h index 02d1256a9f..943f38e823 100644 --- a/cmds/dumpstate/dumpstate.h +++ b/cmds/dumpstate/dumpstate.h @@ -65,11 +65,10 @@ typedef void (for_each_tid_func)(int, int, const char *); * * It does not need to match the exact sum of all sections, but ideally it should to be slight more * than such sum: a value too high will cause the bugreport to finish before the user expected (for - * example, jumping from 70% to 100%), while a value too low will cause the progress to fluctuate - * down (for example, from 70% to 50%, since the actual max will be automatically increased every - * time it is reached). + * example, jumping from 70% to 100%), while a value too low will cause the progress to get stuck + * at an almost-finished value (like 99%) for a while. */ -static const int WEIGHT_TOTAL = 4000; +static const int WEIGHT_TOTAL = 6500; /* Most simple commands have 10 as timeout, so 5 is a good estimate */ static const int WEIGHT_FILE = 5; -- 2.11.0