From fb7e7990342e59cf67dbd895c1a1e3fb1741df7a Mon Sep 17 00:00:00 2001 From: Thomas Huth Date: Thu, 15 Dec 2022 16:30:36 +0100 Subject: [PATCH] tests/qtest/qom-test: Do not print tested properties by default MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit We're still running into the problem that some logs are cut in the gitlab-CI since they got too big. The biggest part of the log is still the output of the qom-test. Let's stop printing the properties by default to get to a saner size here. The full output can still be enabled by setting V=2 (or higher) in the environment. Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message-id: 20221215153036.422362-1-thuth@redhat.com Signed-off-by: Peter Maydell --- tests/qtest/qom-test.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/tests/qtest/qom-test.c b/tests/qtest/qom-test.c index 13510bc349..d380261f8f 100644 --- a/tests/qtest/qom-test.c +++ b/tests/qtest/qom-test.c @@ -14,6 +14,8 @@ #include "qemu/cutils.h" #include "libqtest.h" +static bool verbose; + static void test_properties(QTestState *qts, const char *path, bool recurse) { char *child_path; @@ -49,7 +51,9 @@ static void test_properties(QTestState *qts, const char *path, bool recurse) } } else { const char *prop = qdict_get_str(tuple, "name"); - g_test_message("-> %s", prop); + if (verbose) { + g_test_message("-> %s", prop); + } tmp = qtest_qmp(qts, "{ 'execute': 'qom-get'," " 'arguments': { 'path': %s, 'property': %s } }", @@ -103,6 +107,12 @@ static void add_machine_test_case(const char *mname) int main(int argc, char **argv) { + char *v_env = getenv("V"); + + if (v_env && atoi(v_env) >= 2) { + verbose = true; + } + g_test_init(&argc, &argv, NULL); qtest_cb_for_every_machine(add_machine_test_case, g_test_quick()); -- 2.11.0