Close fd if we aren't going to use it

File descriptors are left open and forgotten.
Make sure to clean up fds after use.

Jira: GSE-1595
Test: Build and boot on Android

Signed-off-by: Kevin Strasser <kevin.strasser@intel.com>

diff --git a/cros_gralloc/cros_gralloc_driver.cc b/cros_gralloc/cros_gralloc_driver.cc
index 87b6475..f78c7e0 100644 (file)
--- a/cros_gralloc/cros_gralloc_driver.cc
+++ b/cros_gralloc/cros_gralloc_driver.cc
@@ -13,6 +13,7 @@
 #include <cstdlib>
 #include <fcntl.h>
 #include <xf86drm.h>
+#include <unistd.h>
 
 cros_gralloc_driver::cros_gralloc_driver() : drv_(nullptr)
 {
@@ -59,11 +60,14 @@ int32_t cros_gralloc_driver::init()
                                continue;
 
                        version = drmGetVersion(fd);
-                       if (!version)
+                       if (!version) {
+                               close(fd);
                                continue;
+            }
 
                        if (undesired[i] && !strcmp(version->name, undesired[i])) {
                                drmFreeVersion(version);
+                               close(fd);
                                continue;
                        }