OSDN Git Service

android-x86/external-minigbm.git
3 years agoUpdate Android.bp after merge
Jason Macnak [Wed, 28 Oct 2020 18:12:09 +0000 (11:12 -0700)]
Update Android.bp after merge

Mostly to reflect changes in http://crrev.com/c/2429952

Bug: b/171019648
Test: launch_cvd
Test: launch_cvd --gpu_mode=gfxstream
Change-Id: I7c15919cb95b04d2dd6eb7c42b4d7d2da61cd75e

3 years agoMerge 'aosp/upstream-master' into HEAD
Jason Macnak [Wed, 28 Oct 2020 20:27:30 +0000 (13:27 -0700)]
Merge 'aosp/upstream-master' into HEAD

... to pull in PlaneLayout metadata fix http://crrev.com/c/2503481

Bug: b/171019648
Test: launch_cvd
Test: launch_cvd --gpu_mode=gfxstream
Change-Id: I9c2a52e2eca3339c024154840cb91f65bb7ed577

3 years agoSync aosp and internal minigbm
Jason Macnak [Wed, 28 Oct 2020 17:54:17 +0000 (10:54 -0700)]
Sync aosp and internal minigbm

The merge in aosp/1431491 did not re-apply many of the changes
from aosp/1431490 as intended.

Bug: b/171019648
Test: launch_cvd
Test: launch_cvd --gpu_mode=gfxstream
Merged-In: Id5222980cc2e7c284a846259c808bf79cf5f2a75
Change-Id: I3a0136b6303a1b1c5e27f7e225466438e3de0616

3 years agocros_gralloc: Fix PlaneLayout width/height metadata
Jason Macnak [Tue, 27 Oct 2020 18:58:35 +0000 (11:58 -0700)]
cros_gralloc: Fix PlaneLayout width/height metadata

... by using the horizontal/vertical subsampling of
each plane.

BUG=b:171019648
TEST=vts -m VtsHalGraphicsMapperV4_0TargetTest

Change-Id: I3eccfa1c0ac30394314c83b54ca50d690c679724
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2503481
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Jason Macnak <natsu@google.com>
Auto-Submit: Jason Macnak <natsu@google.com>
Commit-Queue: Jason Macnak <natsu@google.com>

3 years agogralloctest: update test for ARCVM
David Stevens [Tue, 27 Oct 2020 04:40:17 +0000 (13:40 +0900)]
gralloctest: update test for ARCVM

On ARCVM, the stride obtained from GRALLOC_DRM_GET_STRIDE is the host
stride, and may be larger than the guest stride.

This change also moves the line which prints the next test to execute to
before the test actually runs, so it appears before test failures.

BUG=b:155238003
TEST=tast run DUT arc.Gralloc*

Change-Id: I4594f352fba585fa4bdbaff609f198888b99c8f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2500971
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: David Stevens <stevensd@chromium.org>
Tested-by: David Stevens <stevensd@chromium.org>
3 years agominigbm: vc4: add YUV support
Gurchetan Singh [Mon, 23 Mar 2020 16:46:09 +0000 (09:46 -0700)]
minigbm: vc4: add YUV support

Ozone should work with VC4's MMAL in V4L2.

Change-Id: Ife783f7005628c49756f251692b0cc42e8b47d8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2115562
Reviewed-by: Ewan Roycroft <ewan.roycroft@bbc.co.uk>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Ewan Roycroft <ewan.roycroft@bbc.co.uk>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Gurchetan Singh <gurchetansingh@chromium.org>

3 years agoi915: Enable Y-tiling for huge buffer object for GEN11 GPU
Abhishek Kumar [Fri, 9 Oct 2020 10:38:01 +0000 (16:08 +0530)]
i915: Enable Y-tiling for huge buffer object for GEN11 GPU

Intel GEN11+ Gpu can scan out Y-tiled buffers with maximum width
5320, so enable Y-tiled buffer for GEN11.

BUG=b:168573604 b:168706685
TEST=play 5k video on JSL device

Change-Id: Idb99c9512591e786f796fb32c0e60f549cec03da
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2462328
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Tested-by: Girish DS <girish.ds@intel.corp-partner.google.com>
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>

3 years agominigbm: komeda: Refactor the 'dumb' drivers and add Komeda support
Anders Dellien [Wed, 10 Jun 2020 09:30:44 +0000 (10:30 +0100)]
minigbm: komeda: Refactor the 'dumb' drivers and add Komeda support

Several drivers are very similar in that they only use the 'dumb'
operations. This patch puts all such drivers into a single file and
also adds a driver to support the Arm Komeda/D71 display processor.

TEST=Boot Android and verify that we reach the home screen

Change-Id: If39605deaef446adf8d6693d760a16c2c3f84649
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2429952
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Gurchetan Singh <gurchetansingh@chromium.org>

3 years agominigbm: cros_gralloc: map protected flag to linear
Gurchetan Singh [Fri, 16 Oct 2020 17:28:04 +0000 (10:28 -0700)]
minigbm: cros_gralloc: map protected flag to linear

This should be fine since the dummy fd was never used
with the encoder / decoders, so it doesn't need to be
tiled.

BUG=b/171018855
TEST=GtsExoPlayerTestCases / GtsMediaTestCases

Change-Id: I1309a641e19a9196e0aed05f4820e0d2672fafa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2481223
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: David Stevens <stevensd@chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Auto-Submit: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Gurchetan Singh <gurchetansingh@chromium.org>

3 years agoMerge redfin/bramble support.
Xin Li [Mon, 19 Oct 2020 17:08:14 +0000 (10:08 -0700)]
Merge redfin/bramble support.

Bug: 171218636
Merged-In: I290151f7e04c9c738e06e0859c10cc86f4943aa4
Change-Id: I904e7893b53256789f566b292f38bd9822bf9ee1

3 years agoamdgpu: Align stride to 512 for multiplane formats
Drew Davenport [Fri, 16 Oct 2020 04:18:00 +0000 (22:18 -0600)]
amdgpu: Align stride to 512 for multiplane formats

Quick fix to ensure subsample stride is aligned to 256 for multiplane formats.

BUG=b:171013552
TEST=CtsMediaTestCases passes on zork

Change-Id: I0f47ae3585e5875f3e35cbb667cb7a0ab6421898
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2477987
Reviewed-by: Bas Nieuwenhuizen <basni@chromium.org>
Commit-Queue: Drew Davenport <ddavenport@chromium.org>
Tested-by: Drew Davenport <ddavenport@chromium.org>
3 years agominigbm: stop faking the protected buffers
Gurchetan Singh [Tue, 13 Oct 2020 00:31:10 +0000 (17:31 -0700)]
minigbm: stop faking the protected buffers

With real HW protection on the horizon, let's repurpose the
protection flag to mean that.

Currently, our protected buffer scheme on the Android side
allocates a dummy fd, which is sent to Chrome.  Chrome
associates that dummy fd with an unmappable shared memory
buffer.  In the entire process, minigbm doesn't really do
anything.

We prevent buffers allocated with the protected
flag from being mapped, but since it's a dummy fd it's not
really useful.

Chrome doesn't use the protected flag yet, but hopefully will
so in the future, but with real HW protection.

BUG=
TEST=

Change-Id: I57be26926539471f062ffeff33b523a3899c35f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2466958
Reviewed-by: David Stevens <stevensd@chromium.org>
Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Gurchetan Singh <gurchetansingh@chromium.org>

3 years agoi915: Add gen12 ids for TGL
Sushma Venkatesh Reddy [Thu, 8 Oct 2020 17:18:01 +0000 (10:18 -0700)]
i915: Add gen12 ids for TGL

During 5K/8K HW accelerated video playback, corruptions are observed on
gen12 TGL devices as (i915->gen <= 11) condition is returning true, and
I915_TILING_NONE tile is being set to bo. Adding gen12 ids ensures
buffer allocations happen as per the device's capabilities and here, it
resolves the video corruption issues.

BUG=b:168706685
TEST=Play 5K/8K VP9 codec video

Signed-off-by: Sushma Venkatesh Reddy <sushma.venkatesh.reddy@intel.com>
Change-Id: I24cd0b667f2bf74f73d2377a32f92a148d21c793
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2462345
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Kevin L Derossett <kevin.l.derossett@intel.com>
3 years agovirtgpu: enable blobs for decoder output buffers
David Stevens [Fri, 25 Sep 2020 09:52:26 +0000 (18:52 +0900)]
virtgpu: enable blobs for decoder output buffers

Enabling this requires two changes. First, the check that prevents
BO_USE_RENDERING/BO_USE_TEXTURE buffers from being blobs is removed,
since decoder output buffers are generally used as textures. Second,
NV12 format with no SW usage is added to the list of configurations that
use blobs.

This change also removes the assumption that blobs are mappable, instead
keying off of the software usage flags.

BUG=b:169212117
TEST=Play YouTube on ARCVM

Change-Id: I3fbe744a1ad406fc27f9912296ae4f9b1b55f903
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2430540
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: David Stevens <stevensd@chromium.org>
Tested-by: David Stevens <stevensd@chromium.org>
3 years agominigbm: reduce use of memset
Gurchetan Singh [Wed, 7 Oct 2020 22:28:11 +0000 (15:28 -0700)]
minigbm: reduce use of memset

Also run presubmit.sh.

BUG=none
TEST=compile

Change-Id: I6f5d2afca41c4228a4f8eb40f3670b39bce7b641
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2459529
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Gurchetan Singh <gurchetansingh@chromium.org>

3 years agominigbm/msm: Enable UBWC for NV12 buffers
Fritz Koenig [Fri, 7 Aug 2020 21:56:18 +0000 (14:56 -0700)]
minigbm/msm: Enable UBWC for NV12 buffers

BUG=b:149525848
TEST=video_decode_accelerator_tests use UBWC

Change-Id: I66f44f31f69b2a1d32c66a802c21e0a76d95ec89
Cq-Depend: chromium:2460816, chromium:2455450
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2343729
Tested-by: Kristian H. Kristensen <hoegsberg@chromium.org>
Reviewed-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Fritz Koenig <frkoenig@chromium.org>
Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org>
Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org>

3 years agoSkip ab/6749736 in stage.
Xin Li [Fri, 9 Oct 2020 06:14:04 +0000 (23:14 -0700)]
Skip ab/6749736 in stage.

Bug: 167233921
Merged-In: I534acc55a351de6fe94194de9dba4f55ba43558f
Change-Id: I290151f7e04c9c738e06e0859c10cc86f4943aa4

3 years agominigbm: cros_gralloc: simplify getting the drm format string
Gurchetan Singh [Tue, 6 Oct 2020 00:17:13 +0000 (17:17 -0700)]
minigbm: cros_gralloc: simplify getting the drm format string

Can we do this.

BUG=none
TEST=compile

Change-Id: If9488038f1eb77b92e37d6daa99c8bea495315c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2451522
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Jason Macnak <natsu@google.com>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Gurchetan Singh <gurchetansingh@chromium.org>

3 years agominigbm: remove vgem from minigbm (take 2)
Gurchetan Singh [Thu, 19 Dec 2019 18:01:13 +0000 (10:01 -0800)]
minigbm: remove vgem from minigbm (take 2)

In theory, vgem is only used on Android, and nothing
should fail. In theory.  Otherwise, we can just revert
again.

BUG=b:141278896
TEST=compile

Change-Id: I998cb83d5342e454b876f4b74274df96b4951882
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2412903
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Gurchetan Singh <gurchetansingh@chromium.org>

3 years ago[automerger skipped] Adds Android.bp files back after merge. am: 1e4aff7321 -s ours
Jason Macnak [Fri, 18 Sep 2020 18:46:39 +0000 (18:46 +0000)]
[automerger skipped] Adds Android.bp files back after merge. am: 1e4aff7321 -s ours

am skip reason: Change-Id I27f020b4f661890bcc2817deb09ffb9af1c76f1b with SHA-1 1476c7ea85 is in history

Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/1431492

Change-Id: Iabe5049c49fbc45727f79f8af6dabab5d9c11b31

3 years ago[automerger skipped] Merge remote-tracking branch 'aosp/upstream-master' into HEAD...
Jason Macnak [Fri, 18 Sep 2020 18:46:37 +0000 (18:46 +0000)]
[automerger skipped] Merge remote-tracking branch 'aosp/upstream-master' into HEAD am: 910da248a7 -s ours

am skip reason: Change-Id I27f020b4f661890bcc2817deb09ffb9af1c76f1b with SHA-1 1476c7ea85 is in history

Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/1431491

Change-Id: I5cbf29b4f3e2231b367b0461ce88469647dacf53

3 years ago[automerger skipped] Revert "Merge Android R" am: 56e3e9014e -s ours
Jason Macnak [Fri, 18 Sep 2020 18:46:35 +0000 (18:46 +0000)]
[automerger skipped] Revert "Merge Android R" am: 56e3e9014e -s ours

am skip reason: Change-Id I27f020b4f661890bcc2817deb09ffb9af1c76f1b with SHA-1 1476c7ea85 is in history

Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/1431490

Change-Id: I3e0c015c818604b808a73b6b27a431f79873a791

3 years agoAdds Android.bp files back after merge.
Jason Macnak [Fri, 18 Sep 2020 16:11:12 +0000 (09:11 -0700)]
Adds Android.bp files back after merge.

I removed the Android.bp files from upstream as they seemed
to get out of sync quickly. Let's just keep them in Android
repos.

Bug: b/161909468
Test: launch_cvd
Merged-In: I27f020b4f661890bcc2817deb09ffb9af1c76f1b
Change-Id: Id5222980cc2e7c284a846259c808bf79cf5f2a75

3 years agoMerge remote-tracking branch 'aosp/upstream-master' into HEAD
Jason Macnak [Fri, 18 Sep 2020 16:07:51 +0000 (09:07 -0700)]
Merge remote-tracking branch 'aosp/upstream-master' into HEAD

... to update Minigbm for Cuttlefish to have Gralloc3 and
Gralloc4 support.

Bug: b/161909468
Test: launch_cvd
Merged-In: I27f020b4f661890bcc2817deb09ffb9af1c76f1b
Change-Id: I11e31543d3298c2cac67d80e77058d7cd95907db

3 years agoRevert "Merge Android R"
Jason Macnak [Fri, 18 Sep 2020 15:59:40 +0000 (08:59 -0700)]
Revert "Merge Android R"

This reverts commit 25ff66748d4b08e7059aad06d967128681838fd4, reversing
changes made to 8884508fa662f8e2b11ea1639006fb0e17d65483.

Bug: b/161909468
Test: launch_cvd
Merged-In: I27f020b4f661890bcc2817deb09ffb9af1c76f1b
Change-Id: I9929f68d173fb4d11ca1983a3b4a67dabdd35cf8

3 years agovirtgpu: improve blob support on ARCVM
David Stevens [Thu, 10 Sep 2020 01:50:26 +0000 (10:50 +0900)]
virtgpu: improve blob support on ARCVM

This change expands the types of buffers which use blob allocation, to
cover decoder/encoder bitstream buffers. It also adds tiling to the
exported buffer metadata, so that flush/invalidate are properly skipped
on imported blob buffers.

BUG=None
TEST=tast run ARCVM-DUT arc.VideoDecodeAccel.*

Change-Id: I460f4448db9e1bd2f7458f3180c4e92ff3b3d74f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2400839
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: David Stevens <stevensd@chromium.org>
Commit-Queue: David Stevens <stevensd@chromium.org>

3 years agominigbm: Adds Gralloc 4 support
Jason Macnak [Thu, 10 Sep 2020 17:57:46 +0000 (10:57 -0700)]
minigbm: Adds Gralloc 4 support

Implements the Allocator 4.0 and Mapper 4.0 interfaces.

Some notable features of the 4.0 interface:
- buffer metadata getter/setters
- buffer flushing
- buffer debugging (buffer listing and buffer id)

BUG=b:161909468
TEST=build and launch Cuttlefish with Gralloc4

Change-Id: I63bdc76604207e1fcfe0135c9b64fa62bfba5b27
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2404601
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Jason Macnak <natsu@google.com>
Commit-Queue: Jason Macnak <natsu@google.com>

3 years agominigbm: Remove Android.bp files
Jason Macnak [Thu, 10 Sep 2020 17:51:47 +0000 (10:51 -0700)]
minigbm: Remove Android.bp files

These files quickly become out of sync with Android specific
build changes so just drop them from upstream Chromium repo.

BUG=b:161909468
TEST=build Cuttlefish

Change-Id: Icf4e3eb708e13ba6c807fcc7d0abe06572d341c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2404600
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Jason Macnak <natsu@google.com>
Commit-Queue: Jason Macnak <natsu@google.com>

3 years agominigbm/msm: Correct NV12 UBWC buffer allocation
Fritz Koenig [Wed, 9 Sep 2020 22:22:46 +0000 (15:22 -0700)]
minigbm/msm: Correct NV12 UBWC buffer allocation

V4L2 is the consumer of these buffers and sets up
the allocation in get_framesize_raw_nv12_ubwc().
There was a mismatch where V4L2 was aligning the
uv buffer differently than minigbm.

BUG=b:166157708
TEST=video_decode_accelerator_tests with 856x480 video

Change-Id: Idb9fb689a56639dbc73753d453e7e6e5daeb6700
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2402146
Tested-by: Fritz Koenig <frkoenig@chromium.org>
Commit-Queue: Fritz Koenig <frkoenig@chromium.org>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
3 years ago[automerger skipped] Merge Android R am: 25ff66748d -s ours
Xin Li [Fri, 11 Sep 2020 00:40:16 +0000 (00:40 +0000)]
[automerger skipped] Merge Android R am: 25ff66748d -s ours

am skip reason: Change-Id I8d7971fe52ff43b175a9821c97a6f3c6d380a01d with SHA-1 cf0ceff91e is in history

Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/1422312

Change-Id: Icd0bcaa5dc0cdc76ee41e699bd4e62b98217e726

3 years agominigbm: remove gbm_bo_map(..) discrepancy
Gurchetan Singh [Tue, 24 Mar 2020 18:05:03 +0000 (11:05 -0700)]
minigbm: remove gbm_bo_map(..) discrepancy

We can now use the upstream gbm_bo_map(..) prototype.

BUG=b:145747350
TEST=compile

Change-Id: Ic3e25ebad903da29be4eb085e5a46bf8109de63f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2118475
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: David Riley <davidriley@chromium.org>
Reviewed-by: Lepton Wu <lepton@chromium.org>
3 years agomsm: Clear all sw use flags for UBWC combinations
Kristian H. Kristensen [Tue, 8 Sep 2020 03:28:23 +0000 (03:28 +0000)]
msm: Clear all sw use flags for UBWC combinations

Whether rarely or often, we can't support any kind of sw access if the
buffer is UBWC compressed.  We could potentially add support for
blitting in and out of the buffer, but for now just allocate linear.

BUG=b:167934919
TEST=Buffers allocated with any SW access use flag don't get UBWC

Change-Id: Ic9c1d86a124e24b7bc4aa259c62d8c4882c487b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2397084
Tested-by: Kristian H. Kristensen <hoegsberg@chromium.org>
Reviewed-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org>

3 years agoMerge Android R
Xin Li [Tue, 8 Sep 2020 23:54:40 +0000 (16:54 -0700)]
Merge Android R

Bug: 168057903
Merged-In: I8d7971fe52ff43b175a9821c97a6f3c6d380a01d
Change-Id: Ifc3303bb699d1383828b9f323990bcbf301cffcc

3 years agominigbm: add O_CLOEXEC for the opened fd
Boleyn Su [Fri, 21 Aug 2020 03:31:49 +0000 (12:31 +0900)]
minigbm: add O_CLOEXEC for the opened fd

BUG=b:162475183
TEST=None

Change-Id: Ic7debb48874ad90509954f7138e33a9d88da4898
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2368693
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Lepton Wu <lepton@chromium.org>
Tested-by: Boleyn Su <boleynsu@chromium.org>
Auto-Submit: Boleyn Su <boleynsu@chromium.org>
Commit-Queue: Boleyn Su <boleynsu@chromium.org>

3 years agoMerge "Merge Android R (rvc-dev-plus-aosp-without-vendor@6692709)" into stage-aosp...
Xin Li [Tue, 1 Sep 2020 20:03:53 +0000 (20:03 +0000)]
Merge "Merge Android R (rvc-dev-plus-aosp-without-vendor@6692709)" into stage-aosp-master

3 years agoANDROID: Add target/device support am: 8884508fa6
Alistair Delva [Tue, 1 Sep 2020 00:09:17 +0000 (00:09 +0000)]
ANDROID: Add target/device support am: 8884508fa6

Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/1414810

Change-Id: I8d7971fe52ff43b175a9821c97a6f3c6d380a01d

3 years agoANDROID: Add target/device support
Alistair Delva [Fri, 28 Aug 2020 20:42:24 +0000 (13:42 -0700)]
ANDROID: Add target/device support

Support building libgbm.so for an Android guest.

Change-Id: I1f9d729f847ad9bdd3c8746681e0df00c2107419

3 years agominigbm: virtgpu: add resource create blob function
Gurchetan Singh [Sat, 14 Sep 2019 00:49:20 +0000 (17:49 -0700)]
minigbm: virtgpu: add resource create blob function

Some SW intensive apps could benefit from this.

This should decrease power consumption when playing a Youtube
1080p60fps video by 10%.

BUG=chromium:924405
TEST=mmap_test

Change-Id: I80bb08a95b7387eb8af58e1f0d30beb695fc3e74
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/1804914
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Lingfeng Yang <lfy@google.com>
Reviewed-by: Jason Macnak <natsu@google.com>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Gurchetan Singh <gurchetansingh@chromium.org>

3 years agoAvoid pulling libdrm.so from the AOSP host build am: 70742d1caa
Alistair Delva [Sat, 29 Aug 2020 17:26:29 +0000 (17:26 +0000)]
Avoid pulling libdrm.so from the AOSP host build am: 70742d1caa

Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/1414808

Change-Id: I243a273721b8a45beacfb280bcd89ec39911c64f

3 years agoAvoid pulling libdrm.so from the AOSP host build
Alistair Delva [Fri, 28 Aug 2020 17:28:11 +0000 (10:28 -0700)]
Avoid pulling libdrm.so from the AOSP host build

When binaries depending on minigbm/gbm on the host are linked to it, it
will cause libdrm.so to be taken from the host build done by the Android
build system (i.e. out/host/linux-x86/lib64/libdrm.so), but usually this
library is used with binary GPU drivers that are built out-of-tree, and
they will use the libdrm.so from the host system
(i.e. /usr/lib/x86_64-linux-gnu/libdrm.so.2). As libdrm uses globals to
store things like the ctx hashtable, only one libdrm.so can be loaded
into memory at the same time, or weird crashes in drmClose() and other
drm API functions will occur.

This workaround is only applied to the host "libgbm.so" target, which is
only used by crosvm currently.

Change-Id: Iedcb65d9a031220d8c095fd54a1b967647eb537c

3 years agoMerge Android R (rvc-dev-plus-aosp-without-vendor@6692709)
Xin Li [Fri, 28 Aug 2020 01:46:51 +0000 (18:46 -0700)]
Merge Android R (rvc-dev-plus-aosp-without-vendor@6692709)

Bug: 166295507
Merged-In: Id6c11d1f63223260f5e71ea00b6499164c019abd
Change-Id: I756978f9fcd81c1ac4d6ac39dd4ade23ee05c443

3 years agominigbm: virtgpu: add virgl_protocol.h, add external directory
Gurchetan Singh [Fri, 3 Apr 2020 22:15:30 +0000 (15:15 -0700)]
minigbm: virtgpu: add virgl_protocol.h, add external directory

This adds Mesa protocol headers for BLOB resources.  Also some
code movement.  See:

https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4821

for another example.

BUG=chromium:924405
TEST=compile

Change-Id: I330851e6a58d4e12be8e0e882a230a1cca83e7a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/1804828
Reviewed-by: Jason Macnak <natsu@google.com>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Gurchetan Singh <gurchetansingh@chromium.org>

3 years agoRevert "msm: Disable UBWC briefly while we land the ARC++ modifier support"
Kristian H. Kristensen [Wed, 26 Aug 2020 00:26:24 +0000 (00:26 +0000)]
Revert "msm: Disable UBWC briefly while we land the ARC++ modifier support"

This reverts commit 8e2ae67794c69a25308ffdb6f33ef771c75a97dd.  With the
uprev from CL:2375596, we have support for modifiers all the way from
ARC++, through EGL and exo to KMS and can re-enable UBWC.

BUG=b:145579089, b:79682290, b:163562363
TEST=Once UBWC is enabled again in minigbm, ARC++ buffers should be UBWC
  compressed.

Cq-Depend: chromium:2375596
Change-Id: Iec9bb6f2057eb897fe119750f6a961bbefb871af
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2375673
Reviewed-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Kristian H. Kristensen <hoegsberg@chromium.org>
Commit-Queue: Rob Clark <robdclark@chromium.org>

3 years agominigbm: run presubmit.sh
Gurchetan Singh [Thu, 20 Aug 2020 21:25:43 +0000 (14:25 -0700)]
minigbm: run presubmit.sh

It's good to do this every once and a while.

Change-Id: Ief71a50e07a51e2ac1b66daf1ed0c8b9129d9c1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2368212
Reviewed-by: Jason Macnak <natsu@google.com>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Gurchetan Singh <gurchetansingh@chromium.org>

3 years agocros_gralloc: Add new perform op for getting buffer info
Kristian H. Kristensen [Wed, 12 Aug 2020 22:16:33 +0000 (15:16 -0700)]
cros_gralloc: Add new perform op for getting buffer info

This perform op gives us all the underlying info about the BO, which
lets us import multiplane BOs (such as Intel compressed BOs). This
eliminates a lot of guessing and fudging in EGL and wayland_service
when trying to determine this info from the Android handle.

This generalizes the GET_MODIFIER op, which nothing was using yet.

BUG=b:145579089, b:79682290. b:163562363
TEST=arc++ apps using non-linear format layouts

Change-Id: I821e14477d35794b7247fab59649f564e8ff6985
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2353750
Reviewed-by: Jason Macnak <natsu@google.com>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Kristian H. Kristensen <hoegsberg@chromium.org>
Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org>

3 years agomsm: Disable UBWC briefly while we land the ARC++ modifier support
Kristian H. Kristensen [Wed, 12 Aug 2020 22:12:44 +0000 (15:12 -0700)]
msm: Disable UBWC briefly while we land the ARC++ modifier support

BUG=b:145579089, b:79682290. b:163562363
TEST=Verify that UBWC is off (eg /sys/kernel/debug/dri/1/state)

Change-Id: Icc62960ea12c30bfa709e358ec1cfb097333e6fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2353749
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Kristian H. Kristensen <hoegsberg@chromium.org>
Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org>

3 years agominigbm: Use NV12 for video decoder on MT8183 only
Wei Lee [Wed, 5 Aug 2020 09:24:45 +0000 (17:24 +0800)]
minigbm: Use NV12 for video decoder on MT8183 only

To unblock the HALv3 camera migration for MT8173 platform, we changed to
use NV12 for camera read/write, video hw encoder/decoder for
DRM_FORMAT_FLEX_YCbCr_420_888 format on MT8173 in crrev.com/c/2317328.

However, it broke V4L2 VDA since it does not support NV12, as per
b:162698479.

Since camera will not use video decoder actually, change MT8173
back to use YVU420 for video decoder.

BUG=b:162698479
TEST=tast run [DUT] arc.VideoDecodeAccel.h264

Change-Id: Iee83ab0184541b24ecc9e4fb07138c09228e5440
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2336352
Tested-by: Wei Lee <wtlee@chromium.org>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Wei Lee <wtlee@chromium.org>
Auto-Submit: Wei Lee <wtlee@chromium.org>

3 years agominigbm/msm: Add workaround for waffle
Rob Clark [Fri, 7 Aug 2020 15:08:30 +0000 (08:08 -0700)]
minigbm/msm: Add workaround for waffle

Waffle does not support modifiers, detect it and fall back to linear
buffers.  Fixes glmark2-waffle, glbench/windowmanagertest, etc.

BUG=b:158238296, b:153675943
TEST=run glmark2-waffle and verify it displays correct
TEST=run graphics.Sanity and verify that it passes
TEST=start ui and verify that it still picks UBWC modifier

Change-Id: I591136c8d07bd32beb6f4efa63971821193ce39e
Exempt-From-Owner-Approval: already CR+2 from owner
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2343173
Tested-by: Rob Clark <robdclark@chromium.org>
Commit-Queue: Rob Clark <robdclark@chromium.org>
Reviewed-by: Rob Clark <robdclark@chromium.org>
Auto-Submit: Rob Clark <robdclark@chromium.org>

3 years agoi915: Enable Render Buffer Compression for Gen-11
Binu R S [Mon, 20 Jul 2020 05:06:53 +0000 (10:36 +0530)]
i915: Enable Render Buffer Compression for Gen-11

Enable Render Buffer Compression only for Gen 11

BUG=b:161520827
TEST=Boot target board to UI

Signed-off-by: Binu R S <binu.r.s@intel.com>
Change-Id: I40739732e915a516837a2c7530b4a81679597efe
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2306853
Reviewed-by: Evan Green <evgreen@chromium.org>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Justin TerAvest <teravest@chromium.org>
Tested-by: Mohanram Meenakshisundaram <mohanram.meenakshisundaram@intel.com>
Commit-Queue: Justin TerAvest <teravest@chromium.org>

3 years agominigbm: Enable NV12 for camera usage on MT8173
Wei Lee [Tue, 21 Jul 2020 03:27:14 +0000 (11:27 +0800)]
minigbm: Enable NV12 for camera usage on MT8173

BUG=b:141517606
TEST=tast run [DUT] camera.CCAUI* camera.HAL3*
TEST=Run CtsCameraTestCases

Change-Id: I908f4a9896e716f460325abb741ace4ee8547ad7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2317328
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Wei Lee <wtlee@chromium.org>
Tested-by: Wei Lee <wtlee@chromium.org>
3 years agocros_gralloc: Add perform action for getting the modifier
Kristian H. Kristensen [Thu, 23 Jul 2020 23:04:47 +0000 (16:04 -0700)]
cros_gralloc: Add perform action for getting the modifier

BUG=b:145579089, b:79682290
TEST=arc++ apps using non-linear format layouts

Change-Id: I9d71852b52b984d89428a07fad5c82d61150e8a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2316523
Tested-by: Kristian H. Kristensen <hoegsberg@chromium.org>
Reviewed-by: Jason Macnak <natsu@google.com>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org>

3 years agominigbm: vc4: Fix error log for DRM_IOCTL_VC4_CREATE_BO
Ewan Roycroft [Thu, 23 Jul 2020 15:08:14 +0000 (16:08 +0100)]
minigbm: vc4: Fix error log for DRM_IOCTL_VC4_CREATE_BO

An ioctl call is made to DRM_IOCTL_VC4_CREATE_BO. On error, it
incorrectly reports that DRM_IOCTL_VC4_GEM_CREATE has failed. This fixes
the log message.

Change-Id: I1b817dba1feae370f5fecfd756595c436cc6d6c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2316159
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Ewan Roycroft <ewan.roycroft@bbc.co.uk>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Gurchetan Singh <gurchetansingh@chromium.org>

3 years ago[automerger skipped] Add host build of libgbm.so for crosvm am: 9413c105e4 am: 30d997...
Alistair Delva [Mon, 27 Jul 2020 22:01:20 +0000 (22:01 +0000)]
[automerger skipped] Add host build of libgbm.so for crosvm am: 9413c105e4 am: 30d997f31d -s ours am: a616766046 -s ours

am skip reason: Change-Id I30699c38f958ee03a1b3f8495ecc42e9779f8332 with SHA-1 2c88e76494 is in history

Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/1368796

Change-Id: I534acc55a351de6fe94194de9dba4f55ba43558f

3 years ago[automerger skipped] Add host build of libgbm.so for crosvm am: 9413c105e4 am: 30d997...
Alistair Delva [Mon, 27 Jul 2020 21:48:58 +0000 (21:48 +0000)]
[automerger skipped] Add host build of libgbm.so for crosvm am: 9413c105e4 am: 30d997f31d -s ours

am skip reason: Change-Id I30699c38f958ee03a1b3f8495ecc42e9779f8332 with SHA-1 2c88e76494 is in history

Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/1368796

Change-Id: I9abff193d05dc46d109c08a468a97ff71a212ece

3 years agoAdd host build of libgbm.so for crosvm am: 9413c105e4
Alistair Delva [Mon, 27 Jul 2020 21:39:53 +0000 (21:39 +0000)]
Add host build of libgbm.so for crosvm am: 9413c105e4

Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/1368796

Change-Id: Ia6539242a93745b32b8c17c547bafcebac5b4254

3 years agoAdd host build of libgbm.so for crosvm am: 2c88e76494
Alistair Delva [Mon, 27 Jul 2020 20:07:27 +0000 (20:07 +0000)]
Add host build of libgbm.so for crosvm am: 2c88e76494

Original change: https://googleplex-android-review.googlesource.com/c/platform/external/minigbm/+/12237645

Change-Id: If51f20547b6b73071902ce9c4555424a717bfa3b

3 years agoAdd host build of libgbm.so for crosvm
Alistair Delva [Tue, 21 Jul 2020 19:04:48 +0000 (12:04 -0700)]
Add host build of libgbm.so for crosvm

Build minigbm for the host.

Bug: 161831173
Change-Id: I30699c38f958ee03a1b3f8495ecc42e9779f8332
Merged-In: I30699c38f958ee03a1b3f8495ecc42e9779f8332

3 years agoAdd host build of libgbm.so for crosvm
Alistair Delva [Tue, 21 Jul 2020 19:04:48 +0000 (12:04 -0700)]
Add host build of libgbm.so for crosvm

Build minigbm for the host.

Bug: 161831173
Change-Id: I30699c38f958ee03a1b3f8495ecc42e9779f8332

3 years agominigbm/msm: Don't use uninitialized metadata to setup DRM_FORMAT_R8
Douglas Anderson [Tue, 21 Jul 2020 15:06:46 +0000 (08:06 -0700)]
minigbm/msm: Don't use uninitialized metadata to setup DRM_FORMAT_R8

CL:2245540 seems to have accidentally modified msm.c to use an
uninitialized metadata when setting up DRM_FORMAT_R8.  Let's go back
to using LINEAR_METADATA.

BUG=b:161426616
TEST=Camera no longer crashes

Change-Id: Ia587821216c82d4488b096686904f82147224aa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2310289
Tested-by: Douglas Anderson <dianders@chromium.org>
Auto-Submit: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Reviewed-by: David Stevens <stevensd@chromium.org>
Commit-Queue: Douglas Anderson <dianders@chromium.org>

3 years agodri: Complete the 10-bits formats.
Bas Nieuwenhuizen [Tue, 14 Jul 2020 12:15:38 +0000 (14:15 +0200)]
dri: Complete the 10-bits formats.

They were added to the AMDGPU driver but only half of the formats
were in the mapping table.

Fixes: b16076b "amdgpu: Add 10-bit color formats."

BUG=b:161136516
TEST=run graphics_Gbm on Grunt

Change-Id: I445da2df7b049e3c18456b978a79b28d5b7d008a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2297423
Tested-by: Bas Nieuwenhuizen <basni@chromium.org>
Commit-Queue: Bas Nieuwenhuizen <basni@chromium.org>
Reviewed-by: Drew Davenport <ddavenport@chromium.org>
3 years ago[automerger skipped] cros_gralloc: makes flex format use RGBX am: cbd768f2b3 am:...
Jason Macnak [Mon, 13 Jul 2020 16:31:59 +0000 (16:31 +0000)]
[automerger skipped] cros_gralloc: makes flex format use RGBX am: cbd768f2b3 am: 9f909ad34e -s ours am: 0709f569be -s ours

am skip reason: Change-Id I27f020b4f661890bcc2817deb09ffb9af1c76f1b with SHA-1 1476c7ea85 is in history

Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/1359582

Change-Id: Ifd471b1e5e0422d16aecd56df0fcb0f6f92ef4a9

3 years ago[automerger skipped] cros_gralloc: makes flex format use RGBX am: cbd768f2b3 am:...
Jason Macnak [Mon, 13 Jul 2020 16:14:45 +0000 (16:14 +0000)]
[automerger skipped] cros_gralloc: makes flex format use RGBX am: cbd768f2b3 am: 9f909ad34e -s ours

am skip reason: Change-Id I27f020b4f661890bcc2817deb09ffb9af1c76f1b with SHA-1 1476c7ea85 is in history

Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/1359582

Change-Id: Id6c11d1f63223260f5e71ea00b6499164c019abd

3 years agocros_gralloc: makes flex format use RGBX am: cbd768f2b3
Jason Macnak [Mon, 13 Jul 2020 16:02:58 +0000 (16:02 +0000)]
cros_gralloc: makes flex format use RGBX am: cbd768f2b3

Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/1359582

Change-Id: Ie13c165594322fea07b6c946a5b569a14ea81208

3 years agomeson: Add support for YUV formats
Daniel Nicoara [Thu, 9 Jul 2020 23:15:42 +0000 (19:15 -0400)]
meson: Add support for YUV formats

Add support to allocate a number of YUV formats. Particularly around
NV12 which can be used in the camera and encoder. This will allow
allocating/sharing buffers across multiple devices via dmabuf.

BUG=b/159467426
TEST=Allocate NV12 buffer and composite it on the GPU.

Change-Id: I9b5dc54dae7f578f7e099a64bd67589658693534
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2291194
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Tested-by: Daniel Nicoara <dnicoara@chromium.org>
3 years agocros_gralloc: makes flex format use RGBX
Jason Macnak [Thu, 9 Jul 2020 20:39:18 +0000 (13:39 -0700)]
cros_gralloc: makes flex format use RGBX

Cuttlefish's current camera hal and emulated camera implementation
assumes that HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED is RGBA.

Note: this will be Android specific change and will not upstream
and this change should be reverted when the new hal and emulated
camera implementation lands.

Bug: b/157902551
Test: cts -m CtsCameraTestCases
Change-Id: Ifb4f37a66e1bc012790b45c7c10d491c039bd58c
Merged-In: I27f020b4f661890bcc2817deb09ffb9af1c76f1b

3 years agoamdgpu: Add 10-bit color formats.
Bas Nieuwenhuizen [Mon, 29 Jun 2020 10:41:18 +0000 (12:41 +0200)]
amdgpu: Add 10-bit color formats.

Should be fine for rendering and texturing.

AMDGPU only exposes this on the primary plane though, not on the
overlay or cursor. I strongly suspect the HW could also do this
on the overlay but I lack a proper testcase for now.

BUG=b:159011420
TEST=Run tast.video.Play.vp9_2_sw on Zork

Change-Id: Ie3a5356576a960985aac0ba16665425f45bd1541
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2272566
Tested-by: Bas Nieuwenhuizen <basni@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Bas Nieuwenhuizen <basni@chromium.org>

3 years agocros_gralloc: fix log statement format specifier
Jason Macnak [Wed, 8 Jul 2020 21:51:13 +0000 (14:51 -0700)]
cros_gralloc: fix log statement format specifier

BUG=b:157902551
TEST=build 64-bit Cuttlefish

Change-Id: Ica6942dca23d562f4527233dd614b8f1ab10b00c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2288583
Tested-by: Jason Macnak <natsu@google.com>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Jason Macnak <natsu@google.com>

3 years agocros_gralloc: set install path in Android.bp
Jason Macnak [Wed, 8 Jul 2020 18:46:13 +0000 (11:46 -0700)]
cros_gralloc: set install path in Android.bp

BUG=b:157902551
TEST=run Cuttlefish w/ Minigbm Gralloc0

Change-Id: I284e911371d0672b1c6663ad601455dd326b8632
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2288141
Tested-by: Jason Macnak <natsu@google.com>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Jason Macnak <natsu@google.com>

3 years ago[automerger skipped] cros_gralloc: Fix logging statement format specifier am: b26e66e...
Jason Macnak [Wed, 8 Jul 2020 23:33:55 +0000 (23:33 +0000)]
[automerger skipped] cros_gralloc: Fix logging statement format specifier am: b26e66e866 am: 2530ad5e17 -s ours am: 7332e7e350 -s ours

am skip reason: Change-Id I27f020b4f661890bcc2817deb09ffb9af1c76f1b with SHA-1 1476c7ea85 is in history

Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/1358924

Change-Id: Id3b31e6687787714054090115d1a14a7b4871257

3 years ago[automerger skipped] cros_gralloc: Fix logging statement format specifier am: b26e66e...
Jason Macnak [Wed, 8 Jul 2020 23:26:48 +0000 (23:26 +0000)]
[automerger skipped] cros_gralloc: Fix logging statement format specifier am: b26e66e866 am: 2530ad5e17 -s ours

am skip reason: Change-Id I27f020b4f661890bcc2817deb09ffb9af1c76f1b with SHA-1 1476c7ea85 is in history

Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/1358924

Change-Id: Ie812cafe90f864ccbfa3ceb555953c8e28c94465

3 years agocros_gralloc: Fix logging statement format specifier am: b26e66e866
Jason Macnak [Wed, 8 Jul 2020 23:15:05 +0000 (23:15 +0000)]
cros_gralloc: Fix logging statement format specifier am: b26e66e866

Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/1358924

Change-Id: Ifeb5ed4f935d3c3e432290dfec01d5e52aec4ce5

3 years agocros_gralloc: Fix logging statement format specifier
Jason Macnak [Wed, 8 Jul 2020 21:37:28 +0000 (14:37 -0700)]
cros_gralloc: Fix logging statement format specifier

Bug: b/160813623
Test: lunch aosp_x86_64-eng && m
Change-Id: I8101c2f99925d877d14ef8f4cce372e73288bc22
Merged-In: I27f020b4f661890bcc2817deb09ffb9af1c76f1b

3 years ago[automerger skipped] cros_gralloc: set install path in Android.bp am: 410021fde7...
Jason Macnak [Wed, 8 Jul 2020 21:47:47 +0000 (21:47 +0000)]
[automerger skipped] cros_gralloc: set install path in Android.bp am: 410021fde7 am: b63e9ba9e0 -s ours am: 5adb60eebf -s ours

am skip reason: Change-Id I27f020b4f661890bcc2817deb09ffb9af1c76f1b with SHA-1 1476c7ea85 is in history

Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/1358644

Change-Id: Ica2a30f04529e9d2dcc3aeea506c15ca63e7ee3f

3 years ago[automerger skipped] Merge 'aosp/upstream-master' into 'aosp/master' am: b337d757c9...
Jason Macnak [Wed, 8 Jul 2020 21:47:45 +0000 (21:47 +0000)]
[automerger skipped] Merge 'aosp/upstream-master' into 'aosp/master' am: b337d757c9 am: f034387461 -s ours am: cb6d35f648 -s ours

am skip reason: Change-Id I27f020b4f661890bcc2817deb09ffb9af1c76f1b with SHA-1 1476c7ea85 is in history

Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/1358643

Change-Id: Idd351d88d44f174445d5faba2adc393ddf4fe4a0

3 years ago[automerger skipped] cros_gralloc: set install path in Android.bp am: 410021fde7...
Jason Macnak [Wed, 8 Jul 2020 21:38:00 +0000 (21:38 +0000)]
[automerger skipped] cros_gralloc: set install path in Android.bp am: 410021fde7 am: b63e9ba9e0 -s ours

am skip reason: Change-Id I27f020b4f661890bcc2817deb09ffb9af1c76f1b with SHA-1 1476c7ea85 is in history

Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/1358644

Change-Id: I0f2532d0329a36de10d66e4ed8c8b44d7873d249

3 years ago[automerger skipped] Merge 'aosp/upstream-master' into 'aosp/master' am: b337d757c9...
Jason Macnak [Wed, 8 Jul 2020 21:37:58 +0000 (21:37 +0000)]
[automerger skipped] Merge 'aosp/upstream-master' into 'aosp/master' am: b337d757c9 am: f034387461 -s ours

am skip reason: Change-Id I27f020b4f661890bcc2817deb09ffb9af1c76f1b with SHA-1 1476c7ea85 is in history

Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/1358643

Change-Id: I1bf99b0208d389681cf0d88b12dd62003e49507f

3 years agocros_gralloc: set install path in Android.bp am: 410021fde7
Jason Macnak [Wed, 8 Jul 2020 21:20:01 +0000 (21:20 +0000)]
cros_gralloc: set install path in Android.bp am: 410021fde7

Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/1358644

Change-Id: I55adc2b5857f696c7ac6af0f38c9fa09215866d1

3 years agoMerge 'aosp/upstream-master' into 'aosp/master' am: b337d757c9
Jason Macnak [Wed, 8 Jul 2020 21:19:59 +0000 (21:19 +0000)]
Merge 'aosp/upstream-master' into 'aosp/master' am: b337d757c9

Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/1358643

Change-Id: I8cd59f945e4ce5553510fc0bb14bf5d857ca06b9

3 years agocros_gralloc: set install path in Android.bp
Jason Macnak [Wed, 8 Jul 2020 19:05:51 +0000 (12:05 -0700)]
cros_gralloc: set install path in Android.bp

Upstream change in crrev.com/c/2288141

Bug: b/157902551
Test: run Cuttlefish w/ Minigbm Gralloc0
Merged-In: I27f020b4f661890bcc2817deb09ffb9af1c76f1b
Change-Id: I92bf42f1f7ff82c0c6697f131b01557a5fc94767

3 years agoMerge 'aosp/upstream-master' into 'aosp/master'
Jason Macnak [Wed, 8 Jul 2020 19:03:20 +0000 (12:03 -0700)]
Merge 'aosp/upstream-master' into 'aosp/master'

... to update Minigbm for Cuttlefish to support Gralloc3
on Minigbm.

Bug: b/157902551
Test: m && launch_cvd --gpu_mode=gfxstream
Test: m && launch_cvd --gpu_mode=drm_virgl
Merged-In: I27f020b4f661890bcc2817deb09ffb9af1c76f1b
Change-Id: Ic96add709a99005ff7aa6c7d886e3069b827e4bc

3 years agocros_gralloc: Adds gralloc 3.0 support
Jason Macnak [Fri, 24 Jan 2020 23:05:57 +0000 (15:05 -0800)]
cros_gralloc: Adds gralloc 3.0 support

Implements the allocator 3.0 and mapper 3.0 interfaces
which:

 - Implements HIDL interface directly (older versions
   are wrapped in a passthrough HIDL interface)

 - Adds isSupported() to allow checking for format and
   usage combination support before allocating.

Adds emulated multi-planar buffer support to virtio
backend for non gbm enabled hosts.

Updates cros_gralloc_handle to use uint64_t instead of
two uint32_t for some members.

Updates cros_gralloc_handle to have a single format
modifier.

Replaces Android makefiles with Android bp files.

BUG=b:146515640
TEST=run Cuttlefish w/ gralloc3 and run CTS tests

Change-Id: I43ed9788a2413201bddce17ffb69b76006ef39fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2273554
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Jason Macnak <natsu@google.com>
Commit-Queue: Jason Macnak <natsu@google.com>

3 years agominigbm:amdgpu: align height to 16 bit for video buffers
Ikshwaku Chauhan [Mon, 29 Jun 2020 11:14:57 +0000 (16:44 +0530)]
minigbm:amdgpu: align height to 16 bit for video buffers

Currently, allocator used by chrome aligns the height of Encoder/Decoder
buffer while allocator used by android(gralloc/minigbm) doesn't provide
any aligment.Aligned the height for video buffers in minigbm.

BUG=b:153130069
TEST=cheets_CTS_P.x86.CtsVideoTestCases

Signed-off-by: Ikshwaku Chauhan <ikshwaku.chauhan@amd.corp-partner.google.com>
Change-Id: I62a883ca55c07674fab7981af0974277fbd2c5b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2273037
Reviewed-by: Bas Nieuwenhuizen <basni@chromium.org>
Reviewed-by: Drew Davenport <ddavenport@chromium.org>
Tested-by: Drew Davenport <ddavenport@chromium.org>
Commit-Queue: Drew Davenport <ddavenport@chromium.org>

3 years agoRevert "Revert "amdgpu: Set USWC for SCANOUT images.""
Bas Nieuwenhuizen [Thu, 4 Jun 2020 21:11:27 +0000 (23:11 +0200)]
Revert "Revert "amdgpu: Set USWC for SCANOUT images.""

This reverts commit 91d36976aa84abde87f0f56d235d57042ca3ea81.i

The previous changes should fix the mapping performance with USWC
memory.

original change:
    amdgpu: Set USWC for SCANOUT images.

    This is necessary for scanout from GTT. Without it, the kernel will
    migrate it to the carveout. For large resolutions this would not be
    feasible due to small carveout sizes and hence it is important that
    we alloc scanout from GTT.

    The original patch was on top of
    4eebcea "amdgpu: make AMDGPU_GEM_CREATE_CPU_GTT_USWC flag default"
    which set USWC unconditionally, but has since been reverted. The
    main failure reason is being addressed in mesa-amd. This patch also
    still disables USWC if we can and the image will be read often on
    the CPU, to avoid staging textures during memory mapping.

TEST=Run android.hardware.camera2.cts.RecordingTest#testVideoPreviewSurfaceSharing on Grunt.
BUG=b:152378755

Change-Id: Ice0041de6676c057a2659986b962c2d54833e928
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2246025
Tested-by: Bas Nieuwenhuizen <basni@chromium.org>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Bas Nieuwenhuizen <basni@chromium.org>

3 years agoamdgpu: Add SDMA copy support.
Bas Nieuwenhuizen [Sat, 20 Jun 2020 01:50:34 +0000 (03:50 +0200)]
amdgpu: Add SDMA copy support.

For SCANOUT images we need to use USWC memory. However USWC
memory is very slow to read from (~25 MiB/second).

At the same time for video decoding there are some images
that are allocated with SCANOUT but at the same time frequently
accessed from the CPU. Just mapping these is going to result
in non-satisfactory performance, so this patch adds a DMA step
to copy it to memory that is faster to acces from the CPU.

Benchmarked on Grunt with
android.hardware.camera2.cts.RecordingTest#testVideoPreviewSurfaceSharing

The time that an image (~500 KiB) is kept mapped for processing,
including the time for mapping and unmapping:

plain GTT (cachaeable):  1.5-2 ms
USWC:                    45-50 ms
USWC w/ memcpy:          20-30 ms
USWC w/ SDMA copy:       3.5-5.5 ms

We can clearly see that the Android video processing code only gets
a throughput of ~10 MiB/s with USWC memory. memcpy is slightly more
efficient by getting 20-30 MiB/s, but neither of these are suitable
for 30+ fps video.

Furthermore, with SDMA copy, the timing is roughly as follows:

map:
  - Allocate plain GTT BO:        ~400-800 us
  - map src & dst BO into GPU VM: ~25 us
  - submit SDMA copy:             ~80 us
  - wait till SDMA copy finishes: ~400 us
  - unmap src & dst BO from GPU:  ~15 us
  - map dst BO into CPU:          ~30 us

unmap:
  - unmapping dst BO from CPU:    ~30 us
  - Copy not benchmarked (avoided for RO map)
  - delete BO:                    ~100 us

ideas for further improvement:
  - BO cache
  - rely on implicit sync and don't wait for the copy during
    unmapping.

Alternatives that have been rejected:
  - Use radeonsi + DRI interface: each plane gets mapped into
    its own BO, which is an issue for gralloc.
  - more persistently mapping each BO into GPU VM: this needs
    proper address space management which adds complexity.
    librm_amdgpu can do it for us but brings its own can of worms
    with dedup of the drm fd. (which makes e.g. implicit sync not
    work with any radeonsi instances in the same process)
  - Use SDMA instead of DRI/Radeonsi for more images. This is an
    issue because SDMA for images is a whole mess with lots of
    corner cases and lots of changes per generation. Furthermore,
    it wouldn't work for DCC compressed images.

TEST=Run android.hardware.camera2.cts.RecordingTest#testVideoPreviewSurfaceSharing on Grunt.
BUG=b:152378755

Change-Id: I8f5e00ff4b6d9e31f78fd4de7eb62d0d3aa66438
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2256228
Tested-by: Bas Nieuwenhuizen <basni@chromium.org>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Bas Nieuwenhuizen <basni@chromium.org>

3 years agoModify NV12 allowed buffer usages for camera capture use case
Hirokazu Honda [Tue, 23 Jun 2020 08:52:20 +0000 (17:52 +0900)]
Modify NV12 allowed buffer usages for camera capture use case

We use SCANOUT_VEA_READ_CAMERA_AND_CPU_READ_WRITE for camera
capture use scenario in Chrome. Therefore, NV12 format must be
allowed for all those usage masks. This CL modifies the usages on
all platforms.

BUG=chromium:982201
TEST=video.EncodeAccel.vp8_720p_i420 on eve

Change-Id: I7880e64049f3bbf9dd1c177619e41362baf641f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2240995
Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>

3 years agominigbm: virtio-gpu: Remove offset log message
Matthias Springer [Mon, 22 Jun 2020 01:05:22 +0000 (10:05 +0900)]
minigbm: virtio-gpu: Remove offset log message

When running the Zoom Android client, "Non-zero transfer offset" was
printed in the logs. We now know for sure that we encounter this case in
the wild, thus removing the log message.

BUG=none
TEST=build minigbm manually

Change-Id: I1a536df50996e5218548fb097543566affa9af3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2255931
Tested-by: Matthias Springer <springerm@chromium.org>
Auto-Submit: Matthias Springer <springerm@chromium.org>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Matthias Springer <springerm@chromium.org>

3 years agoRemove HW_VIDEO_ENCODER usage of YVU420
Hirokazu Honda [Tue, 16 Jun 2020 06:28:56 +0000 (15:28 +0900)]
Remove HW_VIDEO_ENCODER usage of YVU420

minigbm has allowed HW_VIDEO_ENCODER usage to YVU420 so that
chrome can allocate YVU420 with HW_VIDEO_ENCODER. But this
format is no longer allocated by chrome with the usage. Let's
delete the code.

BUG=chromium:982201
TEST=None

Change-Id: Ia6bbc24e7782e3e73c2eb00c00127af212ddf486
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2245967
Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Tested-by: Hirokazu Honda <hiroh@chromium.org>
Auto-Submit: Hirokazu Honda <hiroh@chromium.org>

3 years agominigbm: add encoder/decoder blob combination
David Stevens [Mon, 15 Jun 2020 04:48:48 +0000 (13:48 +0900)]
minigbm: add encoder/decoder blob combination

ARCVM sets encoder/decoder usage on the blob output/input buffers, so
that virtio_gpu knows to perform transfers from/to the host where
appropriate. Recently, virtio_gpu started passing all bind flags to the
host, instead of reducing them in the guest. These factors combined
means that the host backends now need to support encoder/decoder usage
with R8 format.

Test: manually verify ARCVM YouTube
Bug: b:158957350
Change-Id: I58bf657496647f8002c693d17a1186f4cf527b01
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2245540
Tested-by: David Stevens <stevensd@chromium.org>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: David Stevens <stevensd@chromium.org>

3 years agogralloc: Use YVU420_ANDROID for YCbCr flex am: 06d77b4e7d am: eefde98531
Jason Macnak [Thu, 11 Jun 2020 22:32:44 +0000 (22:32 +0000)]
gralloc: Use YVU420_ANDROID for YCbCr flex am: 06d77b4e7d am: eefde98531

Original change: https://googleplex-android-review.googlesource.com/c/platform/external/minigbm/+/11817987

Change-Id: I6fe35969d638395aef1e5e613534ff6661993036

3 years agogralloc: Use YVU420_ANDROID for YCbCr flex am: 06d77b4e7d am: a07fb5901a
Jason Macnak [Thu, 11 Jun 2020 22:32:24 +0000 (22:32 +0000)]
gralloc: Use YVU420_ANDROID for YCbCr flex am: 06d77b4e7d am: a07fb5901a

Original change: https://googleplex-android-review.googlesource.com/c/platform/external/minigbm/+/11817987

Change-Id: Ic2e66c7ce27fc07a3e202d4e31e615823a4856ca

3 years agogralloc: Use YVU420_ANDROID for YCbCr flex am: 06d77b4e7d
Jason Macnak [Thu, 11 Jun 2020 22:20:45 +0000 (22:20 +0000)]
gralloc: Use YVU420_ANDROID for YCbCr flex am: 06d77b4e7d

Original change: https://googleplex-android-review.googlesource.com/c/platform/external/minigbm/+/11817987

Change-Id: I5cba8e31b5ff2636bcf7b0579531d787b585f1b8

3 years agogralloc: Use YVU420_ANDROID for YCbCr flex am: 06d77b4e7d
Jason Macnak [Thu, 11 Jun 2020 22:20:34 +0000 (22:20 +0000)]
gralloc: Use YVU420_ANDROID for YCbCr flex am: 06d77b4e7d

Original change: https://googleplex-android-review.googlesource.com/c/platform/external/minigbm/+/11817987

Change-Id: Iea468f3f71e885dd2826188f3b09c07d34b5c6f0

3 years agogralloc: Use YVU420_ANDROID for YCbCr flex
Jason Macnak [Thu, 11 Jun 2020 05:39:06 +0000 (22:39 -0700)]
gralloc: Use YVU420_ANDROID for YCbCr flex

... to fix camera preview.

Bug: b/146515640
Bug: b/158703419
Test: manually open default camera app
Test: manually open TestingCamera app
Change-Id: Ice550649c5fa125cc09394bd17ad8a5f9c4ed2fa

3 years agominigbm: virtio_gpu: add BO_USE_HW_VIDEO_ENCODER usage to R8 format.
David Staessens [Thu, 28 May 2020 06:47:15 +0000 (15:47 +0900)]
minigbm: virtio_gpu: add BO_USE_HW_VIDEO_ENCODER usage to R8 format.

This combination will be used by ARCVM for video encoder bitstream
blobs. Minigbm uses the usage flags to determine whether it needs to
transfer data to/from the host, and whether that transfer needs to be
synchronous. BO_USE_HW_VIDEO_ENCODER needs to be set on the encoder's
output buffers so that minigbm knows that the host modifies the buffer,
so that minigbm transfers the data to the guest.

BUG=b:143570994
TEST=emerge-$BOARD minigbm arc-cros-gralloc

Change-Id: I05eb35d7b68092138c337c0e7fc43f60dd1bc32d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2217833
Tested-by: David Staessens <dstaessens@chromium.org>
Commit-Queue: David Staessens <dstaessens@chromium.org>
Reviewed-by: David Stevens <stevensd@chromium.org>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
3 years agominigbm: virtio_gpu: use expanded bind flags
David Stevens [Fri, 15 May 2020 05:15:35 +0000 (14:15 +0900)]
minigbm: virtio_gpu: use expanded bind flags

Pass more bind flags from minigbm to virglrenderer. This is necessary to
handle cases where special alignment/padding is required for certain
use cases. For example, jpeg camera recording on mediatek requires extra
padding. Minigbm adds this due to BO_USE_HW_VIDEO_ENCODER, so that flag
must be properly passed from virtio_gpu to host minigbm.

BUG: b:151197279
TEST: verify that ArcCameraFpsTest recording works on kukui

Change-Id: Ie2871b37ca468930abe41738ed0ee4fad0f4cf1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2203164
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: David Stevens <stevensd@chromium.org>
Tested-by: David Stevens <stevensd@chromium.org>
3 years agominigbm/msm: Add DRM_FORMAT_FLEX_IMPLEMENTATION_DEFINED for msm
Douglas Anderson [Tue, 19 May 2020 17:12:14 +0000 (10:12 -0700)]
minigbm/msm: Add DRM_FORMAT_FLEX_IMPLEMENTATION_DEFINED for msm

It seems to be tradition to copy a bit of code into the
resolve_format() function for everyone.  The msm driver isn't one to
break from tradition, so we'll adopt this code fragment too.

BUG=b:154782445
TEST=Hangout

Change-Id: I9e8eaf0c5a8485afea82437fd7249e24e5509b5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2209178
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Commit-Queue: Douglas Anderson <dianders@chromium.org>
Tested-by: Douglas Anderson <dianders@chromium.org>
3 years agogralloc4: adds gralloc4 support am: 1476c7ea85 am: 06937a2a57
Marissa Wall [Fri, 29 May 2020 19:18:17 +0000 (19:18 +0000)]
gralloc4: adds gralloc4 support am: 1476c7ea85 am: 06937a2a57

Change-Id: Id24f09a864db2b9b78a80aeef5625754849cb3bf

3 years agogralloc4: adds gralloc4 support am: 1476c7ea85 am: b2ccef119d
Marissa Wall [Fri, 29 May 2020 19:18:05 +0000 (19:18 +0000)]
gralloc4: adds gralloc4 support am: 1476c7ea85 am: b2ccef119d

Change-Id: I1597e1e805faeb5fcaaa73d452be28d313a6b23c

3 years agogralloc4: adds gralloc4 support am: 1476c7ea85
Marissa Wall [Fri, 29 May 2020 19:04:54 +0000 (19:04 +0000)]
gralloc4: adds gralloc4 support am: 1476c7ea85

Change-Id: I4a241480e9f397d4cd9869e72c35ba7a00ae615f

3 years agogralloc4: adds gralloc4 support am: 1476c7ea85
Marissa Wall [Fri, 29 May 2020 19:04:21 +0000 (19:04 +0000)]
gralloc4: adds gralloc4 support am: 1476c7ea85

Change-Id: I88b8fa28c41bd0918740a4775a85477d0bdcf43d