From 3001b29507244e2f82fc7a3d39b7e5879875b27d Mon Sep 17 00:00:00 2001 From: Gurchetan Singh Date: Wed, 19 Oct 2016 17:43:43 -0700 Subject: [PATCH] minigbm: Remove SCANOUT flags from YV12 MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit All of these drivers don't support the ability to directly scan-out YV12 to the display, so this should not be set. Let's set rendering flags since the expected use case is importing Android YV12 buffers into EGL. BUG=b/32260847 TEST=AdaptivePlaybackTest#testH264_adaptiveDrc Change-Id: I53d4eaf9c3f359c1c83762cf3e655cc0cf5168d5 Reviewed-on: https://chromium-review.googlesource.com/401040 Commit-Ready: Gurchetan Singh Tested-by: Gurchetan Singh Reviewed-by: Stéphane Marchesin --- i915.c | 5 ++--- mediatek.c | 4 ++-- rockchip.c | 4 ++-- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/i915.c b/i915.c index f2efadc..6bd1b96 100644 --- a/i915.c +++ b/i915.c @@ -260,9 +260,8 @@ const struct backend backend_i915 = DRV_BO_USE_SW_READ_OFTEN | DRV_BO_USE_SW_WRITE_OFTEN}, {DRV_FORMAT_GR88, DRV_BO_USE_SCANOUT | DRV_BO_USE_LINEAR | DRV_BO_USE_SW_READ_OFTEN | DRV_BO_USE_SW_WRITE_OFTEN}, - {DRV_FORMAT_YVU420, DRV_BO_USE_LINEAR}, - {DRV_FORMAT_YVU420, DRV_BO_USE_SCANOUT | DRV_BO_USE_RENDERING | - DRV_BO_USE_SW_READ_RARELY | DRV_BO_USE_SW_WRITE_RARELY}, + {DRV_FORMAT_YVU420, DRV_BO_USE_RENDERING | DRV_BO_USE_SW_READ_RARELY | + DRV_BO_USE_SW_WRITE_RARELY}, } }; diff --git a/mediatek.c b/mediatek.c index 9245ada..381d8ab 100644 --- a/mediatek.c +++ b/mediatek.c @@ -97,8 +97,8 @@ const struct backend backend_mediatek = | DRV_BO_USE_SW_READ_RARELY | DRV_BO_USE_SW_WRITE_RARELY}, {DRV_FORMAT_RGB565, DRV_BO_USE_SCANOUT | DRV_BO_USE_CURSOR | DRV_BO_USE_RENDERING | DRV_BO_USE_SW_READ_RARELY | DRV_BO_USE_SW_WRITE_RARELY}, - {DRV_FORMAT_YVU420, DRV_BO_USE_LINEAR | DRV_BO_USE_SCANOUT | - DRV_BO_USE_SW_READ_OFTEN | DRV_BO_USE_SW_WRITE_OFTEN}, + {DRV_FORMAT_YVU420, DRV_BO_USE_RENDERING | DRV_BO_USE_SW_READ_RARELY | + DRV_BO_USE_SW_WRITE_RARELY}, } }; diff --git a/rockchip.c b/rockchip.c index 3d3790c..f2b9417 100644 --- a/rockchip.c +++ b/rockchip.c @@ -122,8 +122,8 @@ const struct backend backend_rockchip = DRV_BO_USE_SW_READ_RARELY | DRV_BO_USE_SW_WRITE_RARELY}, {DRV_FORMAT_NV12, DRV_BO_USE_SCANOUT | DRV_BO_USE_LINEAR | DRV_BO_USE_SW_READ_OFTEN | DRV_BO_USE_SW_WRITE_OFTEN}, - {DRV_FORMAT_YVU420, DRV_BO_USE_LINEAR | DRV_BO_USE_SCANOUT | - DRV_BO_USE_SW_READ_OFTEN | DRV_BO_USE_SW_WRITE_OFTEN}, + {DRV_FORMAT_YVU420, DRV_BO_USE_RENDERING | DRV_BO_USE_SW_READ_RARELY | + DRV_BO_USE_SW_WRITE_RARELY}, } }; -- 2.11.0