OSDN Git Service
Larry Finger [Tue, 3 Dec 2013 18:27:43 +0000 (12:27 -0600)]
rtl8723au: Remove some trailing white space
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Jes Sorensen [Tue, 3 Dec 2013 17:27:17 +0000 (18:27 +0100)]
Remove another set of unecessary typedefs
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Tue, 3 Dec 2013 17:27:16 +0000 (18:27 +0100)]
int is signed - no point in inventing an unnecessary sint type
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Tue, 3 Dec 2013 17:27:15 +0000 (18:27 +0100)]
Remove gross PVOID type
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Tue, 3 Dec 2013 17:27:14 +0000 (18:27 +0100)]
Remove hopeless Windows ULONG/USHORT/UCHAR types
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Tue, 3 Dec 2013 17:27:13 +0000 (18:27 +0100)]
Remove more non Linux gibberish
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Tue, 3 Dec 2013 17:27:12 +0000 (18:27 +0100)]
Remove semaphore wrappers
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Tue, 3 Dec 2013 17:27:11 +0000 (18:27 +0100)]
Remove unused res_to_status() function
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Tue, 3 Dec 2013 17:27:10 +0000 (18:27 +0100)]
Remove spinlock wrapping
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Tue, 3 Dec 2013 17:27:09 +0000 (18:27 +0100)]
Another round of malloc/free wrapper removal
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Tue, 3 Dec 2013 17:27:08 +0000 (18:27 +0100)]
Remove memcmp wrapper
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Tue, 3 Dec 2013 17:27:07 +0000 (18:27 +0100)]
Remove memset wrapper
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Tue, 3 Dec 2013 17:27:06 +0000 (18:27 +0100)]
Remove memcpy wrapper
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Tue, 3 Dec 2013 17:27:05 +0000 (18:27 +0100)]
Remove custom Android hacks
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Tue, 3 Dec 2013 17:27:04 +0000 (18:27 +0100)]
Remove atoi implementation and use sscanf instead
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Tue, 3 Dec 2013 17:27:03 +0000 (18:27 +0100)]
Remove malloc debug hacks
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Tue, 3 Dec 2013 17:27:02 +0000 (18:27 +0100)]
Remove various pieces of non Linux code
No need to carry around Windows/FreeBSD/random-embedded-arch code
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Tue, 3 Dec 2013 17:27:01 +0000 (18:27 +0100)]
Remove MP framework (Mass Production test code)
This code is not relevant for normal usage
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Mon, 2 Dec 2013 21:14:52 +0000 (22:14 +0100)]
run through dos2unix
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Mon, 2 Dec 2013 21:14:51 +0000 (22:14 +0100)]
Use kmalloc/kfree and check return value of kmalloc()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Mon, 2 Dec 2013 21:14:50 +0000 (22:14 +0100)]
Use kzalloc instead of rtw_kzmalloc
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Mon, 2 Dec 2013 21:14:49 +0000 (22:14 +0100)]
Replace rtw_mfree with kfree
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Mon, 2 Dec 2013 21:14:48 +0000 (22:14 +0100)]
Use kmalloc/kfree instead of wrapper macros
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Mon, 2 Dec 2013 21:14:46 +0000 (22:14 +0100)]
Replace malloc/free wrappers with proper kmalloc/kfree
In addition fix multiple memory leaks
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Mon, 2 Dec 2013 21:14:45 +0000 (22:14 +0100)]
Don't call _rtw_mfree() directly from outside osdep_service.c
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Mon, 2 Dec 2013 21:14:43 +0000 (22:14 +0100)]
Remove more non-Linux isms
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Mon, 2 Dec 2013 21:14:42 +0000 (22:14 +0100)]
Remove some more unnecessary platform code
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes Sorensen [Mon, 2 Dec 2013 21:14:41 +0000 (22:14 +0100)]
Remove unused malloc2d/free2d
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Larry Finger [Mon, 2 Dec 2013 20:23:00 +0000 (14:23 -0600)]
rtl8723au: Remove trailing white space from include/*.h
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Mon, 2 Dec 2013 20:22:08 +0000 (14:22 -0600)]
rtl8723au: Remove trailing white space from os_dep/*.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Mon, 2 Dec 2013 20:21:00 +0000 (14:21 -0600)]
rtl8723au: Remove trailing white space for hal/*.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Mon, 2 Dec 2013 20:19:55 +0000 (14:19 -0600)]
rtl8723au: Remove trailing white space from core/*.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Mon, 2 Dec 2013 20:18:33 +0000 (14:18 -0600)]
rtl8723au: Remove C99 comments from hal/HalDMOutSrc8192C_CE.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Mon, 2 Dec 2013 04:17:58 +0000 (22:17 -0600)]
rtl8723au: Remove C99 comments from hal/hal_com.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Mon, 2 Dec 2013 04:15:41 +0000 (22:15 -0600)]
rtl8723au: Remove C99 comments from hal/Hal8723UHWImg_CE.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Mon, 2 Dec 2013 03:47:29 +0000 (21:47 -0600)]
rtl8723au: Remove C99 comments from hal/Hal8723PwrSeq.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sun, 1 Dec 2013 06:00:28 +0000 (00:00 -0600)]
rtl8723au: Remove C99 comments from core/rtw_xmit.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sun, 1 Dec 2013 05:54:40 +0000 (23:54 -0600)]
rtl8723au: Remove C99 comments from core/rtw_wlan_util.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sun, 1 Dec 2013 04:32:05 +0000 (22:32 -0600)]
rtl8723au: Remove C99 comments from core/rtw_tdls.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sun, 1 Dec 2013 04:17:18 +0000 (22:17 -0600)]
rtl8723au: Remove C99 comments from core/rtw_sta_mgt.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sun, 1 Dec 2013 04:14:40 +0000 (22:14 -0600)]
rtl8723au: Remove C99 comments from core/rtw_sreset.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sun, 1 Dec 2013 04:12:26 +0000 (22:12 -0600)]
rtl8723au: Remove C99 comments from core/rtw_rf.c and core/rtw_security.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sun, 1 Dec 2013 04:06:23 +0000 (22:06 -0600)]
rtl8723au: Remove C99 comments from core/rtw_pwrctrl.c and core/rtw_recv.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sun, 1 Dec 2013 03:47:57 +0000 (21:47 -0600)]
rtl8723au: Remove C99 comments from core/rtw_p2p.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sun, 1 Dec 2013 03:45:04 +0000 (21:45 -0600)]
rtl8723au: Remove C99 comments from core/rtw_mp_ioctl.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sat, 30 Nov 2013 22:47:19 +0000 (16:47 -0600)]
rtl8723au: Remove C99 comments from core/rtw_mp.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sat, 30 Nov 2013 22:41:14 +0000 (16:41 -0600)]
rtl8723au: Remove C99 comments from core/rtw_mlme_ext.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sat, 30 Nov 2013 22:25:34 +0000 (16:25 -0600)]
rtl8723au: Remove C99 comments from core/rtw_mlme.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sat, 30 Nov 2013 22:16:29 +0000 (16:16 -0600)]
rtl8723au: Remove C99 comments from core/rtw_led.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sat, 30 Nov 2013 22:13:41 +0000 (16:13 -0600)]
rtl8723au: Remove C99 comments from core/rtw_iol.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sat, 30 Nov 2013 22:12:23 +0000 (16:12 -0600)]
rtl8723au: Remove C99 comments from core/rtw_ioctl_set.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sat, 30 Nov 2013 22:10:00 +0000 (16:10 -0600)]
rtl8723au: Remove C99 comments from core/rtw_ioctl_query.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sat, 30 Nov 2013 22:08:28 +0000 (16:08 -0600)]
rtl8723au: Remove C99 comments from core/rtw_io.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sat, 30 Nov 2013 22:05:22 +0000 (16:05 -0600)]
rtl8723au: Remove C99 comments from core/rtw_ieee80211.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sat, 30 Nov 2013 22:03:18 +0000 (16:03 -0600)]
rtl8723au: Remove C99 comments from core/rtw_efuse.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sat, 30 Nov 2013 22:01:28 +0000 (16:01 -0600)]
rtl8723au: Remove C99 comments from core/rtw_debug.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sat, 30 Nov 2013 20:28:13 +0000 (14:28 -0600)]
rtl8723au: Remove C99 comments from core/rtw_cmd.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sat, 30 Nov 2013 20:20:38 +0000 (14:20 -0600)]
rtl8723au: Remove C99 comments from core/rtw_bt_mp.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sat, 30 Nov 2013 20:16:19 +0000 (14:16 -0600)]
rtl8723au: Remove C99 cfomments from core/rtw_br_ext.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sat, 30 Nov 2013 20:12:45 +0000 (14:12 -0600)]
rtl8723au: Remove C99 comments fro core/rtw_ap.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Tue, 12 Nov 2013 22:08:17 +0000 (16:08 -0600)]
rtl8723au: Modify README.md
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
kfuchs [Sat, 9 Nov 2013 17:36:29 +0000 (12:36 -0500)]
Added simple install instructions to README.md
Larry Finger [Thu, 31 Oct 2013 17:52:46 +0000 (12:52 -0500)]
rtl8723au: Fix buffer overrun potential
In a struct definition, an array Data is defined with one element; however,
the code refers to Data[1]. The length has been increased.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Wed, 23 Oct 2013 03:18:33 +0000 (22:18 -0500)]
rtl8723au: Fix typo in DKMS parameter
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Fri, 18 Oct 2013 03:12:10 +0000 (22:12 -0500)]
rtl8723au: Set device type to wlan
From: Lennert Poettering
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
John Clemens [Mon, 14 Oct 2013 02:10:19 +0000 (22:10 -0400)]
DKMS support
Define CONFIG_RTL8723AS-VAU in the Makefile when KERNELRELEASE
is defined (as when compiling under DKMS). Add a dkms.conf file
and README.dkms with instructions on how to make it work.
Larry Finger [Mon, 7 Oct 2013 15:16:38 +0000 (10:16 -0500)]
rtl8723au: Fix skb leak in usb_read_port_complete()
In the completion routine for a usb_fill_bulk_urb() call, an skb is
leaked whenever the status of the USB transaction is not zero. A call
to skb_put() is needed to fix the problem.
This problem was found for the RTL8188EU driver. As that driver and this one share
this part of the code, I have applied the same patch here.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Thu, 12 Sep 2013 15:17:13 +0000 (10:17 -0500)]
rtl8723au: Fix smatch errors in core/rtw_mlme.c
Smatch reports the following:
CHECK /home/finger/rtl8723au/core/rtw_mlme.c
/home/finger/rtl8723au/core/rtw_mlme.c:2774:25: error: directive in argument list
/home/finger/rtl8723au/core/rtw_mlme.c:2776:25: error: directive in argument list
/home/finger/rtl8723au/core/rtw_mlme.c:2780:25: error: directive in argument list
/home/finger/rtl8723au/core/rtw_mlme.c:2782:25: error: directive in argument list
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Thu, 12 Sep 2013 15:11:19 +0000 (10:11 -0500)]
rtl8723au: Fix smatch warning in hal/rtl8723a_phycfg.c
Smatch reports the following:
CHECK /home/finger/rtl8723au/hal/rtl8723a_phycfg.c
/home/finger/rtl8723au/hal/rtl8723a_phycfg.c:2212 phy_TxPwrIdxToDbm() warn: missing break? reassigning 'Offset'
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Thu, 12 Sep 2013 15:09:13 +0000 (10:09 -0500)]
rtl8723au: Fix smatch errors in core/rtw_efuse.c
Smatch reports the following:
CHECK /home/finger/rtl8723au/core/rtw_efuse.c
/home/finger/rtl8723au/core/rtw_efuse.c:753 rtw_efuse_map_write() error: buffer overflow 'newdata' 8 <= 8
/home/finger/rtl8723au/core/rtw_efuse.c:763 rtw_efuse_map_write() error: buffer overflow 'newdata' 8 <= 8
/home/finger/rtl8723au/core/rtw_efuse.c:851 rtw_BT_efuse_map_write() error: buffer overflow 'newdata' 8 <= 8
/home/finger/rtl8723au/core/rtw_efuse.c:861 rtw_BT_efuse_map_write() error: buffer overflow 'newdata' 8 <= 8
All of these are off-by-one errors.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Thu, 12 Sep 2013 15:04:31 +0000 (10:04 -0500)]
rtl8723au: Fix smatch errors and warnings in core/rtw_mlme_ext.c
Smatch reports the following:
CHECK /home/finger/rtl8723au/core/rtw_mlme_ext.c
/home/finger/rtl8723au/core/rtw_mlme_ext.c:2053 OnAssocReq() debug: remove_pools: nr_children over 4000 (4200). (reassoc 0-1)
/home/finger/rtl8723au/core/rtw_mlme_ext.c:2053 OnAssocReq() error: buffer overflow 'pstapriv->sta_aid' 32 <= 32
/home/finger/rtl8723au/core/rtw_mlme_ext.c:5473 on_action_public_p2p() warn: if();
/home/finger/rtl8723au/core/rtw_mlme_ext.c:9690 process_80211d() error: testing array offset 'i' after use.
Of these, the last one appears to be a smatch error as I find nothing wrong.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Thu, 12 Sep 2013 03:12:41 +0000 (22:12 -0500)]
rtl8723au: Fix smatch errors in core/rtw_wlan_util.c
Smatch lists the following:
CHECK /home/finger/rtl8723au/core/rtw_wlan_util.c
/home/finger/rtl8723au/core/rtw_wlan_util.c:1646 rtw_check_bcn_info() info: ignoring unreachable code.
/home/finger/rtl8723au/core/rtw_wlan_util.c:1646 rtw_check_bcn_info() info: ignoring unreachable code.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Thu, 12 Sep 2013 03:06:17 +0000 (22:06 -0500)]
rtl8723au: Fix smatch errors in core/rtw_recv.c
Smatch lists the following:
CHECK /home/finger/rtl8723au/core/rtw_recv.c
/home/finger/rtl8723au/core/rtw_recv.c:2865 amsdu_to_msdu() warn: variable dereferenced before check 'sub_skb' (see line 2843)
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Thu, 12 Sep 2013 02:57:15 +0000 (21:57 -0500)]
rtl8723au: Fix smatch errors/warnings in core/rtw_xmit.c
Smatch lists the following:
CHECK /home/finger/rtl8723au/core/rtw_xmit.c
/home/finger/rtl8723au/core/rtw_xmit.c:2454 rtw_free_xmitframe() error: potentially dereferencing uninitialized 'queue'.
/home/finger/rtl8723au/core/rtw_xmit.c:2558 dequeue_one_xmitframe() info: ignoring unreachable code.
/home/finger/rtl8723au/core/rtw_xmit.c:2558 dequeue_one_xmitframe() info: ignoring unreachable code.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Thu, 12 Sep 2013 00:17:11 +0000 (19:17 -0500)]
rtl8723au: Fix smatch warnings in hal/usb_halinit.c
Smatch lists the following:
CHECK /home/finger/rtl8723au/hal/usb_halinit.c
/home/finger/rtl8723au/hal/usb_halinit.c:1402 HwSuspendModeEnable92Cu() info: ignoring unreachable code.
/home/finger/rtl8723au/hal/usb_halinit.c:1402 HwSuspendModeEnable92Cu() info: ignoring unreachable code.
/home/finger/rtl8723au/hal/usb_halinit.c:2931 _ReadIDs() warn: was || intended here instead of &&?
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Thu, 12 Sep 2013 02:31:53 +0000 (21:31 -0500)]
rtl8723au: Fix smatch errors in hal/rtl8723a_rf6052.c
Smatch lists the following:
CHECK /home/finger/rtl8723au/hal/rtl8723a_rf6052.c
/home/finger/rtl8723au/hal/rtl8723a_rf6052.c:973 PHY_RFShadowRefresh() error: buffer overflow 'RF_Shadow[eRFPath]' 63 <= 63
/home/finger/rtl8723au/hal/rtl8723a_rf6052.c:974 PHY_RFShadowRefresh() error: buffer overflow 'RF_Shadow[eRFPath]' 63 <= 63
/home/finger/rtl8723au/hal/rtl8723a_rf6052.c:975 PHY_RFShadowRefresh() error: buffer overflow 'RF_Shadow[eRFPath]' 63 <= 63
/home/finger/rtl8723au/hal/rtl8723a_rf6052.c:976 PHY_RFShadowRefresh() error: buffer overflow 'RF_Shadow[eRFPath]' 63 <= 63
/home/finger/rtl8723au/hal/rtl8723a_rf6052.c:977 PHY_RFShadowRefresh() error: buffer overflow 'RF_Shadow[eRFPath]' 63 <= 63
These are all due to an off-by-one error in a for loop.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Thu, 12 Sep 2013 00:14:20 +0000 (19:14 -0500)]
rtl8723au: Fix smatch problems in hal/usb_ops_linux.c
Smatch lists the following:
CHECK /home/finger/rtl8723au/hal/usb_ops_linux.c
/home/finger/rtl8723au/hal/usb_ops_linux.c:1723:1: warning: no newline at end of file
/home/finger/rtl8723au/hal/usb_ops_linux.c:1579 usb_read_port() warn: variable dereferenced before check 'precvbuf' (see line 1573)
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Thu, 12 Sep 2013 00:08:08 +0000 (19:08 -0500)]
rtl8723au: Fix smatch problems in hal/rtl8723a_mp.c
Smatch lists the following:
CHECK /home/finger/rtl8723au/hal/rtl8723a_mp.c
/home/finger/rtl8723au/hal/rtl8723a_mp.c:538 Hal_SetAntennaPathPower() error: buffer overflow 'TxPowerLevel' 2 <= 2
/home/finger/rtl8723au/hal/rtl8723a_mp.c:581 Hal_SetTxPower() error: buffer overflow 'TxPowerLevel' 2 <= 2
/home/finger/rtl8723au/hal/rtl8723a_mp.c:599 Hal_SetTxAGCOffset() info: ignoring unreachable code.
/home/finger/rtl8723au/hal/rtl8723a_mp.c:599 Hal_SetTxAGCOffset() info: ignoring unreachable code.
The buffer overflow errors are again an off-by=one situation.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Wed, 11 Sep 2013 23:58:46 +0000 (18:58 -0500)]
rtl8723au: Fix smatch warnings in CHECK /home/finger/rtl8723au/hal/odm_HWConfig.c
Smatch lists the following:
/home/finger/rtl8723au/hal/odm_HWConfig.c:400 odm_RxPhyStatus92CSeries_Parsing() warn: always true condition '(pPktinfo->Rate >= 0) => (0-255 >= 0)'
/home/finger/rtl8723au/hal/odm_HWConfig.c:783 odm_Process_RSSIForDM() warn: always true condition '(pPktinfo->Rate >= 0) => (0-255 >= 0)'
Variable Rate is unsigned and always >= 0.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Wed, 11 Sep 2013 23:50:13 +0000 (18:50 -0500)]
rtl8723au: Fix smatch errors/warnings for hal/HalDMOutSrc8192C_CE.c
Smatch shows the following:
CHECK /home/finger/rtl8723au/hal/HalDMOutSrc8192C_CE.c
/home/finger/rtl8723au/hal/HalDMOutSrc8192C_CE.c:313 odm_TXPowerTrackingCallback_ThermalMeter_92C() error: buffer overflow 'TxPwrLevel' 2 <= 2
/home/finger/rtl8723au/hal/HalDMOutSrc8192C_CE.c:313 odm_TXPowerTrackingCallback_ThermalMeter_92C() error: buffer overflow 'TxPwrLevel' 2 <= 2
/home/finger/rtl8723au/hal/HalDMOutSrc8192C_CE.c:327 odm_TXPowerTrackingCallback_ThermalMeter_92C() error: buffer overflow 'TxPwrLevel' 2 <= 2
/home/finger/rtl8723au/hal/HalDMOutSrc8192C_CE.c:327 odm_TXPowerTrackingCallback_ThermalMeter_92C() error: buffer overflow 'TxPwrLevel' 2 <= 2
/home/finger/rtl8723au/hal/HalDMOutSrc8192C_CE.c:334 odm_TXPowerTrackingCallback_ThermalMeter_92C() error: buffer overflow 'TxPwrLevel' 2 <= 2
/home/finger/rtl8723au/hal/HalDMOutSrc8192C_CE.c:334 odm_TXPowerTrackingCallback_ThermalMeter_92C() error: buffer overflow 'TxPwrLevel' 2 <= 2
/home/finger/rtl8723au/hal/HalDMOutSrc8192C_CE.c:2014 rtl8192c_PHY_APCalibrate() info: ignoring unreachable code.
/home/finger/rtl8723au/hal/HalDMOutSrc8192C_CE.c:2014 rtl8192c_PHY_APCalibrate() info: ignoring unreachable code.
The buffer overflow errors are due to an off-by-one error.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Wed, 11 Sep 2013 23:35:49 +0000 (18:35 -0500)]
rtl8723au: Fix smatch errors/warnings in hal/rtl8723a_bt-coexist.c
Smatch shows the following:
CHECK /home/finger/rtl8723au/hal/rtl8723a_bt-coexist.c
/home/finger/rtl8723au/hal/rtl8723a_bt-coexist.c:612 bthci_GetAssocInfo() warn: should this be a bitwise op?
/home/finger/rtl8723au/hal/rtl8723a_bt-coexist.c:743 bthci_CheckLogLinkBehavior() warn: should this be a bitwise op?
/home/finger/rtl8723au/hal/rtl8723a_bt-coexist.c:4065 bthci_CmdLogicalLinkCancel() error: buffer overflow 'pBTinfo->BtAsocEntry[CurrentEntryNum]->LogLinkCmdData' 2 <= 255
/home/finger/rtl8723au/hal/rtl8723a_bt-coexist.c:4066 bthci_CmdLogicalLinkCancel() error: buffer overflow 'pBTinfo->BtAsocEntry[CurrentEntryNum]->LogLinkCmdData' 2 <= 255
/home/finger/rtl8723au/hal/rtl8723a_bt-coexist.c:4073 bthci_CmdLogicalLinkCancel() error: buffer overflow 'pBTinfo->BtAsocEntry[CurrentEntryNum]->LogLinkCmdData' 2 <= 255
/home/finger/rtl8723au/hal/rtl8723a_bt-coexist.c:6463 BTHCI_EventParse() info: ignoring unreachable code.
/home/finger/rtl8723au/hal/rtl8723a_bt-coexist.c:6463 BTHCI_EventParse() info: ignoring unreachable code.
/home/finger/rtl8723au/hal/rtl8723a_bt-coexist.c:8528 BTDM_1AntLpsLeave() warn: statement has no effect 22
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Wed, 11 Sep 2013 23:16:43 +0000 (18:16 -0500)]
rtl8723au: Fix smatch warning in os_dep/usb_intf.c
Smatch lists the following:
CHECK /home/finger/rtl8723au/os_dep/usb_intf.c
/home/finger/rtl8723au/os_dep/usb_intf.c:1005 rtw_resume_process() error: potentially dereferencing uninitialized 'pwrpriv'.
The fix is to add the necessary test.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Wed, 11 Sep 2013 23:02:41 +0000 (18:02 -0500)]
rtl8723au: Fix smatch errors/warnings in core/rtw_ioctl_set.c
Smatch lists the following:
CHECK /home/finger/rtl8723au/core/rtw_ioctl_set.c
/home/finger/rtl8723au/core/rtw_ioctl_set.c:822 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8723au/core/rtw_ioctl_set.c:824 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKeylen' 4 <= 4
/home/finger/rtl8723au/core/rtw_ioctl_set.c:828 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8723au/core/rtw_ioctl_set.c:828 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8723au/core/rtw_ioctl_set.c:828 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8723au/core/rtw_ioctl_set.c:828 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8723au/core/rtw_ioctl_set.c:828 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8723au/core/rtw_ioctl_set.c:828 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8723au/core/rtw_ioctl_set.c:828 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8723au/core/rtw_ioctl_set.c:828 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8723au/core/rtw_ioctl_set.c:828 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8723au/core/rtw_ioctl_set.c:828 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8723au/core/rtw_ioctl_set.c:828 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8723au/core/rtw_ioctl_set.c:828 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8723au/core/rtw_ioctl_set.c:828 rtw_set_802_11_add_wep() error: buffer overflow 'psecuritypriv->dot11DefKey' 4 <= 4
/home/finger/rtl8723au/core/rtw_ioctl_set.c:976 rtw_set_802_11_add_key() warn: was && intended here instead of ||?
The last of these is a logical error. The others are due to an off-by-one error.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Wed, 11 Sep 2013 22:59:00 +0000 (17:59 -0500)]
rtl8723au: Fix smatch warning in core/rtw_debug.c
Smatch lists the following:
CHECK /home/finger/rtl8723au/core/rtw_debug.c
/home/finger/rtl8723au/core/rtw_debug.c:688 proc_set_rx_signal() warn: unsigned 'signal_strength' is never less than zero.
The offending statement is testing an unsigned variable.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Wed, 11 Sep 2013 22:56:41 +0000 (17:56 -0500)]
rtl8723au: Fix smatch warnings in core/rtw_security.c
Smatch lists the following:
CHECK /home/finger/rtl8723au/core/rtw_security.c
/home/finger/rtl8723au/core/rtw_security.c:2486 rijndaelKeySetupEnc() warn: '4' 4 can't fit into
4611686018427387903 'rk'
/home/finger/rtl8723au/core/rtw_security.c:2533 rijndaelEncrypt() warn: '8' 8 can't fit into
4611686018427387903 'rk'
These are both smatch errors, not problems with the code.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Wed, 11 Sep 2013 22:53:25 +0000 (17:53 -0500)]
rtl8723au: Fis smatch errors in core/rtw_cmd.c
Smatch lists the following:
CHECK /home/finger/rtl8723au/core/rtw_cmd.c
/home/finger/rtl8723au/core/rtw_cmd.c:500 rtw_cmd_thread() error: buffer overflow 'wlancmds' 63 <= 63
/home/finger/rtl8723au/core/rtw_cmd.c:522 rtw_cmd_thread() error: buffer overflow 'rtw_cmd_callback' 63 <= 63
Both of these are off-by-one errors that could lead to trying to
access memory outside the boundaries of the array specified.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Wed, 11 Sep 2013 22:46:22 +0000 (17:46 -0500)]
rtl8723au: Fix smatch warning in core/rtw_ieee80211.c
Smatch lists the following:
CHECK /home/finger/rtl8723au/core/rtw_ieee80211.c
/home/finger/rtl8723au/core/rtw_ieee80211.c:167 rtw_set_ie() info: ignoring unreachable code.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Wed, 11 Sep 2013 22:43:50 +0000 (17:43 -0500)]
rtl8723au: Fix smatch errors/warnings in os_dep/osdep_service.c
Smatch lists the following:
CHECK /home/finger/rtl8723au/os_dep/osdep_service.c
/home/finger/rtl8723au/os_dep/osdep_service.c:1275:19: warning: non-ANSI function declaration of function 'rtw_yield_os'
/home/finger/rtl8723au/os_dep/osdep_service.c:1298:35: warning: non-ANSI function declaration of function 'rtw_suspend_lock_init'
/home/finger/rtl8723au/os_dep/osdep_service.c:1307:37: warning: non-ANSI function declaration of function 'rtw_suspend_lock_uninit'
/home/finger/rtl8723au/os_dep/osdep_service.c:1316:30: warning: non-ANSI function declaration of function 'rtw_lock_suspend'
/home/finger/rtl8723au/os_dep/osdep_service.c:1329:32: warning: non-ANSI function declaration of function 'rtw_unlock_suspend'
/home/finger/rtl8723au/os_dep/osdep_service.c:1775 rtw_change_ifname() warn: variable dereferenced before check 'padapter' (see line 1771)
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Wed, 11 Sep 2013 22:36:41 +0000 (17:36 -0500)]
rtl8723au: Fix smatch errors and warnings in os_dep/ioctl_linux.c
Smatch lists the following:
CHECK /home/finger/rtl8723au/os_dep/ioctl_linux.c
/home/finger/rtl8723au/os_dep/ioctl_linux.c:1632 rtw_wx_get_range() warn: assigning (-78) to unsigned variable 'range->avg_qual.level'
/home/finger/rtl8723au/os_dep/ioctl_linux.c:5122 rtw_p2p_get_invitation_procedure() warn: should this be a bitwise op?
/home/finger/rtl8723au/os_dep/ioctl_linux.c:6320 rtw_p2p_get2() warn: statement has no effect 5
/home/finger/rtl8723au/os_dep/ioctl_linux.c:6603 rtw_dbg_port() warn: unsigned 'extra_arg' is never less than zero.
/home/finger/rtl8723au/os_dep/ioctl_linux.c:7493 set_group_key() warn: missing break? reassigning 'keylen'
/home/finger/rtl8723au/os_dep/ioctl_linux.c:9936:24: error: bad constant expression
/home/finger/rtl8723au/os_dep/ioctl_linux.c:10115:24: error: bad constant expression
/home/finger/rtl8723au/os_dep/ioctl_linux.c:10233:35: error: bad constant expression
/home/finger/rtl8723au/os_dep/ioctl_linux.c:10265:35: error: bad constant expression
/home/finger/rtl8723au/os_dep/ioctl_linux.c:10314:35: error: bad constant expression
/home/finger/rtl8723au/os_dep/ioctl_linux.c:10340:35: error: bad constant expression
/home/finger/rtl8723au/os_dep/ioctl_linux.c:10380:35: error: bad constant expression
/home/finger/rtl8723au/os_dep/ioctl_linux.c:10565:28: error: bad constant expression
/home/finger/rtl8723au/os_dep/ioctl_linux.c:10612:35: error: bad constant expression
/home/finger/rtl8723au/os_dep/ioctl_linux.c:10731:35: error: bad constant expression
/home/finger/rtl8723au/os_dep/ioctl_linux.c:10929:27: error: bad constant expression
/home/finger/rtl8723au/os_dep/ioctl_linux.c:10953:33: error: bad constant expression
/home/finger/rtl8723au/os_dep/ioctl_linux.c:10982:33: error: bad constant expression
/home/finger/rtl8723au/os_dep/ioctl_linux.c:11023:35: error: bad constant expression
Several of these are real errors in the code.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Mon, 9 Sep 2013 03:56:37 +0000 (22:56 -0500)]
rtl8723ae: Fix some sparse warnings
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sun, 8 Sep 2013 00:45:19 +0000 (19:45 -0500)]
rtl8723au: Remove byte order header
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sun, 8 Sep 2013 00:16:50 +0000 (19:16 -0500)]
rtl8723au: Increase maximum RX gain
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Mon, 2 Sep 2013 14:38:38 +0000 (09:38 -0500)]
rtl8723au: Fix sparse warnings in core/rtw_mp.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Mon, 2 Sep 2013 14:29:28 +0000 (09:29 -0500)]
rtl8723au: Fix sparse warnings in core/rtw_debug.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Mon, 2 Sep 2013 14:08:58 +0000 (09:08 -0500)]
rtl8723au: Remove trailing white space in header files
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sun, 1 Sep 2013 15:22:48 +0000 (10:22 -0500)]
rtl8723au: Fix sparse warnings in core/rtw_mp_ioctl.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sun, 1 Sep 2013 14:26:37 +0000 (09:26 -0500)]
rtl8712au: Fix sparse warnings in core/rtw_pwrctrl.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sun, 1 Sep 2013 14:24:02 +0000 (09:24 -0500)]
rtl8723au: Fix smatch warnings in os_dep/recv_linux.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Sun, 1 Sep 2013 14:17:47 +0000 (09:17 -0500)]
rtl8723au: Fix sparse errors in core/rtw_bt_mp.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger [Fri, 16 Aug 2013 14:32:55 +0000 (09:32 -0500)]
rtl8723au: Eliminate header file
File include/rtw_byteorder.h is not needed.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
OSDN Git Service
