OSDN Git Service

Fix mipmap generation on undefined cube texture
authorNicolas Capens <capn@google.com>
Mon, 18 Mar 2019 16:42:22 +0000 (12:42 -0400)
committerNicolas Capens <nicolascapens@google.com>
Tue, 19 Mar 2019 13:41:47 +0000 (13:41 +0000)
commit24cb99d44e9c508dde5a5b4ea0c5015fc8697f94
tree8fb874fe1a129de94e373c30ab3cb0ec75af6cc2
parentb8c63935328fde3a5acf68225f3ed5c890396d02
Fix mipmap generation on undefined cube texture

Cube textures must be cube complete to generate mipmaps, but when the
base level is undefined the glGenerateMipmap command must be silently
ignored. This was previously leading to a null dereference.

Bug chromium:924022
Bug https://gitlab.khronos.org/opengl/API/issues/72

Change-Id: I5d6e8533118e554efa12045fc376126c7b00f263
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27491
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
src/OpenGL/libGLESv2/Context.cpp
src/OpenGL/libGLESv2/Context.h
src/OpenGL/libGLESv2/Texture.cpp
src/OpenGL/libGLESv2/Texture.h
src/OpenGL/libGLESv2/libGLESv2.cpp