OSDN Git Service
Hugo Benichi [Thu, 6 Apr 2017 07:01:44 +0000 (16:01 +0900)]
ConnectivityService: safer locking
This path changes a dangerous lock path in reportNetworkConnectivity().
This methods is called outside of the main ConnectivityService handler
and takes a lock on a specific NetworkAgentInfo whose connectivity
status is being reported.
While this lock is held, reportNetworkConnectivity() goes on and query
the network policy state for that network, which may ends into
NetworkPolicyManagerService.
Instead, the lock on NetworkAgentInfo is only held long enough to make a
copy of LinkProperties, which is then passed to
NetworkPolicyManagerService without that lock.
Bug:
36902662
Test: could not repro b/
36902662, reportNetworkConnectivity() works.
$ runtest frameworks-net
Change-Id: Iac4b75bcecbdddb0ac695c8b1a87ae755f62f47f
Gabriele M [Wed, 6 Jun 2018 13:28:46 +0000 (15:28 +0200)]
Revert "Prevent deadlock when using always-on legacy VPNs"
A different fix will be applied with follow-up changes. This also
doesn't appear to completely fix the problem (REGRESSION-1963).
This reverts commit
ac496f4a070a5b050217335f512e0bb44cd90f32.
Change-Id: Ie77e2d4c58ce8c6be68f125d3311ecced6e1e7ca
dongwan0605.kim [Mon, 16 Jan 2017 07:54:50 +0000 (16:54 +0900)]
Fix gear not showing when rotation or RTL changed
When rotation or RTL changed, gear button's translationX should be
updated to new position.
Test: (Rotation) Swipe notification to left > Gear is showing on the
right > Rotate the device > Gear button should be visible
Test: (RTL) Swipe notification to left > Set RTL language
> Swipe notification to right in RTL configuration
> Gear button should be visible
Change-Id: I04a657d380b746b30585ff8159b7a9b4865f423a
Sam Mortimer [Mon, 21 May 2018 08:32:03 +0000 (10:32 +0200)]
SystemUI: Network Traffic [1/3]
*) Backport to cm-14.1
*) Add cmsdk internal NetworkTraffic to the statusbar
using the CMStatusBarItemHolder helper.
Change-Id: Iba82b622099a415da5fe6d4ae923e3139b6dca52
Sam Mortimer [Mon, 21 May 2018 08:30:07 +0000 (10:30 +0200)]
SystemUI: Add CM statusbar item holder
*) Backport to cm-14.1
*) To be used as a layout to hold one or more cmsdk status bar
feature classes.
*) Propagates visibility and tint information via interfaces
defined in cmsdk internal.
*) Supports adding further interfaces without impacting existing use
cases.
Change-Id: I3b98837e076ba1cb0d4ca6e7588c1e917f81e65a
Rebecca Silberstein [Thu, 23 Mar 2017 07:29:28 +0000 (00:29 -0700)]
Add NETWORK_STACK permission
Add a new permission that only allows other system services to call
networking related methods. This permission is intended to prevent
other apps from calling these methods that might leave networking
services in intermediate states.
Bug:
36538042
Test: build, run wifi unit tests, boots, wifi connects
Change-Id: Icba6ad5280e9a8863bd1c706ca34b7add8de5294
Eugene Susla [Thu, 22 Feb 2018 18:39:34 +0000 (10:39 -0800)]
Copy PermissionChecker from support lib and use in RcognitionService
Fixes:
73511076,
73311729
Test: presubmit
Change-Id: Ie98f67ffee4744050ac85d8b229370a16a76a194
(cherry picked from commit
726b51a26e9a54b7352aad90ed15edccc44dd60d)
(cherry picked from commit
5a28e533fe8865ed371b5c0fd909a4ec89f63633)
CVE-2017-13316
Pengquan Meng [Fri, 9 Mar 2018 04:08:25 +0000 (20:08 -0800)]
Fixed Security Vulnerability of DcParamObject
The writeToParcel and readFromParcel is not symmetry, fixed it.
Test: no test
Bug:
70721937
Change-Id: I01f6f6b2ab778ee8b638d9b69fe0a6b9aa7ee395
(cherry picked from commit
8c55a70728fdb0a7b0585fac08629b0137dca51e)
CVE-2017-13315
Rubin Xu [Thu, 11 Jan 2018 10:59:19 +0000 (10:59 +0000)]
Add permission check to setAllowOnlyVpnForUids
Bug:
63000005
Test: runtest frameworks-net -c com.android.server.connectivity.VpnTest
Test: cts-tradefed run cts-dev -m CtsDevicePolicyManagerTestCases -t com.android.cts.devicepolicy.MixedDeviceOwnerTest#testAlwaysOnVpnLockDown
Merged-In: Ia1a82ee73d8617f3124032986fe6c09c14bf7752
Change-Id: Ia1a82ee73d8617f3124032986fe6c09c14bf7752
(cherry picked from commit
f915e04d5010c4dfffad263fa70c1e412e856314)
CVE-2017-13314
Fyodor Kupolov [Wed, 21 Feb 2018 01:02:35 +0000 (17:02 -0800)]
Verify last array's length in readFromParcel
Length of the last array in readFromParcel should be the same as
value of mNextIndex.
Test: PoC app in the bug
Bug:
73252178
Change-Id: I69f935949e945c3a036b19b4f88684d906079ea5
(cherry picked from commit
3b8bc2e45048527d7682b24b96957c34433da382)
CVE-2017-13311
Alan Viverette [Fri, 16 Feb 2018 18:56:02 +0000 (13:56 -0500)]
Update internal ViewPager's SavedState to match Support Library version
Merged-In: Ic4569b21d8a26a62bba91742b442f0c3ea8bcc9e
Change-Id: I17d085be9ce1a139e75264f1e715df7f565cd41b
Fixes:
71992105
Test: manual
(cherry picked from commit
187964aca12115c7ab66f59d1ebb95e4f4130ac6)
CVE-2017-13310
Fyodor Kupolov [Thu, 12 Oct 2017 18:22:57 +0000 (11:22 -0700)]
Use calling user ID when calling isDeviceLocked
If isDeviceLocked is called with clearCallingIdentity,
original userId should be explicitly passed
Bug:
67621847
Test: Manual
Change-Id: I2bcb92572898811cc96bda1149ef806e6239e929
Michael Bestas [Sat, 5 May 2018 16:19:40 +0000 (19:19 +0300)]
Automatic translation import
Change-Id: I6ca8357face163515c2d59778a9a350fedc0501a
Michael W [Sun, 22 Apr 2018 14:08:50 +0000 (16:08 +0200)]
GlobalActions: Don't timeout a partial screenshot
* A partial screenshot shouldn't timeout when the user might still be
adjusting the rectangle
* This also fixes an issue, when views were removed from WindowManager
multiple times, resulting in a crash
BUGBASH-1500
Change-Id: I5916545e9293717a96ecf191c9fb20db536cc730
Michael Bestas [Thu, 19 Apr 2018 19:45:05 +0000 (22:45 +0300)]
Automatic translation import
Change-Id: Ie3feee7796d76c1eafd62e9807ef90105c5d31d5
Adam Vartanian [Wed, 31 Jan 2018 11:05:10 +0000 (11:05 +0000)]
Adjust URI host parsing to stop on \ character.
The WHATWG URL parsing algorithm [1] used by browsers says that for
"special" URL schemes (which is basically all commonly-used
hierarchical schemes, including http, https, ftp, and file), the host
portion ends if a \ character is seen, whereas this class previously
continued to consider characters part of the hostname. This meant
that a malicious URL could be seen as having a "safe" host when viewed
by an app but navigate to a different host when passed to a browser.
[1] https://url.spec.whatwg.org/#host-state
Bug:
71360761
Test: vogar frameworks/base/core/tests/coretests/src/android/net/UriTest.java (on NYC branch)
Test: cts -m CtsNetTestCases (on NYC branch)
Change-Id: Id53f7054d1be8d59bbcc7e219159e59a2425106e
(cherry picked from commit
fa3afbd0e7a9a0d8fc8c55ceefdb4ddf9d0115af)
(cherry picked from commit
0b57631939f5824afef06517df723d2e766e0159)
Adam Lesinski [Fri, 10 Nov 2017 01:12:17 +0000 (17:12 -0800)]
Check for null-terminator in ResStringPool::string8At
All other stringAt methods check for null termination. Be consistent
so that upper levels don't end up with huge corrupt strings.
Bug:
62537081
Test: none
Change-Id: I17bdfb0c1e34507b66c6cad651bbdb12c5d4c417
(cherry picked from commit
3d35a0ea307693a97583a61973e729a5e7db2687)
(cherry picked from commit
97f8cb01149b35b1832c7f9efe85ff19edf1083e)
(cherry picked from commit
5ec65ae909a85d13d03c030be357c8c14a50d306)
(cherry picked from commit
a2a36541f0b3603335e74da0a8d2b6a9d5bcec3f)
Etan Cohen [Fri, 2 Feb 2018 16:07:20 +0000 (08:07 -0800)]
[RTT] ParcelableRttResults parcel code fix
ParcelableRttResults was unparceled incorrectly.
Bug:
70398564
Test: exploit provided in bug no longer works
Change-Id: Ifd6de547e9861bbebc399b43d0cc2899a8160813
(cherry picked from commit
e1e5a2409c8bef2481e68d9329f87bb8037afa45)
(cherry picked from commit
5a3d2708cd2289a4882927c0e2cb0d3c21a99c02)
Rubin Xu [Wed, 7 Feb 2018 08:10:08 +0000 (08:10 +0000)]
Fix VerifyCredentialResponse parcelling code
There was an asymmetry between parcelling and unparcelling of
VerifyCredentialResponse that could lead to type confusion if
packed with other objects in a Parcel.
Test: none
Bug:
71714464
Change-Id: Icff68879e249422ccca49f2bb7db85c35b4cb353
(cherry picked from commit
54813e988884f0d604d5358569f10feda8622f46)
(cherry picked from commit
09ba8fdffd9c8d74fdc6bfb51bcebc27fc43884a)
Michael Bestas [Tue, 27 Mar 2018 22:46:37 +0000 (01:46 +0300)]
Automatic translation import
Change-Id: I6cef227b477e9973eed48ed4345bbbc684f48f74
Michael Bestas [Fri, 2 Mar 2018 23:25:43 +0000 (01:25 +0200)]
SettingsProvider: Remove deprecated def_force_disable_navkeys default
* It's been moved to cmsdk
Change-Id: I281f056a0c58998e639de69b9658f89eb5bc1046
Gabriele M [Mon, 27 Nov 2017 17:59:25 +0000 (18:59 +0100)]
Update tint of resource icons of third party QS tiles
Since commit
d2274f848c586d86404ae14dfb8d11a02ee4867a
("Fix animations for app QS tiles."), the tint of resource icons of
third party tiles doesn't change when the tile status changes. Keep
track of the tint so that changing the status of the icon will cause
an update of the icon.
BUGBASH-1239
Change-Id: Ib2a91a00b6912ae85f37dd096e62bb6b979e9fc7
Michael W [Sat, 17 Feb 2018 13:33:30 +0000 (14:33 +0100)]
Automatic translation import
Change-Id: I2d1c1294839b5a3ca059db6fc9241603f65d5ad4
Michael Bestas [Sun, 4 Feb 2018 02:31:47 +0000 (04:31 +0200)]
Automatic translation import
Change-Id: If98400e859be0cf1b18dc159c74ef3eaf3480553
qjohn [Fri, 14 Jul 2017 08:37:47 +0000 (15:37 +0700)]
SystemUI: Fix LiveDisplay tile off color
* Should match other icons when disabled.
Change-Id: Ic745d71b0eef0fca68a63e9558a43c203334e819
Unpublished [Fri, 29 Dec 2017 22:00:01 +0000 (23:00 +0100)]
livedisplay: Allow tile creation before boot completed phase [2/2]
Change-Id: Ibef44d4e07da9baf296796515288c9d42aba8608
meganukebmp [Sat, 20 Jan 2018 01:11:11 +0000 (03:11 +0200)]
SystemUI: Fix crash when taking screenshot in partial screenshot view
Bug caused by the region selector and the animation using the same view.
This fix makes a dedicated view for the selector.
Change-Id: I12532ece4b3a742cba8f5c3852813fa339a04341
Michael Bestas [Mon, 15 Jan 2018 00:12:10 +0000 (02:12 +0200)]
GlobalActions: Misc power menu cleanup
* Update drawable size to match AOSP icons
* Update airplane mode drawables
* Remove unused changes to modes we don't use
* Remove dead code
* Cleanup based on lineage-15.1 bringup comments
Change-Id: I59b7246857acd34d18baaedc286a66820560fa49
Italian Quadcore [Tue, 9 Jun 2015 08:48:25 +0000 (10:48 +0200)]
GlobalActions: Fix setting ringer mode in global actions
* It looks like we missed some fixes while forward porting
this feature from cm-13.0. Squash the following commits:
Author: Italian Quadcore <myawfulchat@gmail.com>
Date: Tue Jun 9 10:48:25 2015 +0200
Add Sound Panel to Power Menu (Part 1/2)
Change-Id: I5a638b1817b3de82d891935e0071c6e42856c59e
Author: d34d <clark@cyngn.com>
Date: Mon Feb 1 14:19:01 2016 -0800
GlobalActions: Fix setting ringer mode in global actions
It looks like we did not bring in this full feature for cm-13.0.
This patch updates SilentModeTriStateAction to match cm-12.1 with
one minor change. We can no longer set the zen mode by writing to
Global settings directly. The ZenModeHelper class actually checks
when a change is made and resets it. The fix is to use
INotificationManager.setZenMode() instead.
Change-Id: Ib2423a19da3a2ca95f73cb92247e0a38bff8bbee
TICKET: CYNGNOS-1808
Author: Dave Kover <kover@cyngn.com>
Date: Tue Mar 1 13:37:57 2016 -0800
Fix GlobalActions sound panel iconography.
The priority and none icons were using old zen icons and did not
match up with the status bar iconography. We are now in sync. Also
aligning the prefix to match the other icons present in this dialog.
Lastly, creating new drawables for the two sound options so that
we don't clash designs with the Settings view, which also used the
same icons.
Change-Id: I0a0cee6c7f0f7b014a0b2cdd95b7f7e5cb8e5f38
Ticket: CYNGNOS-2172
Author: d34d <clark@cyngn.com>
Date: Tue Apr 12 10:13:22 2016 -0700
GlobalActions: Always use setZenMode
When set to silent mode, the user cannot change the ringer mode to
vibrate or ring. Notification manager listens for changes to the
zen mode setting and will switch it back if there is a mismatch.
Using INotificationManager.setZenMode takes care of changing the mode
and keeping track of the updated change.
Change-Id: I5139a9a8cde4ca59f64bd21cf7c184d4745a7d59
TICKET: CYNGNOS-2417 BACON-4658
Change-Id: I5a638b1817b3de82d891935e0071c6e42856c59e
Tom Marshall [Tue, 28 Jun 2016 16:43:10 +0000 (09:43 -0700)]
fw: GlobalActions: Always dismiss any existing dialog
The check for "mUiContext == null" is always false after the initial
dialog is created, causing the dismiss logic to never trigger. All
code uses getUiContext() now, so the check is not necessary. Remove
it and re-align the create/dismiss logic with AOSP.
Jira: BACON-4069
Change-Id: Ibba7b38a5fdc8410824db6d0a6f726f4a2822c9d
longyu.huang [Thu, 9 Apr 2015 07:09:43 +0000 (00:09 -0700)]
The DUT can't screen shot in guest mode
Change-Id: I6c40f8b5399ed1a8f9d52ddf0ed28266eea8f48c
Gabriele M [Wed, 10 Jan 2018 10:57:51 +0000 (11:57 +0100)]
Keyguard: Don't apply input restriction if disabled by profile
setKeyguardEnabled() applies some input restrictions when disabling
the lockscreen. This causes issues when a system profile disables the
lockscreen via this method, e.g. the home button stops working until
a profile re-enables the lockscreen with setKeyguardEnabled(). If the
current profile is disabling keyguard, don't restrict the inputs.
BUGBASH-504
Change-Id: Iaaaabecaf19a18911d276a47f826dec3dec045c1
Paul Keith [Tue, 16 Jan 2018 14:47:07 +0000 (15:47 +0100)]
PhoneWindowManager: Make sure KeyDisabler is always called on boot
* Otherwise, some KeyDisabler classes are left in a weird state
* Because we don't keep track of whether an initial state was ever set,
we never call KeyDisabler on boot if the setting is set to 0
* To remedy this, keep track of whether an initial state was set
Change-Id: Ib432ed3278dd8f4f4cba3ba488879b3c1cd9c8f4
Beverly [Fri, 1 Sep 2017 18:56:50 +0000 (14:56 -0400)]
DO NOT MERGE Backporting potential usb tapjacking precaution.
Bug:
62187985
Test: manual, backport
Change-Id: Iaceff6bb1da5fbf3d80a8e85923199bd8cab06bd
MERGED-IN: I3bdcd1876cd6dbe8a728bbce74edb52ab79f3e4c
MERGED-IN: Ic58ddd6d54e96f522445e67b90760dcfed13c27d
Chong Zhang [Tue, 24 Oct 2017 23:07:18 +0000 (16:07 -0700)]
mtp: fix double free of thumbnail data
bug:
67864232
Change-Id: I6eb51be839df12317273830521c70a4ed80f9496
(cherry picked from commit
e6b98532ee03d0ac1ca93382699893172454a946)
Leon Scroggins III [Tue, 3 Oct 2017 18:00:20 +0000 (14:00 -0400)]
Throw OOME if Bitmap.nativeCreate fails
Bug:
33846679
Test: I6ab6cb7a3b3151641a9f9b02b0bfc484e0a4524b
This matches the old behavior, prior to switching from Java allocated
pixel memory to native allocations (b/
27762775). It also better matches
what has happened - we ran out of memory. (Better than the current
behavior - NullPointerException in the Java code, or an alternative
solution of returning null, which would likely result in NPEs in the
calling code.)
Merged-In: I3958ed1106ac94fb1d3f30e044b620d984875211
Change-Id: I3958ed1106ac94fb1d3f30e044b620d984875211
(cherry picked from commit
5906a4869cdf5c39eba1d9a3125aff894c5e804d)
Adam Vartanian [Tue, 7 Nov 2017 12:22:23 +0000 (12:22 +0000)]
Adjust Uri host parsing to use last instead of first @.
Malformed authority segments can currently cause the parser to produce
a hostname that doesn't match the hostname produced by the WHATWG URL
parsing algorithm* used by browsers, which means that a URL could be seen
as having a "safe" host when checked by an Android app but actually visit
a different host when passed to a browser. The WHATWG URL parsing
algorithm always produces a hostname based on the last @ in the authority
segment, so we do the same.
* https://url.spec.whatwg.org/#authority-state resets the "buffer", which
is being used to build up the host name, each time an @ is found, so it
has the effect of using the content between the final @ and the end
of the authority section as the hostname.
Bug:
68341964
Test: vogar android.net.UriTest (on NYC branch)
Test: cts -m CtsNetTestCases (on NYC branch)
Change-Id: Idca79f35a886de042c94d6ab66787c2e98ac8376
(cherry picked from commit
cd6228dd377b2a0caa02a1e6df92f3d9ae702a95)
Alexander [Fri, 5 Jan 2018 10:51:29 +0000 (13:51 +0300)]
SysUI: Add Russian translation for accessibility_battery_level_charging
Change-Id: I6594d67c572c90e44b01335bf2a0785f47bc4ecf
Michael W [Sat, 13 Jan 2018 15:16:12 +0000 (16:16 +0100)]
Automatic translation import
Change-Id: I91439c40d8349ae2a50a2ec7c6d55d541097555a
Miroslav Sustek [Tue, 19 Dec 2017 16:16:40 +0000 (17:16 +0100)]
SystemUI: fix enabling burnIn protection
Enabling the setting did not work because the SYSTEMUI_BURNIN_PROTECTION
string had wrong prefix and was not registered as tunable.
Change-Id: I6a99a7616b2e980aa8d4dfd86ba82351508825b2
Michael W [Sun, 10 Dec 2017 17:37:44 +0000 (18:37 +0100)]
SystemUI: KeyGuardMonitor: Prevent ConcurrentModificationException
* Instead of accessing the original ArrayList, which might be modified
while processing the loop, create a copy of the list and work with that
one
* This ensures that no exception is thrown when some other part unregisters
its listener while the list is already being processed
BUGBASH-1289
Change-Id: Ie8404d88c7c87c4ec8fcd64fdd5218b25806f24f
Michael W [Thu, 30 Nov 2017 21:39:00 +0000 (22:39 +0100)]
SystemUI: Recents: Improve code for long app titles being overlapped
* Take all buttons into account when calculating the margin for title
* Don't check every combination of buttons but just add a margin for
each of them
Change-Id: I8e3da14ee00f0d16667866585cceef48ef1348c4
Unpublished [Tue, 24 Oct 2017 19:09:31 +0000 (21:09 +0200)]
We don't want to feel deprecated...
use official api instead of deprecated internal method that prints an
error everytime we call it
Change-Id: Ie00efe5f514ff8db2b82eeade3a588a17af8cfb4
Abhisek Devkota [Sat, 16 Dec 2017 19:32:58 +0000 (11:32 -0800)]
Automatic translation import
Change-Id: I434bebf88b227bc88bb7447596b8e1eab56943de
Abhisek Devkota [Tue, 12 Dec 2017 05:54:47 +0000 (21:54 -0800)]
Automatic translation import
Change-Id: I264296d5b20361666503fb6eaac02e5d79722c9c
Jeff Sharkey [Mon, 12 Jun 2017 23:33:07 +0000 (17:33 -0600)]
DO NOT MERGE. KEY_INTENT shouldn't grant permissions.
KEY_INTENT has no business granting any Uri permissions, so remove
any grant flags that malicious apps may have tried sneaking in.
Test: builds, boots
Bug:
32990341,
32879915
Change-Id: I657455a770c81f045ccce6abbd2291407a1cfb42
(cherry picked from commit
ec733747bb428cea3b5523518c59159031f96e47)
Leon Scroggins III [Fri, 10 Mar 2017 15:50:33 +0000 (10:50 -0500)]
Stop explicitly using kCallerPasses_Ownership
Bug:
65646012
Bug:
65426286
Cherry-picked from master. The original CL just updates BitmapFactory.
This also updates ExifInterface in the same way. ExifInterface.cpp no
longer existed by the time the Skia change landed.
Required for Ib7aaf367f68f8764147887d858f65ee14fa7a1d9, which fixes
the aforementioned bugs.
Test: No change in behavior, no new tests.
This enum is going away in https://skia-review.googlesource.com/c/9498,
and this method is using the default anyway.
Merged-In: I928a72851f90e84f45ce2fa49560f8ba894a8058
Merged-In: I8f6c761e50cb29476dc0784f58908ec35e3c70e9
Change-Id: I928a72851f90e84f45ce2fa49560f8ba894a8058
(cherry picked from commit
adb5e0ba6d532c0d52b3bf89a1dbec4e3e7a6fd6)
Siyamed Sinir [Wed, 13 Sep 2017 23:32:21 +0000 (16:32 -0700)]
Fix ClipboardService device lock check for cross profile
ClipboardService.isDeviceLocked should clear callingIdentity before
accessing KeyguardManager.
Test: bit CtsDevicePolicyManagerTestCases:com.android.cts.devicepolicy.ManagedProfileTest
Bug:
64934810
Change-Id: I81a7adac8c9d56ed801ffc1380fcbc987d5df3e6
Merged-In: I712abfe8d542cd1be9c1816f407c8912321ac480
(cherry picked from commit
6d79675e0c0e55a7d5591a123727796f52c42954)
Siyamed Sinir [Thu, 7 Sep 2017 01:02:23 +0000 (18:02 -0700)]
Prevent getting data from Clipboard if device is locked
Clipboard should not return data if the device is locked. This CL checks
for device locked state before returning values from get/has functions.
Bug:
64934810
Change-Id: I856a9079fe64db0af44383fae1a9a418de959420
Merged-In: Icefac226615fe22a7735dff4ba4c3b528fb2ac12
(cherry picked from commit
0b8fa2f5e0d305f083345968a7c39fe7a6f0a158)
Suprabh Shukla [Fri, 12 May 2017 22:26:54 +0000 (15:26 -0700)]
Clearing up invalid entries when SyncStorageEngine starts
Any app with permission WRITE_SYNC_SETTINGS could write sync settings
for authorities or accounts that are not valid. This results in invalid
data being persisted to disk which can effectively lead to a DOS style
attack. Clearing such entries on boot will make sure that a reboot fixes
any such issues.
Test: cts-tradefed run cts-dev -m CtsSyncContentHostTestCases
Bug:
35028827
Change-Id: I9e206a42508e3cba65d7523bf47fff743f47dcb2
Merged-In: I9e206a42508e3cba65d7523bf47fff743f47dcb2
(cherry picked from commit
042a478b73c3b7f7cd73f5bb1af657cfe07d0571)
(cherry picked from commit
e5787fc13164856e39690e40e81d3d46839eea16)
LuK1337 [Thu, 30 Nov 2017 12:15:13 +0000 (13:15 +0100)]
SystemUI: Fix title text clipping when task lock button is visible
Change-Id: I8005360f932c930011d969e2913bc28efb826163
Gabriele M [Tue, 28 Nov 2017 23:50:29 +0000 (00:50 +0100)]
ZenModeHelper: Allow lights by default
mAllowLights is false by default, so if zen_mode is set to
ZEN_MODE_OFF, LED notifications will be suppressed. Ensure
mAllowLights is true when zen_mode is ZEN_MODE_OFF.
BUGBASH-1259
Change-Id: I979a4d9cfee4ee77c0cd3b9d6338d55961183eb7
Paul Keith [Thu, 23 Nov 2017 20:47:51 +0000 (21:47 +0100)]
fw/b: Return a KeyEvent instead of a boolean in KeyHandler
* Allows handlers to modify the event before sending it off
to another KeyHandler class, to handle things like rotation
Change-Id: I481107e050f6323c5897260a5d241e64b4e031ac
Steve Kondik [Sun, 5 Nov 2017 15:37:52 +0000 (16:37 +0100)]
SystemUI: LiveDisplay tile
Change-Id: I53d492e5cb9998268104d5750705aa5ed55d9658
Signed-off-by: Joey Rizzoli <joey@lineageos.org>
Tony Mak [Thu, 10 Aug 2017 13:19:43 +0000 (14:19 +0100)]
DPC should not be allowed to grant development permission
Test: cts-tradefed run cts-dev --module CtsDevicePolicyManagerTestCases --t com.android.cts.devicepolicy.MixedDeviceOwnerTest#testPermissionGrant_developmentPermission
Test: cts-tradefed run cts-dev --module CtsDevicePolicyManagerTestCases --t com.android.cts.devicepolicy.MixedProfileOwnerTest#testPermissionGrant_developmentPermission
Test: cts-tradefed run cts-dev --module CtsDevicePolicyManagerTestCases --t com.android.cts.devicepolicy.MixedDeviceOwnerTest#testPermissionGrant
Test: cts-tradefed run cts-dev --module CtsDevicePolicyManagerTestCases --t com.android.cts.devicepolicy.MixedProfileOwnerTest#testPermissionGrant
Test: Run "Permissions lockdown" test in CtsVerifier
Bug:
62623498
Merged-In: If83d8edd0eea99145421e967ae47fdc264a5cf7c
Change-Id: I129bfe850981cf0b3646b7c1cf19c8a3ec69f512
(cherry picked from commit
d05d2bac845048f84eebad8060d28332b6eda259)
Aaron Kling [Mon, 13 Nov 2017 05:53:54 +0000 (23:53 -0600)]
Add stub for setCursorVisibility
This is called by an Nvidia Shield exclusive game which crashes
if the function is not found.
Change-Id: I2aea38ad8d9dab046f351e18a91b2418d8a982b2
Gabriele M [Sun, 5 Nov 2017 23:54:38 +0000 (00:54 +0100)]
Prevent deadlock when using always-on legacy VPNs
The following deadlock can happen when using an always-on legacy
VPN connection:
"Binder:7444_7" prio=5 tid=94 Blocked
at com.android.server.connectivity.Vpn.isBlockingUid(Vpn.java:-1)
- waiting to lock <0x032141f0> (a com.android.server.connectivity.Vpn) held by thread 52
at com.android.server.ConnectivityService.isNetworkWithLinkPropertiesBlocked(ConnectivityService.java:1041)
- locked <0x0791429e> (a android.util.SparseArray)
"ConnectivityServiceThread" prio=5 tid=52 Blocked
at com.android.server.ConnectivityService.getLinkProperties(ConnectivityService.java:1351)
- waiting to lock <0x09ec3887> (a com.android.server.connectivity.NetworkAgentInfo) held by thread 103
at android.net.ConnectivityManager.getLinkProperties(ConnectivityManager.java:1065)
at com.android.server.connectivity.Vpn$LegacyVpnRunner.<init>(Vpn.java:1524)
at com.android.server.connectivity.Vpn.startLegacyVpn(Vpn.java:1413)
- locked <0x032141f0> (a com.android.server.connectivity.Vpn)
"Binder:7444_D" prio=5 tid=103 Blocked
at com.android.server.ConnectivityService.isNetworkWithLinkPropertiesBlocked(ConnectivityService.java:1039)
- waiting to lock <0x0791429e> (a android.util.SparseArray) held by thread 94
at com.android.server.ConnectivityService.reportNetworkConnectivity(ConnectivityService.java:3249)
- locked <0x09ec3887> (a com.android.server.connectivity.NetworkAgentInfo)
Lock <0x0791429e> before <0x09ec3887> in thread 103 so that thread 94
will lock <0x032141f0> when <0x09ec3887> is not locked, allowing thread
52 to complete.
BUGBASH-1197
Change-Id: Ifaf4d4dc0053dd71ab0734e3f3b1e9839eece22a
Aaron Kling [Tue, 7 Nov 2017 20:36:08 +0000 (14:36 -0600)]
Add powerhint function that accepts an array of data
Change-Id: I9f7cf223fba8e448a9fc737c0148b6c11f5abfdb
Abhisek Devkota [Sat, 21 Oct 2017 18:10:48 +0000 (11:10 -0700)]
Automatic translation import
Change-Id: I520ed5cb674edad98c2ce3dd70471a079ef34fb2
Joey Rizzoli [Fri, 13 Oct 2017 18:18:03 +0000 (20:18 +0200)]
SystemUI: Profiles tile should require authentication
A profile with the option to disable secure lockscreen could be
used to bypass the lockscreen security.
Require the user to unlock their device when tapping on the profile
quick tile.
BUGBASH-1095
Change-Id: I9d63fcd9b1e3f47c9ca3374806d5ef05fe9ff32b
Signed-off-by: Joey Rizzoli <joey@lineageos.org>
Gabriele M [Thu, 28 Sep 2017 12:53:39 +0000 (14:53 +0200)]
Revert "Always hide protected apps from the recent tasks list"
This doesn't always have the desired effect. For example, CMParts is
now a protected component manager and can start protected activities
without requiring any authentication. This change seems to undo the
effect of FLAG_ACTIVITY_NEW_TASK that CMParts sets when it starts a
protected component, therefore, even though no new entry is added to
the recents list, the protected component replaces the entry for
CMParts. This is equivalent to adding an entry for the app to the
recents list. Forcing FLAG_ACTIVITY_NEW_TASK appears to have desired
effect (no entry for the protected app in recents), but this change
would be too intrusive and it could potentially break something else.
Setting the proper flags from the protected component manager is
probably a safer option, even though it would not be able to stop
apps from creating new entries in recents themselves.
This reverts commit
15360dfe60a2c81187e4edcaf08679100260e2f9.
Change-Id: Ie54cb6c6ddc1d1156076bce4b7ce9a5811df1460
Michael W [Mon, 9 Oct 2017 20:04:00 +0000 (22:04 +0200)]
Core: Battery warning levels are inclusive, not exclusive
* Instead of checking for the current level to be smaller than the warning
level, already react when the warning level is reached
* Simply change of '<' to '<='
Bugbash-1100
Change-Id: Ib35b154b6117f7e26b4a3a5aee9254dda3adda12
Charles He [Fri, 14 Jul 2017 13:41:06 +0000 (14:41 +0100)]
Fix security hole in GateKeeperResponse.
GateKeeperResponse has inconsistent writeToParcel() and
createFromParcel() methods, making it possible for a malicious app to
create a Bundle that changes contents after reserialization. Such
Bundles can be used to execute Intents with system privileges.
This CL changes writeToParcel() to make serialization and
deserialization consistent, thus fixing the issue.
Bug:
62998805
Test: use the debug app (see bug)
Change-Id: Ie1c64172c454c3a4b7a0919eb3454f0e38efcd09
(cherry picked from commit
e74cae8f7c3e6b12f2bf2b75427ee8f5b53eca3c)
Tony Mak [Fri, 28 Jul 2017 10:53:56 +0000 (11:53 +0100)]
Enforce policy for camera gesture in keyguard
Test:
1. Set lock screen, set keyguard policy. Lock the device.
Observe that double tap is not showing camera
2. Set lock screen, unset the keyguard policy. Lock the device.
Observe that double tap is showing camera
3. Unset lock screen (swipe), set the keyguard policy. Lock the device.
Observe that double tap is showing camera.
4. Unset lock screen (swipe), unset the keyguard policy. Lock the device.
Observe that double tap is showing camera.
Bug:
63787722
Merged-In: I104688eaad719528376e2851f837d5956a6a1169
Change-Id: I42e6d9015682998176fe41971356bde22e1b37b2
(cherry picked from commit
65f02e8ba7a9f013d6971b3d6d1bd95f1785cb3d)
Michael W [Sat, 23 Sep 2017 14:27:41 +0000 (16:27 +0200)]
SystemUI: Cleanup BatteryMeter
* Remove unused imports and variables from BatteryMeterView and -Drawable
* Remove some commented stuff about themes
Change-Id: Iab057e510a4478ac1f026f004eef9d6f46e6032f
Michael W [Sat, 23 Sep 2017 13:39:11 +0000 (15:39 +0200)]
SystemUI: Improve battery icons
* When the battery saver is on, always show the percentage (if option is
set)
* Change color of exclamation mark when the battery saver is on so it's
visible
Change-Id: Ia7e6bc05225b131aaa62370314b035f2b874b5ec
Eric Meddaugh [Fri, 29 Sep 2017 21:53:56 +0000 (21:53 +0000)]
Revert "Camera: ignore torch status update for aux or compsite camera"
This reverts commit
92add565cf47afc67fbb8b709bb45bd687126c3c.
Causes soft reboots for devices with more than 2 cameras.
Change-Id: I687488f3de9e28854785fc44fd1ce24ce01be02a
Michael Bestas [Sun, 17 Sep 2017 19:51:15 +0000 (22:51 +0300)]
SystemUI: Hide ambient display tile if device does not support it
* Add a check similar to the Settings app
Change-Id: I603cd28b8dd1fadff9ffcfb6953c7b72514b5857
Gabriele M [Mon, 25 Sep 2017 09:29:38 +0000 (11:29 +0200)]
Don't crash when checking if components are protected
intent.getComponent() can be null, but isComponentProtected() expects
a valid object. Add a null pointer check and don't treat the app as
protected if null.
Fixes
15360dfe60a2c81187e4edcaf08679100260e2f9
("Always hide protected apps from the recent tasks list")
Change-Id: I2e0ccdfb9ded7aa32305bc2ac97e0950940d186b
thecrazyskull [Sat, 9 Sep 2017 15:03:18 +0000 (17:03 +0200)]
SystemUI: locked tasks should have a valid view
If the view doesn't exist, the card won't be able to receive touch
events. We need those touch events to have a bounce-back animation
when trying to swipe away a locked card.
Change-Id: If7b3c5e5094d2752926eb306dd54264da0ceaa3e
Signed-off-by: Joey Rizzoli <joey@lineageos.org>
Roman Birg [Thu, 22 Jan 2015 19:21:56 +0000 (11:21 -0800)]
System Profiles in QS Tiles
Change-Id: I2a438af301212241533b969bf2c6c8390ef09cbc
Park Ju Hyung [Sat, 14 Jan 2017 18:33:04 +0000 (03:33 +0900)]
[1/3] SystemUI: add burnIn protection setting
Devices with OLED display suffer from
status-bar's notification items and nagivation bar's software keys
causing permanent burn-ins when used long-term.
Moving all items in the area
both horizontally and vertically workarounds this problem.
jrizzoli: integrate with runtime cmsdk preference
Change-Id: I35b04d1edff86a556adb3ad349569e5d82653f16
Signed-off-by: Park Ju Hyung <qkrwngud825@gmail.com>
Signed-off-by: Alex Naidis <alex.naidis@linux.com>
Signed-off-by: Thecrazyskull <anaskarbila@gmail.com>
Signed-off-by: Joey Rizzoli <joey@lineageos.org>
Abhisek Devkota [Mon, 18 Sep 2017 18:47:33 +0000 (11:47 -0700)]
Automatic translation import
Change-Id: I73e8fe40dcc6d8412dc5fe5497a28a02de8b36d8
Mao Jinlong [Tue, 1 Aug 2017 11:27:01 +0000 (19:27 +0800)]
SystemServer: Don't start widget service when it is alarm boot
In alarm boot mode, only power off alarm apps are installed. If
starting widget service in alarm boot mode, the widget record will be
changed. So don't start widget service when it is alarm boot.
CRs-Fixed:
2082007
Change-Id: I3d1b1882cac7eb76fb09684811bb01a96fbc7f62
Michael Bestas [Fri, 8 Sep 2017 13:42:57 +0000 (16:42 +0300)]
ActivityManager: Remove POWER_OFF_ALARM intent leftover
Change-Id: I7768b7d93803aa84416ad4f63f15bfcf0f13c46e
Gabriele M [Sat, 22 Jul 2017 11:28:06 +0000 (13:28 +0200)]
Always hide protected apps from the recent tasks list
If a protected app is started by a protected component manager, it
will be available in the recent tasks list. This allows to bypass
the protection since restarting an app from recents doesn't require
authentication. Fix this changing the flags of the activity so that
it's never added to the recent tasks list.
This change also ensures that apps don't add entries to the recent
tasks list: a protected component that starts a new instance of
itself it's treated like a protected component manager and therefore
its entries are not removed from the recent tasks list.
Change-Id: Ib44b392cc9c27ec2b7c8f16735c38ee45011be3e
Harry Youd [Sun, 27 Aug 2017 19:29:57 +0000 (21:29 +0200)]
Recents: Add accessibility descriptions for lock ImageViews
Change-Id: I09ce342ce135017294f5a4197b7e52dded3fb17e
Gabriele M [Sat, 16 Sep 2017 17:35:38 +0000 (19:35 +0200)]
SystemUI: Add separate pref screen for the status bar tuner
Keep the status bar preferences separate and allow to start them
directly without loading the main tuner fragment.
Change-Id: Ie1a0d9395b7bc01d585616a1976adeda3c457a0d
Gabriele M [Sat, 16 Sep 2017 17:35:28 +0000 (19:35 +0200)]
SystemUI: Revert some Tuner changes
These changes were done to start the status bar tuner directly without
showing the main Tuner screen. However, they negatively affect the
management of the fragments. Revert them so that a different solution
can be implemented in a follow-up change.
This reverts the following commits:
-
338de6728d8910d450f8962a44bbe69feba1ced4
"Handle onOptionsItemSelected for TunerActivity"
-
b3eba6af8e3253efc1332b55821fd08e4fbf77b0
"SystemUI: Remove nav bar and status bar options from SystemUI Tuner"
-
82b9f95f761e7b5cc94ea2542b30460e48f8fb02 (partially)
"systemui: Fix a few issues with Tuner"
BUGBASH-661
Change-Id: I35182248566ff31ed08d2836d66d5bd3f947ee9a
Phil Weaver [Wed, 12 Jul 2017 21:04:16 +0000 (14:04 -0700)]
Back-port fixes for b/
62196835
Bug:
62196835
Test: Created an accessibility service that displays a system
and a toast overlay, confirmed that it disappeared when we
reached the accessibility permission screen that uses this
flag.
Change-Id: Ic51ead670fc480e549512ba1d02f49d9c13bc3f0
(cherry picked from commit
41ff5389daa6e6ce4aa853bfae96e5ced0b1d8df)
Gabriele M [Wed, 30 Aug 2017 22:25:21 +0000 (00:25 +0200)]
Don't disable the GPS prematurely
Since commit
b2b4489760230258d23f72f8f8dd643b09cd5b04
("Use SystemClock.elapsedRealtime() to calc TTFF") mLastFixTime
stores the time since boot rather than the current real time.
REGRESSION-1032
Change-Id: I39474a66c6d7dbd9ca0ff50a5a1b9c06007725c4
Dominggoes Isakh [Tue, 25 Jul 2017 20:57:17 +0000 (22:57 +0200)]
PrivateStorageInfo: Exclude primary physical volume total space
BUGBASH-355
Change-Id: If811545e352d7e499630e11e7583d643e1510431
Paul Keith [Sat, 19 Aug 2017 15:45:21 +0000 (17:45 +0200)]
Keyguard: Change fingerprint listening behavior
* This patch affects devices that disable fingerprint
wake-and-unlock via config_fingerprintWakeAndUnlock,
and is mainly for fp scanners in the power button
* Don't listen to fingerprints when going to sleep
to avoid a wakeup being triggered after pressing
the power button to turn the screen off
* Fixes the following scenario:
- Turn device on with not registered finger
- Check time (or something on lock screen)
- Use registered finger to turn off device,
and leave finger on the scanner
- Device screen turns off
- Device wakes up at home screen
Change-Id: Ia40a6a763420cd716796515ddb9b816232218dc0
Gabriele M [Thu, 3 Mar 2016 20:16:40 +0000 (21:16 +0100)]
Allow to ignore presentation indicator of outgoing calls [1/3]
With some mobile network operators, the presentation indicator of
outgoing calls is always set to either "unknown" or "restricted".
As consequence, the dialed number doesn't show up in clear in the
call history. Allow to ignore the presentation indicator of outgoing
calls to never hide the dialed numbers.
Change-Id: Ia40de2ce40fee5068f82abd69595b34d2596caae
Yingjie Wang [Mon, 13 Mar 2017 04:03:20 +0000 (12:03 +0800)]
Use SystemClock.elapsedRealtime() to calc TTFF
SystemClock.elapsedRealtime() returns milliseconds since boot, and
is less vulnerable to system time issue.
Change-Id: I01c2c1205c4306c6d8ce62875ff1295001ed8491
CRs-fixed:
2015708
Veeti Paananen [Wed, 16 Aug 2017 21:24:26 +0000 (00:24 +0300)]
Tweak Privacy Guard dialog layout
Make the "remember choice" check text clickable. Adjust margins to match
Material spec. Remove crazy table layout.
Change-Id: Ibeabdf693dc9273ba80f21fab399868fecac9054
Abhisek Devkota [Sat, 19 Aug 2017 22:34:09 +0000 (15:34 -0700)]
Automatic translation import
Change-Id: I92ceaa006a8c4b411afcc271384679d2f36ca1a3
Corinna Vinschen [Sat, 12 Aug 2017 11:42:58 +0000 (13:42 +0200)]
PowerManager: Allow to distinguish different keypresses
* Use keypress info to exclude pressing volume keys from
illuminating HW buttons in config_buttonLightOnKeypressOnly
mode.
Change-Id: I6bfc7ddd075e12e1ad10c3663a63e80c8d7f983d
Signed-off-by: Corinna Vinschen <xda@vinschen.de>
Gabriele M [Fri, 18 Aug 2017 17:36:48 +0000 (19:36 +0200)]
Add @hide annotation to the privacy guard ops set
Otherwise the system API check fails.
Change-Id: I75c096ee22cc15577f7887bd900667c2a6b213d5
Gabriele M [Sun, 6 Aug 2017 11:08:33 +0000 (13:08 +0200)]
Change visibility of the Privacy Guard ops set
Change-Id: Iafcf058f5e2074982bf45f8c82ef8d027b9358f0
Shukla Mradul [Thu, 1 Jun 2017 08:08:02 +0000 (13:38 +0530)]
Camera2: Fix Error Callback if buffer lost.
Existing Android Code doesnt provide support to detect
bufferlost callback at App level.
Bug is fixed to add the callback function which will give
callback to App.
Change-Id: If1656fa3835303b22a230753933c650eca58bcc2
Gaoxiang Chen [Wed, 12 Apr 2017 12:05:24 +0000 (20:05 +0800)]
Camera: ignore torch status update for aux or compsite camera
Issue:
we only expose aux and composite camera ids to whitelist app,
but don't check the whitelist in torch status update.
So for apps not in whitelist like CTS,
they might receive extra unexpected torch status update,
from aux and composite camera, which could cause CTS failure.
Fix:
Also ignore torch status update, if app not in whitelist.
It can fixe CTS issues in FlashlightTest.java.
CRs-Fixed:
2033688
Change-Id: I308bccfc027017b590f9f91089d644f7d8a206ff
Humberto Borba [Wed, 9 Aug 2017 15:11:25 +0000 (12:11 -0300)]
base: audioservice: Set BT_SCO status
It is expected from audio HAL during BT SCO routing.
Signed-off-by: Humberto Borba <humberos@gmail.com>
Change-Id: Ifdf7529ff292e9f73fc820400ccc7b6ac7ad112a
ahmedsh [Thu, 8 Dec 2016 22:18:03 +0000 (17:18 -0500)]
SEEMP: Adding auth framework for outgoing SMS messages.
This change adds the APIs required to register an authorization agent
in order to allow/reject outgoing SMS messages and the core service
that implements the sms security model.
Change-Id: I5f7195dbdf1d6ff9e0bc5b3118d4a585b51bead8
Corinna Vinschen [Sun, 6 Aug 2017 13:05:54 +0000 (15:05 +0200)]
PowerManagerService: fix HW button illumination timeout
Patch
20a3c7c4e823a89e428997a1c2771c0c4f1d4684, introducing hardware
button backlight on button keypress only, also introduced a bug:
When touching a button and then performing display activity while
the buttons are still on, the buttons would keep lightened up until
the next user interaction, potentially only switched off at the next
screen off timeout. Also, the buttons were not illuminated on
device wakeup.
This patch fixes it, together with another, long-standing problem:
When touching a hardware button, nextTimeout was set to
now + mButtonTimeout, even if mButtonTimeout is longer than the timeout
determined by the screen off timeout. To wit, if screen timeout is set
to 15 secs, but button timeout to values > 15 secs.
Change-Id: I8a56f1d1e0138c38ed6fe294e4816a9f7f744f1e
Signed-off-by: Corinna Vinschen <xda@vinschen.de>
Abhisek Devkota [Wed, 9 Aug 2017 03:15:08 +0000 (20:15 -0700)]
Automatic translation import
Change-Id: I932e63cc0dbc1e592cc61adbd902d7bf208974a4
Dan Pasanen [Mon, 7 Aug 2017 23:38:44 +0000 (18:38 -0500)]
Merge tag 'android-7.1.2_r29' into cm-14.1
Android 7.1.2 Release 29 (NJH47F)
# gpg: Signature made Fri Jul 28 13:56:01 2017 CDT
# gpg: using DSA key
E8AD3F819AB10E78
# gpg: Can't check signature: No public key
qjohn [Sun, 18 Jun 2017 09:28:10 +0000 (16:28 +0700)]
SystemUI: Remove unnecessary brightness icons
Change-Id: I7e60ff73125bd0304f9ca14ad5c5a9ce11ffceda
LuK1337 [Sat, 5 Aug 2017 08:42:59 +0000 (10:42 +0200)]
SystemUI: Fix battery meter view blacklist handling
* Fixes /weird padding/ after adding any icon while
using battery level icon set to text or hidden.
Change-Id: If3468d25d961169b87f43d2c5f7f2e7d2f8dc12f
Abhisek Devkota [Fri, 4 Aug 2017 05:46:02 +0000 (22:46 -0700)]
Automatic translation import
Change-Id: Ida033525846eb1096c419751b81f058f0fc8371c