OSDN Git Service

(root) / android-x86 / frameworks-native.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: f52855d) | patch
Don't pad before calling writeInPlace().
authorMartijn Coenen <maco@google.com>
Wed, 4 Apr 2018 09:46:56 +0000 (11:46 +0200)
committerandroid-build-team Robot <android-build-team-robot@google.com>
Fri, 3 Aug 2018 19:07:44 +0000 (19:07 +0000)
commit51db8c36586507ef80c3f4e76358f58a7b7fcdb7
treefe4081a0bbd50570afdb060c0cda57b68f20a67ctree | snapshot
parentf52855df9b9a6f9eefc96851a52cd2f048bc5f7dcommit | diff
Don't pad before calling writeInPlace().

writeInplace() itself already pads securely, by masking off
the padded bytes. If the padding is done before calling
writeInplace(), no mask is applied, and heap data can leak.

Bug: 77237570
Test: builds
Change-Id: Ide27a0002d4ed4196530430760245b971f6a3f44
Merged-In: Ide27a0002d4ed4196530430760245b971f6a3f44

(cherry picked from commit f8542381b72a7bb2452a5278a00ca8c34edbf8a0)
(cherry picked from commit 732132b765cd7b667f16cf32f0fe4c852d7d44dd)

Change-Id: Ia9d0e50488ee1f427c182b6277f877d4eda76f77
libs/binder/Parcel.cpp diff | blob | history
frameworks/native
About OSDN
Find Software
Develop Software
Help