OSDN Git Service

(root) / android-x86 / frameworks-native.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 93dc04f) | patch
Don't pad before calling writeInPlace().
authorMartijn Coenen <maco@google.com>
Wed, 4 Apr 2018 09:46:56 +0000 (11:46 +0200)
committerandroid-build-team Robot <android-build-team-robot@google.com>
Fri, 10 Aug 2018 20:28:30 +0000 (20:28 +0000)
commitcc9b3a20a7bee53eaf69cb34fa30f1329cbb081c
tree1f5b5297a06eb215839a8e35fc5365700e082be3tree | snapshot
parent93dc04fcf2bc9cc7a4125c9dcb8caa90df4c4ff7commit | diff
Don't pad before calling writeInPlace().

writeInplace() itself already pads securely, by masking off
the padded bytes. If the padding is done before calling
writeInplace(), no mask is applied, and heap data can leak.

Bug: 77237570
Test: builds
Change-Id: Ide27a0002d4ed4196530430760245b971f6a3f44
Merged-In: Ide27a0002d4ed4196530430760245b971f6a3f44

(cherry picked from commit f8542381b72a7bb2452a5278a00ca8c34edbf8a0)
(cherry picked from commit 732132b765cd7b667f16cf32f0fe4c852d7d44dd)

Change-Id: I59a088c75353786ca105a3735886af372592c759
libs/binder/Parcel.cpp diff | blob | history
frameworks/native
About OSDN
Find Software
Develop Software
Help