OSDN Git Service

(root) / android-x86 / frameworks-native.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: ab1fb95) | patch
Don't pad before calling writeInPlace().
authorMartijn Coenen <maco@google.com>
Wed, 4 Apr 2018 09:46:56 +0000 (11:46 +0200)
committerandroid-build-team Robot <android-build-team-robot@google.com>
Fri, 25 May 2018 18:40:50 +0000 (18:40 +0000)
commitff2171f2460e3a6d3443ab957732b8b7d4831d40
tree1f5b5297a06eb215839a8e35fc5365700e082be3tree | snapshot
parentab1fb955acc8bbe6b9086a4ab54beab003a887a9commit | diff
Don't pad before calling writeInPlace().

writeInplace() itself already pads securely, by masking off
the padded bytes. If the padding is done before calling
writeInplace(), no mask is applied, and heap data can leak.

Bug: 77237570
Test: builds
Change-Id: Ide27a0002d4ed4196530430760245b971f6a3f44
Merged-In: Ide27a0002d4ed4196530430760245b971f6a3f44

(cherry picked from commit f8542381b72a7bb2452a5278a00ca8c34edbf8a0)
(cherry picked from commit 732132b765cd7b667f16cf32f0fe4c852d7d44dd)

Change-Id: Id65e4573e18ab68b804f1cf63a6977a71da01e5d
libs/binder/Parcel.cpp diff | blob | history
frameworks/native
About OSDN
Find Software
Develop Software
Help