OSDN Git Service

net: ucc_geth - fix Oops when changing number of buffers in the ring
[android-x86/kernel.git] / drivers / net / ethernet / freescale / ucc_geth_ethtool.c
index 812a968..6aa4b50 100644 (file)
@@ -250,14 +250,12 @@ uec_set_ringparam(struct net_device *netdev,
                return -EINVAL;
        }
 
+       if (netif_running(netdev))
+               return -EBUSY;
+
        ug_info->bdRingLenRx[queue] = ring->rx_pending;
        ug_info->bdRingLenTx[queue] = ring->tx_pending;
 
-       if (netif_running(netdev)) {
-               /* FIXME: restart automatically */
-               netdev_info(netdev, "Please re-open the interface\n");
-       }
-
        return ret;
 }