OSDN Git Service

uprobes: Use synchronize_rcu() not synchronize_sched()
authorSteven Rostedt (VMware) <rostedt@goodmis.org>
Thu, 9 Aug 2018 19:37:59 +0000 (15:37 -0400)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Fri, 10 Aug 2018 19:32:28 +0000 (15:32 -0400)
commit016f8ffc48cb01d1e7701649c728c5d2e737d295
tree121eb51e535dc7ea6aafd2fcb741f02d7c47b414
parente0a568dcd18bdaa77877d558700ce4d3bbbb12b8
uprobes: Use synchronize_rcu() not synchronize_sched()

While debugging another bug, I was looking at all the synchronize*()
functions being used in kernel/trace, and noticed that trace_uprobes was
using synchronize_sched(), with a comment to synchronize with
{u,ret}_probe_trace_func(). When looking at those functions, the data is
protected with "rcu_read_lock()" and not with "rcu_read_lock_sched()". This
is using the wrong synchronize_*() function.

Link: http://lkml.kernel.org/r/20180809160553.469e1e32@gandalf.local.home
Cc: stable@vger.kernel.org
Fixes: 70ed91c6ec7f8 ("tracing/uprobes: Support ftrace_event_file base multibuffer")
Acked-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace_uprobe.c