OSDN Git Service

watchdog: gpio-wdt: be more strict about hw_algo matching
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thu, 30 Jul 2015 09:32:23 +0000 (11:32 +0200)
committerWim Van Sebroeck <wim@iguana.be>
Wed, 9 Sep 2015 19:35:14 +0000 (21:35 +0200)
commit0a0a542f6bbb2ebe956f0117c842302442ef52da
treefcce706c2c692ae597097ea3d56cf13c6a48122c
parentab54d7f017772e89964d4040937a83cd4468562a
watchdog: gpio-wdt: be more strict about hw_algo matching

strncmp(algo, "toggle", 6) doesn't compare the trailing '\0' byte, so
using

hw_algo = "toggleboggle"

is recognized the same way as

hw_algo = "toggle"

. While this doesn't introduce any problems for a device tree that
sticks to the documented settings it's still ugly.

Fix this by using strcmp to only match on "toggle" and "level".

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/gpio_wdt.c