OSDN Git Service

crypto: drbg - wait for crypto op not signal safe
authorGilad Ben-Yossef <gilad@benyossef.com>
Thu, 18 May 2017 13:29:24 +0000 (16:29 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jun 2017 13:05:55 +0000 (15:05 +0200)
commit2d0280070e6c3f0028ca462b59db5c0a45d36299
treea60fb097820f80434fe81c8bdc154ac8f6435f20
parentd24c1c1977d80dcedf4e469be62f71644bf3383e
crypto: drbg - wait for crypto op not signal safe

commit a5dfefb1c3f3db81662556393fd9283511e08430 upstream.

drbg_kcapi_sym_ctr() was using wait_for_completion_interruptible() to
wait for completion of async crypto op but if a signal occurs it
may return before DMA ops of HW crypto provider finish, thus
corrupting the output buffer.

Resolve this by using wait_for_completion() instead.

Reported-by: Eric Biggers <ebiggers3@gmail.com>
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
crypto/drbg.c