OSDN Git Service

cifs: fix memory leak of pneg_inbuf on -EOPNOTSUPP ioctl case
authorColin Ian King <colin.king@canonical.com>
Fri, 17 May 2019 08:12:33 +0000 (09:12 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 9 Jun 2019 07:17:22 +0000 (09:17 +0200)
commit32d57c0c063cdab6639da074e8b0f28517862e41
tree0716bb99cc9d000931cad1000338ed96726cb192
parentf6a39f877feb5342aee6b7ca63a61ceedaa92be7
cifs: fix memory leak of pneg_inbuf on -EOPNOTSUPP ioctl case

commit 210782038b54ec8e9059a3c12d6f6ae173efa3a9 upstream.

Currently in the case where SMB2_ioctl returns the -EOPNOTSUPP error
there is a memory leak of pneg_inbuf. Fix this by returning via
the out_free_inbuf exit path that will perform the relevant kfree.

Addresses-Coverity: ("Resource leak")
Fixes: 969ae8e8d4ee ("cifs: Accept validate negotiate if server return NT_STATUS_NOT_SUPPORTED")
CC: Stable <stable@vger.kernel.org> # v5.1+
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/cifs/smb2pdu.c