OSDN Git Service

blk-mq: fix race between updating nr_hw_queues and switching io sched
authorMing Lei <ming.lei@redhat.com>
Sat, 6 Jan 2018 08:27:40 +0000 (16:27 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 13 Apr 2018 17:48:11 +0000 (19:48 +0200)
commit3bab65f29e6bf4615519b1e6dba5684cc8b53a72
treeffd75d4bd04fcf025d6ef1b198f7dc1bcb6a9417
parent5736369b54e3a4dc00592df922fbd8d739fb5be2
blk-mq: fix race between updating nr_hw_queues and switching io sched

[ Upstream commit fb350e0ad99359768e1e80b4784692031ec340e4 ]

In both elevator_switch_mq() and blk_mq_update_nr_hw_queues(), sched tags
can be allocated, and q->nr_hw_queue is used, and race is inevitable, for
example: blk_mq_init_sched() may trigger use-after-free on hctx, which is
freed in blk_mq_realloc_hw_ctxs() when nr_hw_queues is decreased.

This patch fixes the race be holding q->sysfs_lock.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Reported-by: Yi Zhang <yi.zhang@redhat.com>
Tested-by: Yi Zhang <yi.zhang@redhat.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
block/blk-mq.c