OSDN Git Service

can: dev: call netif_carrier_off() in register_candev()
authorRasmus Villemoes <rasmus.villemoes@prevas.dk>
Mon, 24 Jun 2019 08:34:13 +0000 (08:34 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Sep 2019 08:19:32 +0000 (10:19 +0200)
commit400fc13eb06830885fa0d8427cc335840e5510b0
tree09efa925b5b6092dd7615cbce6c8aa5825e031b5
parent31ab0498dd1bb0e0d7669fe945a5ef932a203762
can: dev: call netif_carrier_off() in register_candev()

[ Upstream commit c63845609c4700488e5eacd6ab4d06d5d420e5ef ]

CONFIG_CAN_LEDS is deprecated. When trying to use the generic netdev
trigger as suggested, there's a small inconsistency with the link
property: The LED is on initially, stays on when the device is brought
up, and then turns off (as expected) when the device is brought down.

Make sure the LED always reflects the state of the CAN device.

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Acked-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/can/dev.c