OSDN Git Service

mac80211: don't warn about CW params when not using them
authorBrian Norris <briannorris@chromium.org>
Thu, 18 Jul 2019 01:57:12 +0000 (18:57 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 25 Aug 2019 08:51:23 +0000 (10:51 +0200)
commit760b12a7262b0b32e2da4b2f5b21dce52053846b
treec2cdc62ecaaa8c5fd6b301107382cb6aec10fe3c
parent2b9ac213b632b3f275728eb68a9a9e1c160aabf8
mac80211: don't warn about CW params when not using them

[ Upstream commit d2b3fe42bc629c2d4002f652b3abdfb2e72991c7 ]

ieee80211_set_wmm_default() normally sets up the initial CW min/max for
each queue, except that it skips doing this if the driver doesn't
support ->conf_tx. We still end up calling drv_conf_tx() in some cases
(e.g., ieee80211_reconfig()), which also still won't do anything
useful...except it complains here about the invalid CW parameters.

Let's just skip the WARN if we weren't going to do anything useful with
the parameters.

Signed-off-by: Brian Norris <briannorris@chromium.org>
Link: https://lore.kernel.org/r/20190718015712.197499-1-briannorris@chromium.org
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/mac80211/driver-ops.c