OSDN Git Service

KVM: use after free in kvm_ioctl_create_device()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 30 Nov 2016 19:21:05 +0000 (22:21 +0300)
committerRadim Krčmář <rkrcmar@redhat.com>
Thu, 1 Dec 2016 15:10:50 +0000 (16:10 +0100)
commita0f1d21c1ccb1da66629627a74059dd7f5ac9c61
tree50974c8b8a1564bd35353043f3202510f7cec4de
parent0f4828a1da3342be81e812b28fbcf29261146d25
KVM: use after free in kvm_ioctl_create_device()

We should move the ops->destroy(dev) after the list_del(&dev->vm_node)
so that we don't use "dev" after freeing it.

Fixes: a28ebea2adc4 ("KVM: Protect device ops->create and list_add with kvm->lock")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
virt/kvm/kvm_main.c