OSDN Git Service

(root) / android-x86 / kernel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 2b86158) | patch
fs: Fix S_NOSEC handling
authorJan Kara <jack@suse.cz>
Thu, 21 May 2015 14:05:52 +0000 (16:05 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Jul 2015 16:45:42 +0000 (09:45 -0700)
commita334bad321e85f66d4ee3149aa68d59e5e644234
treec897c6d5f528c1aa1f24322a6ddf5b6124dc65e9tree | snapshot
parent2b86158378cba6c7fc2ee45d83cc3f218520d9f2commit | diff
fs: Fix S_NOSEC handling

commit 2426f3910069ed47c0cc58559a6d088af7920201 upstream.

file_remove_suid() could mistakenly set S_NOSEC inode bit when root was
modifying the file. As a result following writes to the file by ordinary
user would avoid clearing suid or sgid bits.

Fix the bug by checking actual mode bits before setting S_NOSEC.

Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/inode.c diff | blob | history
kernel
About OSDN
Find Software
Develop Software
Help