OSDN Git Service

CIFS: cifs_read_allocate_pages: don't iterate through whole page array on ENOMEM
authorRoberto Bergantinos Corpas <rbergant@redhat.com>
Tue, 28 May 2019 07:38:14 +0000 (09:38 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Jun 2019 10:22:43 +0000 (12:22 +0200)
commitdf2b6af4148fde53f0579ae1156160628d049a12
treec43ed2550d233eae369627fd132e58268a49201b
parentcf07331c8827c9e9e0b4274c9b60204c18592241
CIFS: cifs_read_allocate_pages: don't iterate through whole page array on ENOMEM

commit 31fad7d41e73731f05b8053d17078638cf850fa6 upstream.

 In cifs_read_allocate_pages, in case of ENOMEM, we go through
whole rdata->pages array but we have failed the allocation before
nr_pages, therefore we may end up calling put_page with NULL
pointer, causing oops

Signed-off-by: Roberto Bergantinos Corpas <rbergant@redhat.com>
Acked-by: Pavel Shilovsky <pshilov@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
CC: Stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/cifs/file.c