OSDN Git Service

can: c_can: fix an interrupt thrash issue with c_can driver
authorAnilKumar Ch <anilkumar@ti.com>
Wed, 23 May 2012 12:15:10 +0000 (17:45 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 17 Jun 2012 18:23:11 +0000 (11:23 -0700)
commite3c8262d150883d1dbd9b5cbb03d6cca7cf68cad
treee0a09eeb19204c5a32db809decefee3db4e52f12
parent2f99a5afd1a9752cf69c3ee006f3a9c1bb74013a
can: c_can: fix an interrupt thrash issue with c_can driver

commit 148c87c89e1a8863d3d965179f3ab1a06490569e upstream.

This patch fixes an interrupt thrash issue with c_can driver.

In c_can_isr() function interrupts are disabled and enabled only in
c_can_poll() function. c_can_isr() & c_can_poll() both read the
irqstatus flag. However, irqstatus is always read as 0 in c_can_poll()
because all C_CAN interrupts are disabled in c_can_isr(). This causes
all interrupts to be re-enabled in c_can_poll() which in turn causes
another interrupt since the event is not really handled. This keeps
happening causing a flood of interrupts.

To fix this, read the irqstatus register in isr and use the same cached
value in the poll function.

Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
Acked-by: Wolfgang Grandegger <wg@grandegger.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/can/c_can/c_can.c
drivers/net/can/c_can/c_can.h