OSDN Git Service

USB: fix linked-list corruption in rh_call_control()
authorAlan Stern <stern@rowland.harvard.edu>
Fri, 24 Mar 2017 17:38:28 +0000 (13:38 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 8 Apr 2017 07:53:31 +0000 (09:53 +0200)
commiteac3ab3e69151c21a0a71ec8711600022cc12fa3
tree4c11409097bd1765f0f9537b4d8867bcc586be81
parent0a1757cfa5ba3b46f6ee7a74ddb7a5c0bd5d7c2f
USB: fix linked-list corruption in rh_call_control()

commit 1633682053a7ee8058e10c76722b9b28e97fb73f upstream.

Using KASAN, Dmitry found a bug in the rh_call_control() routine: If
buffer allocation fails, the routine returns immediately without
unlinking its URB from the control endpoint, eventually leading to
linked-list corruption.

This patch fixes the problem by jumping to the end of the routine
(where the URB is unlinked) when an allocation failure occurs.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Reported-and-tested-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/hcd.c