OSDN Git Service

media: stv090x: fix double free on state object
authorColin Ian King <colin.king@canonical.com>
Tue, 11 Jun 2019 15:38:12 +0000 (11:38 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Fri, 21 Jun 2019 19:33:07 +0000 (15:33 -0400)
commitefe8b031d8eb92ef8c68efd05ca5c11a1050619a
tree9153e9b73ae146b1ee05132e78fa66dfa1007838
parent575f60312b3c5036385e95f61737da5a9e72f0ad
media: stv090x: fix double free on state object

There two callers of stv090x_setup_compound manage the allocation and
freeing if state there is an error condition from stv090x_setup_compound.
Currently function stv090x_setup_compound also frees the state object
too, leading to a double free in the callers of this function.  Fix
this by removing the extraneous free in stv090x_setup_compound and just
leave the callers handle the allocation/free'ing.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/dvb-frontends/stv090x.c