OSDN Git Service

ALSA: line6: Fix memory leak at line6_init_pcm() error path
authorTakashi Iwai <tiwai@suse.de>
Wed, 21 Aug 2019 18:00:02 +0000 (20:00 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Sep 2019 08:19:46 +0000 (10:19 +0200)
commitf595a1260357480136375b19ca7cb8f494b57ad9
treea2d38f14b428df214431731b2ea1011c5f24fb3f
parentfda2092976b38e238b338bf717744faab89c6883
ALSA: line6: Fix memory leak at line6_init_pcm() error path

commit 1bc8d18c75fef3b478dbdfef722aae09e2a9fde7 upstream.

I forgot to release the allocated object at the early error path in
line6_init_pcm().  For addressing it, slightly shuffle the code so
that the PCM destructor (pcm->private_free) is assigned properly
before all error paths.

Fixes: 3450121997ce ("ALSA: line6: Fix write on zero-sized buffer")
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/usb/line6/pcm.c