OSDN Git Service

fbdev/omapfb: fix omapfb_memory_read infoleak
authorTomi Valkeinen <tomi.valkeinen@ti.com>
Wed, 26 Sep 2018 16:11:22 +0000 (18:11 +0200)
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Wed, 26 Sep 2018 16:11:22 +0000 (18:11 +0200)
commit1bafcbf59fed92af58955024452f45430d3898c5
treeee45bb8b910f281248c4528ddc290e75e4253241
parentd85536cde91fcfed6fb8d983783bd2b92c843939
fbdev/omapfb: fix omapfb_memory_read infoleak

OMAPFB_MEMORY_READ ioctl reads pixels from the LCD's memory and copies
them to a userspace buffer. The code has two issues:

- The user provided width and height could be large enough to overflow
  the calculations
- The copy_to_user() can copy uninitialized memory to the userspace,
  which might contain sensitive kernel information.

Fix these by limiting the width & height parameters, and only copying
the amount of data that we actually received from the LCD.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reported-by: Jann Horn <jannh@google.com>
Cc: stable@vger.kernel.org
Cc: security@kernel.org
Cc: Will Deacon <will.deacon@arm.com>
Cc: Jann Horn <jannh@google.com>
Cc: Tony Lindgren <tony@atomide.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c