OSDN Git Service

drm/vc4: Account for interrupts in flight
authorStefan Schake <stschake@gmail.com>
Fri, 10 Nov 2017 01:05:06 +0000 (02:05 +0100)
committerEric Anholt <eric@anholt.net>
Tue, 14 Nov 2017 00:40:15 +0000 (16:40 -0800)
commit253696ccd613fbdaa5aba1de44c461a058e0a114
tree284c09fc503a71016f85a609c5a226f6b50d0d71
parent44419ce7d77e03692ed8fe799688d8dc43f9266e
drm/vc4: Account for interrupts in flight

Synchronously disable the IRQ to make the following cancel_work_sync
invocation effective.

An interrupt in flight could enqueue further overflow mem work. As we
free the binner BO immediately following vc4_irq_uninstall this caused
a NULL pointer dereference in the work callback vc4_overflow_mem_work.

Link: https://github.com/anholt/linux/issues/114
Signed-off-by: Stefan Schake <stschake@gmail.com>
Fixes: d5b1a78a772f ("drm/vc4: Add support for drawing 3D frames.")
Signed-off-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Eric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/1510275907-993-2-git-send-email-stschake@gmail.com
drivers/gpu/drm/vc4/vc4_irq.c