OSDN Git Service

igb: close/suspend race in netif_device_detach
authorTodd Fujinaka <todd.fujinaka@intel.com>
Tue, 15 Nov 2016 16:54:26 +0000 (08:54 -0800)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Fri, 6 Jan 2017 10:18:51 +0000 (02:18 -0800)
commit9474933caf21a4cb5147223dca1551f527aaac36
treeeb39db9621cd75d30f033e25bc23d38465df6997
parent69b97cf6dbce7403845a28bbc75d57f5be7b12ac
igb: close/suspend race in netif_device_detach

Similar to ixgbe, when an interface is part of a namespace it is
possible that igb_close() may be called while __igb_shutdown() is
running which ends up in a double free WARN and/or a BUG in
free_msi_irqs().

Extend the rtnl_lock() to protect the call to netif_device_detach() and
igb_clear_interrupt_scheme() in __igb_shutdown() and check for
netif_device_present() to avoid calling igb_clear_interrupt_scheme() a
second time in igb_close().

Also extend the rtnl lock in igb_resume() to netif_device_attach().

Signed-off-by: Todd Fujinaka <todd.fujinaka@intel.com>
Acked-by: Alexander Duyck <alexander.h.duyck@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/igb/igb_main.c