OSDN Git Service

drm/vc4: Move IRQ enable to PM path
authorStefan Schake <stschake@gmail.com>
Fri, 29 Dec 2017 16:05:43 +0000 (17:05 +0100)
committerEric Anholt <eric@anholt.net>
Wed, 3 Jan 2018 23:56:03 +0000 (15:56 -0800)
commitce9caf2f79a5aa170a4b6456a03db639eed9c988
tree5204a4d4e5ca8c02fc3c6a4cf608f1c1e2896f85
parente7cdf5c82f1773c3386b93bbcf13b9bfff29fa31
drm/vc4: Move IRQ enable to PM path

We were calling enable_irq on bind, where it was already enabled previously
by the IRQ helper. Additionally, dev->irq is not set correctly until after
postinstall and so was always zero here, triggering a warning in 4.15.
Fix both by moving the enable to the power management resume path, where we
know there was a previous disable invocation during suspend.

Fixes: 253696ccd613 ("drm/vc4: Account for interrupts in flight")
Signed-off-by: Stefan Schake <stschake@gmail.com>
Signed-off-by: Eric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/1514563543-32511-1-git-send-email-stschake@gmail.com
Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
drivers/gpu/drm/vc4/vc4_irq.c
drivers/gpu/drm/vc4/vc4_v3d.c