OSDN Git Service

android-x86/packages-apps-Contacts.git
14 years agoMake QuickContactActivity look at the sourceBounds property of Intent as well.
Joe Onorato [Thu, 3 Dec 2009 04:17:19 +0000 (20:17 -0800)]
Make QuickContactActivity look at the sourceBounds property of Intent as well.

14 years agoMake Home contacts shortcut bring up the quick contact window.
Romain Guy [Thu, 3 Dec 2009 03:55:14 +0000 (19:55 -0800)]
Make Home contacts shortcut bring up the quick contact window.

Change-Id: I9cb20b9c7d77dc29a08019554f746089665403f5

14 years agoImport revised translations. DO NOT MERGE
Eric Fischer [Mon, 30 Nov 2009 19:35:32 +0000 (11:35 -0800)]
Import revised translations.  DO NOT MERGE

14 years agoImport revised translations. DO NOT MERGE
Eric Fischer [Sat, 14 Nov 2009 01:20:47 +0000 (17:20 -0800)]
Import revised translations.  DO NOT MERGE

Approver: jerryw

14 years agoImport revised translations. DO NOT MERGE
Eric Fischer [Fri, 13 Nov 2009 03:47:23 +0000 (19:47 -0800)]
Import revised translations.  DO NOT MERGE

Approver: jerryw

14 years agoAdd instrumentation definition for ContactsLaunchPerformance.
Brett Chabot [Thu, 12 Nov 2009 19:48:30 +0000 (11:48 -0800)]
Add instrumentation definition for ContactsLaunchPerformance.

Change-Id: I5f0d8ddf59184d8b80a18d46ba246d5437f4e0d2

14 years agoRevert "Use scan mode introduced in VCardParser."
Daisuke Miyakawa [Wed, 11 Nov 2009 07:42:49 +0000 (16:42 +0900)]
Revert "Use scan mode introduced in VCardParser."

This reverts commit 51f6f77ef0fb1e16be9d19009252ced701e19f75.

Found that the change above is NOT related to the issue 2245363 and break the build.

Dr.NO: Hiroshi

Internal issue number: 2245363

14 years agoMerge change I428a6432 into eclair
Android (Google) Code Review [Wed, 11 Nov 2009 07:03:01 +0000 (23:03 -0800)]
Merge change I428a6432 into eclair

* changes:
  Use scan mode introduced in VCardParser.

14 years agoUse scan mode introduced in VCardParser.
Daisuke Miyakawa [Tue, 10 Nov 2009 22:16:18 +0000 (07:16 +0900)]
Use scan mode introduced in VCardParser.

This change must be merged after the change I5d30aa18 being submitted.

Internal issue number: 2245363

Dr.NO: Hiroshi

14 years agoFix bug 2239212 "Dial pad has no sound"
Jean-Michel Trivi [Tue, 10 Nov 2009 21:00:45 +0000 (13:00 -0800)]
Fix bug 2239212 "Dial pad has no sound"
The DTMF stream volume is tied to the in-call volume. In the dialer
outside of a call, the user has no way to change the touch tone
volume. If (s)he lowered the incall volume all the way down,
the user will usually complain that the dial pad has no sound,
and if they maxed it out, they'll complain it's too loud.
 This change causes the tones to use the media volume, outside of
a call only, and to change the media volume when the user presses
the hardware volume keys.
This gives us both the advantage of keeping the incall behavior consistent
with the existing behavior (AFAIK there are no complaints regarding
in call DTMF volume), but offers the user control over the volume
in the dialer before/after a call.

14 years agoAdded VIBRATE permission to allow haptic feedback.
Nicolas Catania [Fri, 6 Nov 2009 21:19:43 +0000 (13:19 -0800)]
Added VIBRATE permission to allow haptic feedback.

Bug:2244573

14 years agoAvoid offering "share" for restricted-only contacts.
Jeff Sharkey [Tue, 3 Nov 2009 20:57:16 +0000 (12:57 -0800)]
Avoid offering "share" for restricted-only contacts.

Fixes http://b/2223256

14 years agoAvoid NPE in isEmpty() when no EditFields defined.
Jeff Sharkey [Fri, 30 Oct 2009 20:41:53 +0000 (13:41 -0700)]
Avoid NPE in isEmpty() when no EditFields defined.

Fixes http://b/2226220

14 years agoImport revised translations. DO NOT MERGE
Eric Fischer [Fri, 30 Oct 2009 17:04:58 +0000 (10:04 -0700)]
Import revised translations.  DO NOT MERGE

14 years agoMerge change I994fc479 into eclair
Android (Google) Code Review [Thu, 29 Oct 2009 23:59:17 +0000 (19:59 -0400)]
Merge change I994fc479 into eclair

* changes:
  Send RESULT_CANCELED when missing, return legacy Uris.

14 years agoSend RESULT_CANCELED when missing, return legacy Uris.
Jeff Sharkey [Wed, 28 Oct 2009 00:22:53 +0000 (17:22 -0700)]
Send RESULT_CANCELED when missing, return legacy Uris.

When no contact was persisted (for example a save that has
been trimmed to a no-op) we return RESULT_CANCELED.

When an Intent like ACTION_INSERT requests a legacy Uri we
correctly return a legacy Uri instead of lookup-style.

Fixes http://b/2219805 and http://b/2219813

14 years agoWhen reparenting, prefer GROUP_ROW_ID but allow fallback.
Jeff Sharkey [Wed, 28 Oct 2009 21:20:42 +0000 (14:20 -0700)]
When reparenting, prefer GROUP_ROW_ID but allow fallback.

When a GROUP_SOURCE_ID is the only value provided, usually
while a sync is still going on, allow it to remain when a
valid ROW_ID is present.  Fixes http://b/2222283

14 years agoFix bug http://b/issue?id=2208177
Evan Millar [Thu, 29 Oct 2009 22:22:37 +0000 (15:22 -0700)]
Fix bug http://b/issue?id=2208177

Use a subclass of ListView that explicitly requests focus after the
first time it is layed out.

14 years agoMerge change I2dc2bdef into eclair
Android (Google) Code Review [Thu, 29 Oct 2009 15:12:24 +0000 (11:12 -0400)]
Merge change I2dc2bdef into eclair

* changes:
  Final UI tweaks for the WGVA dialer.

14 years agoImport revised translations. DO NOT MERGE
Eric Fischer [Thu, 29 Oct 2009 04:18:03 +0000 (21:18 -0700)]
Import revised translations.  DO NOT MERGE

14 years agoFinal UI tweaks for the WGVA dialer.
Nicolas Catania [Wed, 28 Oct 2009 22:11:39 +0000 (15:11 -0700)]
Final UI tweaks for the WGVA dialer.

Added a bit more space around the torpedo. (VM/dial/BS)
Tested with wvga800 and wvga850.
wvga800 match perfectly the designer's mocks.
wvga854 the torpedo is about 2px lower than it should but
it is best I can do to make the long layout work.

Bug:2198341

14 years agoMerge change I3d0980fd into eclair
Android (Google) Code Review [Wed, 21 Oct 2009 20:33:58 +0000 (16:33 -0400)]
Merge change I3d0980fd into eclair

* changes:
  Fix hardcoded px dimensions in "dialpad chooser" UI.

14 years agoImport revised translations. DO NOT MERGE
Eric Fischer [Wed, 21 Oct 2009 17:43:57 +0000 (10:43 -0700)]
Import revised translations.  DO NOT MERGE

Approver: jerryw

14 years agoMerge change I7a26b27a into eclair
Android (Google) Code Review [Wed, 21 Oct 2009 14:32:34 +0000 (10:32 -0400)]
Merge change I7a26b27a into eclair

* changes:
  Fixed the contact's dialer layout.

14 years agoMerge change Ic19d66e9 into eclair
Android (Google) Code Review [Wed, 21 Oct 2009 14:32:02 +0000 (10:32 -0400)]
Merge change Ic19d66e9 into eclair

* changes:
  Changed the dialed numbers' foreground to be white instead of black.[do not merge]

14 years agoChanged the dialed numbers' foreground to be white instead of black.[do not merge]
Nicolas Catania [Tue, 13 Oct 2009 16:59:54 +0000 (09:59 -0700)]
Changed the dialed numbers' foreground to be white instead of black.[do not merge]

Bug:2184896

14 years agoFixed the contact's dialer layout.
Nicolas Catania [Tue, 20 Oct 2009 19:36:32 +0000 (12:36 -0700)]
Fixed the contact's dialer layout.

Currently the bottom row is clipped on WVGA-800.
Changes were made to fix the emergency dialer
that needed to be applied to the contact dialer.

Now, the contact dialer uses the same ButtonGridLayout
class which aligns the button at the bottom of the view.
This way we can control the spacing between the last row and
the 'torpedo' accurately.
The rest of the white space is distributed amongst the element
using layout_weight="1".

Tested on VGA, WVGA-854, WVGA-800

Bug:2198341

14 years agoFix hardcoded px dimensions in "dialpad chooser" UI.
David Brown [Tue, 20 Oct 2009 19:09:17 +0000 (12:09 -0700)]
Fix hardcoded px dimensions in "dialpad chooser" UI.

In the "dialpad chooser" UI (which comes up if you launch the Dialer while
a call is already in progress) the 3 items are too tightly spaced on WVGA
devices.  Fixed by changing the relevant dimensions from px to dp.

BUG=2185527
TESTED: got into the "chooser" state on a WVGA phone, confirmed the items
        are now sized correctly.

14 years agoMove internal change 29743 into eclair from eclair-mr2
Evan Millar [Mon, 12 Oct 2009 22:09:21 +0000 (15:09 -0700)]
Move internal change 29743 into eclair from eclair-mr2

Fixes http://b/viewIssue?id=2176887

Don't show the keyboard when you enter EditContactActivity

14 years agoAllow TwelveKeyDialer call button to send empty flash for CDMA
Paul Berman [Fri, 9 Oct 2009 16:04:10 +0000 (12:04 -0400)]
Allow TwelveKeyDialer call button to send empty flash for CDMA

Currently the TwelveKeyDialer does not allow the user to press the green
call button if the dial text is empty. However, in CDMA when we place a
3-way call in some network infrastructures, you need to send an empty
Flash command to the network before adding the call. The user is accustomed to
pressing the call button in order to do this. Therefore here we make the
changes in TwelveKeyDialer.java required to handle that keypress and send the
blank flash.

Bug: 2179060
Change-Id: Ib8d05459cac708f9dc216412103c1a324d747ecb

14 years agoFix off by one bug in favorites list call button.
Evan Millar [Wed, 14 Oct 2009 23:23:37 +0000 (16:23 -0700)]
Fix off by one bug in favorites list call button.

bc_triaged bug: http://b/issue?id=2179352
Dr. No: Tim Sullivan

14 years agoRemove vertical and colored bars from editors.
Jeff Sharkey [Tue, 13 Oct 2009 23:27:09 +0000 (16:27 -0700)]
Remove vertical and colored bars from editors.

Fixes http://b/2186076

14 years agoMerge change I43723de2 into eclair
Android (Google) Code Review [Mon, 12 Oct 2009 20:39:28 +0000 (16:39 -0400)]
Merge change I43723de2 into eclair

* changes:
  Avoid setting checked state when dismissing FastTrack.

14 years agoMerge change I1cde5dd0 into eclair
Android (Google) Code Review [Mon, 12 Oct 2009 20:34:46 +0000 (16:34 -0400)]
Merge change I1cde5dd0 into eclair

* changes:
  In landscape mode, set the type of digit area to PHONE[do not merge].

14 years agoShow phones and email addresses for read-only contacts.
Jeff Hamilton [Sun, 11 Oct 2009 06:17:48 +0000 (01:17 -0500)]
Show phones and email addresses for read-only contacts.

Bug: 2180041
Change-Id: I686e5413bb3de4c9373da177673c485581c87bb9

14 years agoIn landscape mode, set the type of digit area to PHONE[do not merge].
Nicolas Catania [Fri, 9 Oct 2009 18:09:45 +0000 (11:09 -0700)]
In landscape mode, set the type of digit area to PHONE[do not merge].

Backport from Ieb30191ace8a0d62adec4feaca8f81df7ac4e71b

Previously we blindely set the EditText to NULL to prevent the IME
keyboard to pop up in portrait mode. The issue is that in landscape
mode, the keyboard is not in numlock mode which is a pb on devices
where the 1st line is not made of numbers.

Bug: 2180808

14 years agoAvoid setting checked state when dismissing FastTrack.
Jeff Sharkey [Mon, 12 Oct 2009 17:50:08 +0000 (10:50 -0700)]
Avoid setting checked state when dismissing FastTrack.

Fixes http://b/2180222

14 years agoImport revised translations. DO NOT MERGE
Eric Fischer [Fri, 9 Oct 2009 22:36:01 +0000 (15:36 -0700)]
Import revised translations.  DO NOT MERGE

Approver: jerryw

14 years agoClear bitmap cache in onResume() to make sure photos are fresh.
Evan Millar [Fri, 9 Oct 2009 17:13:32 +0000 (10:13 -0700)]
Clear bitmap cache in onResume() to make sure photos are fresh.

bc_triaged bug: http://b/issue?id=2177238
Dr. No: Tim Sullivan

14 years agoMerge change I700622d9 into eclair
Android (Google) Code Review [Fri, 9 Oct 2009 04:47:19 +0000 (00:47 -0400)]
Merge change I700622d9 into eclair

* changes:
  Fix up photo editing, and few other tweaks to contact editing.

14 years agoFix up photo editing, and few other tweaks to contact editing.
Jeff Hamilton [Fri, 9 Oct 2009 00:46:26 +0000 (19:46 -0500)]
Fix up photo editing, and few other tweaks to contact editing.

- When tapping a photo you're given a choice to replace, remove, or use as primary
- Fix an issue where the secondary group would show when it shouldn't
- Tweak the size of the color bar per Chris
- Format phone numbers when typing them
- Fix a display issue with contacts that didn't fill the height of the screen
- If a contact is read-only and doesn't have a photo don't offer the option to add one

Bugs: 2163109 & 2163519
Change-Id: I700622d9dfdbcaa81e5b577fd5b2a38d708374aa

14 years agoHandle external sources that request both social and detail.
Jeff Sharkey [Thu, 8 Oct 2009 23:57:06 +0000 (16:57 -0700)]
Handle external sources that request both social and detail.

When a source requests social summary, allow them to still
provide a fallback detail value when no social summary is
available.  (Otherwise the data row would be invisible.)

Partially fixes http://b/2176892

14 years agoNew infobar background assets.
Jeff Sharkey [Thu, 8 Oct 2009 23:39:33 +0000 (16:39 -0700)]
New infobar background assets.

Fixes http://b/2153296

14 years agoMerge change I3ee009e6 into eclair
Android (Google) Code Review [Thu, 8 Oct 2009 22:07:52 +0000 (18:07 -0400)]
Merge change I3ee009e6 into eclair

* changes:
  Make shortcut icons adjust to hdpi display.

14 years agoMake shortcut icons adjust to hdpi display.
Evan Millar [Thu, 8 Oct 2009 21:50:27 +0000 (14:50 -0700)]
Make shortcut icons adjust to hdpi display.

bc_triaged bug: http://b/issue?id=2171333

Change-Id: I3ee009e6469c0472f21a1cf82875a8419c39f59a

14 years agoam 906af3fb: (-s ours) Import revised translations. DO NOT MERGE
Eric Fischer [Thu, 8 Oct 2009 21:59:34 +0000 (14:59 -0700)]
am 906af3fb: (-s ours) Import revised translations.  DO NOT MERGE

Merge commit '906af3fbedb9034c84fd18139fa16d3f542d1f67' into eclair

* commit '906af3fbedb9034c84fd18139fa16d3f542d1f67':
  Import revised translations.  DO NOT MERGE

14 years agoTrim edit fields that don't contain printable values.
Jeff Sharkey [Thu, 8 Oct 2009 18:13:47 +0000 (11:13 -0700)]
Trim edit fields that don't contain printable values.

When persisting edit changes, trim data rows that have no
printable characters.  Also wrote unit tests for new method
and building of IM intents to check Uri escaping.

Fixes http://b/2173811

14 years agoAllow omission of RES_PACKAGE for status attributions.
Jeff Sharkey [Thu, 8 Oct 2009 17:22:30 +0000 (10:22 -0700)]
Allow omission of RES_PACKAGE for status attributions.

FastTrack was being overly cautious about attribution labels
coming from third-party sources.  When no RES_PACKAGE is
defined, we now fall back to using the local package instead
of completely dropping the attribution line.

Fixes http://b/2175531

14 years agoHandle IM entries with missing protocol field.
Evan Millar [Thu, 8 Oct 2009 17:24:12 +0000 (10:24 -0700)]
Handle IM entries with missing protocol field.

Fix bc_triaged bug http://b/issue?id=2174637
Dr. No approval from Tim Sullivan

Change-Id: Ia91c39e91a54e3c58ec94d1c5064a9572519f036

14 years agoOmit attribution icon in medium FastTrack.
Jeff Sharkey [Thu, 8 Oct 2009 17:29:22 +0000 (10:29 -0700)]
Omit attribution icon in medium FastTrack.

Fixes http://b/2175531

14 years agoMerge change I652a8d7b into eclair
Android (Google) Code Review [Thu, 8 Oct 2009 17:07:14 +0000 (13:07 -0400)]
Merge change I652a8d7b into eclair

* changes:
  Fix ImportVCardActivity so that NPE will never occur during import.

14 years agoIgnore transient rows during re-parenting.
Jeff Sharkey [Wed, 7 Oct 2009 20:52:48 +0000 (13:52 -0700)]
Ignore transient rows during re-parenting.

When editing, we create template rows such as StructuredName
and Photo, which may be trimmed before persisting if they
remain empty.  When a background change occurs and we need
to re-parent the users changes, we didn't handle this
special case, and treated these trimmed rows as inserts,
which triggered the reported missing MIME-type exception.

This change watches for "transient" rows that didn't exist
previously, but were inserted and then deleted during the
process of editing.  When encountered, they are ignored
during re-parenting, instead of turning into inserts.

Added a unit test to verify correct behavior, and also wrote
values-level verification for the existing unit tests.

Fixes http://b/2167925

14 years agoIncrement tries as we reparent to avoid looping.
Jeff Sharkey [Wed, 7 Oct 2009 20:53:39 +0000 (13:53 -0700)]
Increment tries as we reparent to avoid looping.

Fixes http://b/2173452

14 years agoMerge change Ibc1b1f7d into eclair
Android (Google) Code Review [Thu, 8 Oct 2009 02:19:24 +0000 (22:19 -0400)]
Merge change Ibc1b1f7d into eclair

* changes:
  Follow up changes from review of Ib2afc992.

14 years agoFix ImportVCardActivity so that NPE will never occur during import.
Daisuke Miyakawa [Fri, 2 Oct 2009 23:48:06 +0000 (16:48 -0700)]
Fix ImportVCardActivity so that NPE will never occur during import.

The NPE occurs only when the importing thread exits before the progress dialog is shown.
In theory (and in practice), this is rare, but anyway, this is a bug.

-----IMPORTANT-----

This change is cherry-picked from the latest build to the eclair.
Please see the description in the issue bellow.

-------------------

Internal issue number: 2164280

14 years ago[Issue 2174171] Fixing Join Contact UI title.
Dmitri Plotnikov [Thu, 8 Oct 2009 00:07:03 +0000 (17:07 -0700)]
[Issue 2174171] Fixing Join Contact UI title.

The title should read: "Select the contact you want to join with John Doe"

Change-Id: Iec1f41ce97e251635048f91020410cc1981cffbb

14 years agoFix clicking on the total contacts header item.
Neel Parekh [Wed, 7 Oct 2009 20:52:38 +0000 (13:52 -0700)]
Fix clicking on the total contacts header item.

Bug: 2160378

14 years agoFix bc_triaged http://b/issue?id=2155790
Evan Millar [Wed, 7 Oct 2009 22:15:05 +0000 (15:15 -0700)]
Fix bc_triaged http://b/issue?id=2155790

Dr.No approval from Tim Sullivan

Change-Id: I893d40499303accbf675c7e7e2e5873b4800b052

14 years agoMerge change I89190b8b into eclair
Android (Google) Code Review [Wed, 7 Oct 2009 23:48:00 +0000 (19:48 -0400)]
Merge change I89190b8b into eclair

* changes:
  New photo frame in LARGE QuickCotnact window

14 years agoMerge change Ia961aa60 into eclair
Android (Google) Code Review [Wed, 7 Oct 2009 23:24:15 +0000 (19:24 -0400)]
Merge change Ia961aa60 into eclair

* changes:
  Contacts: fixed custom label handling in GenericEditorView.

14 years agoNew photo frame in LARGE QuickCotnact window
Evan Millar [Wed, 7 Oct 2009 22:36:36 +0000 (15:36 -0700)]
New photo frame in LARGE QuickCotnact window

bc_triaged bug: http://b/issue?id=2170892

Dr.No: Tim Sullivan

Change-Id: I89190b8bf0ba019645c3beb2fe2b73decca0c948

14 years agoMerge change I362ca992 into eclair
Android (Google) Code Review [Wed, 7 Oct 2009 21:46:42 +0000 (17:46 -0400)]
Merge change I362ca992 into eclair

* changes:
  Show message if contact has no data to show.

14 years agoContacts: fixed custom label handling in GenericEditorView.
Tadashi G. Takaoka [Wed, 7 Oct 2009 21:28:44 +0000 (14:28 -0700)]
Contacts: fixed custom label handling in GenericEditorView.

Internal Bug: http://b/2173080

14 years agoFollow up changes from review of Ib2afc992.
Jeff Hamilton [Wed, 7 Oct 2009 21:21:20 +0000 (16:21 -0500)]
Follow up changes from review of Ib2afc992.

- Fixed some minor issues in the editor comparator
- Fixed some issues with phone local contacts

Change-Id: Ibc1b1f7d23aa33f899eaa4c0a21fde59284b6f4a

14 years agoUpdates to the edit contact UI.
Jeff Hamilton [Wed, 7 Oct 2009 09:40:27 +0000 (04:40 -0500)]
Updates to the edit contact UI.

- Updated account colors and color layout
- Updated display in read-only mode
- Clearer strings to identify accounts
- Sort the contacts to edit so read-only ones
  always are at the bottom.

Fixes 2163539 and a good portion of 2163519.

Change-Id: Ib2afc992a8623f2a253d2a52a0b5c50ee866e5d8

14 years agoShow message if contact has no data to show.
Evan Millar [Wed, 7 Oct 2009 18:47:35 +0000 (11:47 -0700)]
Show message if contact has no data to show.

Fixes bc_triaged bug http://b/issue?id=2170901

Dr.NO approval from Tim Sullivan

Change-Id: I362ca992c3a97792fbc2d76fc3bcf4178bfefcd5

14 years agoMerge change Ice23b740 into eclair
Android (Google) Code Review [Wed, 7 Oct 2009 18:36:48 +0000 (14:36 -0400)]
Merge change Ice23b740 into eclair

* changes:
  Import revised translations.   DO NOT MERGE

14 years agoOne more last minute string.
Jeff Hamilton [Wed, 7 Oct 2009 03:12:02 +0000 (22:12 -0500)]
One more last minute string.

Change-Id: Ifc0220ae3af63b0d97b2ae5ab6963108119ded67

14 years agoCheckpoint new strings for translation.
Jeff Hamilton [Tue, 6 Oct 2009 03:39:45 +0000 (22:39 -0500)]
Checkpoint new strings for translation.

Change-Id: Iba348222094cc40bd9657fea35396e26b3b7c779

14 years agoPart of Bug 2163087 fix - NPE if the main thread is removing the reference.
Costin Manolache [Wed, 7 Oct 2009 00:28:39 +0000 (17:28 -0700)]
Part of Bug 2163087 fix - NPE if the main thread is removing the reference.

14 years ago[Issue 2166752] Properly displaying phone numbers containing letters
Dmitri Plotnikov [Wed, 7 Oct 2009 00:30:58 +0000 (17:30 -0700)]
[Issue 2166752] Properly displaying phone numbers containing letters

Change-Id: Ia2d815925d672d46f0269e926438c3dc8739006b

14 years agoImport revised translations. DO NOT MERGE
Eric Fischer [Tue, 6 Oct 2009 23:52:42 +0000 (16:52 -0700)]
Import revised translations.   DO NOT MERGE

Approver: jerryw

14 years agoMerge change I9a8a3d9d into eclair
Android (Google) Code Review [Tue, 6 Oct 2009 23:37:33 +0000 (19:37 -0400)]
Merge change I9a8a3d9d into eclair

* changes:
  Fix FastTrack recycling consistency issues, shadows.

14 years agoDisplay empty text when there are no contacts visible.
Evan Millar [Tue, 6 Oct 2009 20:34:15 +0000 (13:34 -0700)]
Display empty text when there are no contacts visible.

-bc triaged bug: http://b/issue?id=2162934

Change-Id: I331918d70282bb2e123da22bc940168c41406326

14 years agoFix FastTrack recycling consistency issues, shadows.
Jeff Sharkey [Mon, 5 Oct 2009 18:15:57 +0000 (11:15 -0700)]
Fix FastTrack recycling consistency issues, shadows.

When FastTrack is displayed and a configuration change
occurs, we tear down and recreate the host Activity, but in
the process moveTaskToBack(), which means the next trigger
will show a stale track and rectangle.

This change dismisses the track in onPause() to reduce risk
of bringing back a stale track.  It also introduces a new
mDismissed flag to catch any race conditions where the track
is dismissed before showInternal() is called.

When requested a show() and already visible, instead of
ignoring, I'm calling dismissInternal() to replace the track
with the updated request.  I'm also using query tokens to
ignore query results from stale show() requests.

This change also fixes padding in the large FT format when
no photo is available.  It also fixes shadow behind track
to remove sharp vertical edges visible during animations.

Also clears "make default" checkbox between recycles and
fixes an issue where icons for preferred apps remained after
the user selects "always use" from intent disambig list.

Fixes http://b/2163611 and http://b/2164119

14 years agoMerge change I23d84a63 into eclair
Android (Google) Code Review [Tue, 6 Oct 2009 21:21:22 +0000 (17:21 -0400)]
Merge change I23d84a63 into eclair

* changes:
  Include Google Talk presence, even when missing Im rows.

14 years agoMerge change I740cfdad into eclair
Android (Google) Code Review [Tue, 6 Oct 2009 20:49:13 +0000 (16:49 -0400)]
Merge change I740cfdad into eclair

* changes:
  Use a thread pool to fetch images. Bug 2163087.

14 years agoInclude Google Talk presence, even when missing Im rows.
Jeff Sharkey [Fri, 2 Oct 2009 04:32:19 +0000 (21:32 -0700)]
Include Google Talk presence, even when missing Im rows.

When inserting Google Talk presence updates, we match on
both Im and Email rows.  This change adds presence "dots"
to individual Im rows, and creates in-memory Im rows when
Email entries have presence.

This loads status details through a second query and holds
back building UI until both queries finish.  This change
also generalizes logic for building Im intents borrowed
from FastTrack code.

This change also fixes a regression that was dropping third-
party data rows.  The second-query approach above allows us
to remove a large chunk of code that was using old API.

Fixes http://b/2161796

14 years agoUse a thread pool to fetch images. Bug 2163087.
Costin Manolache [Tue, 6 Oct 2009 19:22:09 +0000 (12:22 -0700)]
Use a thread pool to fetch images. Bug 2163087.

14 years agoMerge change I6238c621 into eclair
Android (Google) Code Review [Tue, 6 Oct 2009 18:23:53 +0000 (14:23 -0400)]
Merge change I6238c621 into eclair

* changes:
  Prevents empty focus contacts without photo from being created.

14 years agoPrevents empty focus contacts without photo from being created.
Megha Joshi [Mon, 5 Oct 2009 21:13:58 +0000 (14:13 -0700)]
Prevents empty focus contacts without photo from being created.

Bug: 2133257
Dr No: TS

14 years agoMerge change Ifb476198 into eclair
Android (Google) Code Review [Tue, 6 Oct 2009 17:14:57 +0000 (13:14 -0400)]
Merge change Ifb476198 into eclair

* changes:
  Use framework assets for section headers, and adjust layout to pixel perfect.

14 years agoUse framework assets for section headers, and adjust layout to pixel perfect.
Evan Millar [Mon, 5 Oct 2009 23:06:29 +0000 (16:06 -0700)]
Use framework assets for section headers, and adjust layout to pixel perfect.

-triaged bug http://b/issue?id=2153296
-Tim Sullivan gave Dr. No approval.

Change-Id: Ifb4761986cf3c991d9af5deacb15ac256a603e4a

14 years agoUpdated icons for Contacts.
Daniel Sandler [Tue, 6 Oct 2009 15:34:40 +0000 (11:34 -0400)]
Updated icons for Contacts.

DrNo: mcleron
Change-Id: I4392f12a57e611f744a61a9bd1c0ccf3bba437a4

14 years agoMerge change I517b266a into eclair
Android (Google) Code Review [Tue, 6 Oct 2009 02:40:28 +0000 (22:40 -0400)]
Merge change I517b266a into eclair

* changes:
  [Issue 2165144] Fixing managed delete dialogs in ContactListActivity

14 years ago[Issue 2165144] Fixing managed delete dialogs in ContactListActivity
Dmitri Plotnikov [Tue, 6 Oct 2009 00:05:37 +0000 (17:05 -0700)]
[Issue 2165144] Fixing managed delete dialogs in ContactListActivity

Since these dialogs are managed, they are not actually destroyed after the first
use, but reused.  These dialogs were initialized with the URI of the first
contact we were deleting.  On subsequent calls, they were reused and tried to
delete the same contact.

Change-Id: I517b266a96fe72268c8dfbc7fe3f84fa366d7a23

14 years agoExclude FastTrack window from recent apps.
Jeff Sharkey [Fri, 2 Oct 2009 21:22:51 +0000 (14:22 -0700)]
Exclude FastTrack window from recent apps.

Fixes http://b/2163542

14 years agoMerge change I14fec660 into eclair
Android (Google) Code Review [Mon, 5 Oct 2009 23:18:40 +0000 (19:18 -0400)]
Merge change I14fec660 into eclair

* changes:
  Fix NPE being thrown when starting the AttachImage activity.

14 years agoFix NPE being thrown when starting the AttachImage activity.
Neel Parekh [Mon, 5 Oct 2009 21:56:48 +0000 (14:56 -0700)]
Fix NPE being thrown when starting the AttachImage activity.

Bug: 2164613

14 years agoaccount manager api review changes
Fred Quintana [Sat, 3 Oct 2009 00:19:11 +0000 (17:19 -0700)]
account manager api review changes

14 years agoMerge change I3040fa30 into eclair
Android (Google) Code Review [Sat, 3 Oct 2009 15:16:11 +0000 (11:16 -0400)]
Merge change I3040fa30 into eclair

* changes:
  Taping the dialed number allows editing.

14 years agoFixes bug where delete option from Menu list is disabled in Contact view mode.
Megha Joshi [Fri, 2 Oct 2009 00:31:49 +0000 (17:31 -0700)]
Fixes bug where delete option from Menu list is disabled in Contact view mode.
Bug was caused by the count increment logic being removed in the next submitted change
https://android-git.corp.google.com/w/?p=platform/packages/apps/Contacts.git;a=commit;h=df18120ed2c37a45eb47e39c4da0c8e3b6eb335c
Disabled menu was removed in some other subsequent change, so adding dialog for the case when writable contacts = 0.

Changes delete contact bebavior in EditContactActivity to be same
ViewContactActivity.

Updates dialog message for readonly contact deletion.

bug 2161222
Dr No : TS
Reviewed By: dplotnikov, timsullivan

14 years ago[Issue 2157935] Adding a confirmation dialog for contact split.
Dmitri Plotnikov [Sat, 3 Oct 2009 00:34:27 +0000 (17:34 -0700)]
[Issue 2157935] Adding a confirmation dialog for contact split.

Also renaming the menu button to "Separate"
Also making the menu button only visible for aggregate contacts

Bug discussed with and approved by Tim.

Change-Id: Ie6950b2779c37a1694e01e5ca5ef819ae3d850b5

14 years ago[Issue 2161366] Changing strings for total number of contacts displayed
Dmitri Plotnikov [Fri, 2 Oct 2009 23:00:18 +0000 (16:00 -0700)]
[Issue 2161366] Changing strings for total number of contacts displayed

Approved by Tim.

Change-Id: I43bf6d71193f0d6315b3c06a2da8824f01f102d7

14 years agoDismiss FastTrack only after calling startActivity().
Jeff Sharkey [Fri, 2 Oct 2009 02:51:14 +0000 (19:51 -0700)]
Dismiss FastTrack only after calling startActivity().

When launching towards an existing task where the target
activity is already at the top of that task, we triggered
a check in ActivityManager that requires the caller to be
in the foreground.  Before this change, we dismissed the
dialog before calling startActivity(), meaning that in
this case the user action would result in a no-op.

Fixes http://b/2162031

14 years agoFix attaching image on "new contact" screen.
Neel Parekh [Fri, 2 Oct 2009 17:49:22 +0000 (10:49 -0700)]
Fix attaching image on "new contact" screen.

Bug: 2161910
Dr. NO: TS

14 years agoTaping the dialed number allows editing.
Nicolas Catania [Thu, 1 Oct 2009 20:00:53 +0000 (13:00 -0700)]
Taping the dialed number allows editing.

Previously, taping the dialed number used to dial the number.
Now if non-empty, a cursor shows up at the tap location.
The user can then use the dialpad to delete/insert new numbers.

The previous version of the selectors that drive the number background
has been moved to the non finger drawable because they show the right
background when focused.
In touch mode, the background does not change when focused.

Bug:2160189

14 years agoMerge change Ifaf19b53 into eclair
Android (Google) Code Review [Fri, 2 Oct 2009 07:58:33 +0000 (03:58 -0400)]
Merge change Ifaf19b53 into eclair

* changes:
  More icons

14 years agoMore icons
Mike Cleron [Fri, 2 Oct 2009 07:35:09 +0000 (00:35 -0700)]
More icons

14 years agoMerge change I08582aef into eclair
Android (Google) Code Review [Fri, 2 Oct 2009 04:48:16 +0000 (00:48 -0400)]
Merge change I08582aef into eclair

* changes:
  Import revised translations.  DO NOT MERGE