From: Patrick Scott Date: Wed, 18 Nov 2009 14:53:03 +0000 (-0500) Subject: UI tweaks to meet Jeff's spec. X-Git-Tag: android-x86-2.2~36^2^2~22 X-Git-Url: http://git.osdn.net/view?p=android-x86%2Fpackages-apps-DeskClock.git;a=commitdiff_plain;h=f1e8069bcd1755d9ef2322b705d8d9d6b83728f0;ds=sidebyside UI tweaks to meet Jeff's spec. Colors and text sizes are exactly how Jeff specified in the pdf. I tried to match the size of everything based on looks but I might be a little off in padding. The shadow effect on the bottom clock has been left out for now since there are no specifics in the spec for each of the shadow components and I cannot figure it out based on the drawing. --- diff --git a/res/drawable-hdpi/ic_menu_add.png b/res/drawable-hdpi/ic_menu_add.png new file mode 100755 index 0000000..65cc01e Binary files /dev/null and b/res/drawable-hdpi/ic_menu_add.png differ diff --git a/res/drawable-mdpi/ic_menu_add.png b/res/drawable-mdpi/ic_menu_add.png new file mode 100644 index 0000000..6752bfd Binary files /dev/null and b/res/drawable-mdpi/ic_menu_add.png differ diff --git a/res/drawable/indicator_bar_onoff.xml b/res/drawable/indicator_bar_onoff.xml new file mode 100644 index 0000000..e3d8caa --- /dev/null +++ b/res/drawable/indicator_bar_onoff.xml @@ -0,0 +1,22 @@ + + + + + + + diff --git a/res/drawable/indicator_clock_onoff.xml b/res/drawable/indicator_clock_onoff.xml index f44563c..3fea6c0 100644 --- a/res/drawable/indicator_clock_onoff.xml +++ b/res/drawable/indicator_clock_onoff.xml @@ -17,8 +17,5 @@ - - + diff --git a/res/layout/alarm_clock.xml b/res/layout/alarm_clock.xml index ed8b757..6e70259 100644 --- a/res/layout/alarm_clock.xml +++ b/res/layout/alarm_clock.xml @@ -23,7 +23,6 @@ + + + android:textSize="48sp" + android:textColor="?android:attr/textColorPrimary" /> + android:textColor="?android:attr/textColorPrimary" /> diff --git a/res/layout/alarm_time.xml b/res/layout/alarm_time.xml index 6ab5a66..9f8c12a 100644 --- a/res/layout/alarm_time.xml +++ b/res/layout/alarm_time.xml @@ -22,6 +22,14 @@ android:layout_height="wrap_content" android:orientation="horizontal"> + + android:button="@null" /> + android:paddingLeft="16dip" + android:paddingRight="16dip"> + android:textSize="28sp" + android:textColor="?android:attr/textColorPrimary"/> + android:textColor="?android:attr/textColorPrimary"/> @@ -97,8 +104,8 @@ android:includeFontPadding="false" android:layout_width="fill_parent" android:layout_height="wrap_content" - android:textSize="10sp" - android:textColor="@color/grey"/> + android:textAppearance="?android:attr/textAppearanceSmall" + android:textColor="?android:attr/textColorSecondary"/> diff --git a/res/menu/alarm_list_menu.xml b/res/menu/alarm_list_menu.xml index a8d1911..1b727b3 100644 --- a/res/menu/alarm_list_menu.xml +++ b/res/menu/alarm_list_menu.xml @@ -15,6 +15,12 @@ --> + + diff --git a/res/menu/context_menu.xml b/res/menu/context_menu.xml index 25a62be..797bafb 100644 --- a/res/menu/context_menu.xml +++ b/res/menu/context_menu.xml @@ -17,6 +17,8 @@ + diff --git a/res/values-cs/strings.xml b/res/values-cs/strings.xml index 0283d2a..df1d737 100644 --- a/res/values-cs/strings.xml +++ b/res/values-cs/strings.xml @@ -20,7 +20,6 @@ "Přidat budík" "Smazat budík" "Aktivovat budík" - "Deaktivovat budík" "Tento budík bude smazán." "Zobrazit hodiny" "Skrýt hodiny" diff --git a/res/values-da/strings.xml b/res/values-da/strings.xml index 00713e6..1c1c25d 100644 --- a/res/values-da/strings.xml +++ b/res/values-da/strings.xml @@ -20,7 +20,6 @@ "Tilføj alarm" "Slet alarm" "Aktiver alarm" - "Deaktiver alarm" "Denne alarm slettes." "Vis ur" "Skjul ur" diff --git a/res/values-de/strings.xml b/res/values-de/strings.xml index 8f74995..fb0384d 100644 --- a/res/values-de/strings.xml +++ b/res/values-de/strings.xml @@ -20,7 +20,6 @@ "Wecker hinzufügen" "Wecker löschen" "Wecker aktivieren" - "Wecker deaktivieren" "Dieser Alarm wird gelöscht." "Uhr anzeigen" "Uhr ausblenden" diff --git a/res/values-el/strings.xml b/res/values-el/strings.xml index e6288ff..cc79f77 100644 --- a/res/values-el/strings.xml +++ b/res/values-el/strings.xml @@ -20,7 +20,6 @@ "Προσθήκη ξυπνητηριού" "Διαγραφή ξυπνητηριού" "Ενεργοποίηση ξυπνητηριού" - "Απενεργοποίηση ξυπνητηριού" "Αυτό το ξυπνητήρι θα διαγραφεί." "Εμφάνιση ρολογιού" "Απόκρυψη ρολογιού" diff --git a/res/values-es-rUS/strings.xml b/res/values-es-rUS/strings.xml index e4fd90a..f1838cc 100644 --- a/res/values-es-rUS/strings.xml +++ b/res/values-es-rUS/strings.xml @@ -20,7 +20,6 @@ "Agregar alarma" "Eliminar alarma" "Activar alarma" - "Desactivar alarma" "Esta alarma se eliminará" "Mostrar reloj" "Ocultar reloj" diff --git a/res/values-es/strings.xml b/res/values-es/strings.xml index 4200abf..ebcd0da 100644 --- a/res/values-es/strings.xml +++ b/res/values-es/strings.xml @@ -20,7 +20,6 @@ "Añadir alarma" "Eliminar alarma" "Activar alarma" - "Desactivar alarma" "Esta alarma se eliminará." "Mostrar reloj" "Ocultar reloj" diff --git a/res/values-fr/strings.xml b/res/values-fr/strings.xml index 7f54303..202006e 100644 --- a/res/values-fr/strings.xml +++ b/res/values-fr/strings.xml @@ -20,7 +20,6 @@ "Ajouter alarme" "Supprimer l\'alarme" "Activer l\'alarme" - "Désactiver l\'alarme" "Cette alarme va être supprimée." "Afficher l\'horloge" "Masquer l\'horloge" diff --git a/res/values-it/strings.xml b/res/values-it/strings.xml index 24d2f26..8731dfe 100644 --- a/res/values-it/strings.xml +++ b/res/values-it/strings.xml @@ -20,7 +20,6 @@ "Aggiungi allarme" "Elimina allarme" "Attiva allarme" - "Disattiva allarme" "Questa sveglia verrà eliminata." "Mostra orologio" "Nascondi orologio" diff --git a/res/values-ja/strings.xml b/res/values-ja/strings.xml index 3db9923..8a9c57c 100644 --- a/res/values-ja/strings.xml +++ b/res/values-ja/strings.xml @@ -20,7 +20,6 @@ "アラームの設定" "アラームを削除" "アラームON" - "アラームOFF" "このアラームを削除します。" "時計を表示" "時計を隠す" diff --git a/res/values-ko/strings.xml b/res/values-ko/strings.xml index 00199df..44492a4 100644 --- a/res/values-ko/strings.xml +++ b/res/values-ko/strings.xml @@ -20,7 +20,6 @@ "알람 추가" "알람 삭제" "알람 사용" - "알람 사용 중지" "알람이 삭제됩니다." "시계 표시" "시계 숨기기" diff --git a/res/values-nb/strings.xml b/res/values-nb/strings.xml index fa67254..42d5343 100644 --- a/res/values-nb/strings.xml +++ b/res/values-nb/strings.xml @@ -20,7 +20,6 @@ "Legg til alarm" "Slett alarm" "Aktiver alarm" - "Deaktiver alarm" "Denne alarmen vil bli slettet." "Vis klokke" "Skjul klokke" diff --git a/res/values-nl/strings.xml b/res/values-nl/strings.xml index 5aacd03..3eacdaa 100644 --- a/res/values-nl/strings.xml +++ b/res/values-nl/strings.xml @@ -20,7 +20,6 @@ "Alarm toevoegen" "Alarm verwijderen" "Alarm inschakelen" - "Alarm uitschakelen" "Dit alarm wordt verwijderd." "Klok weergeven" "Klok verbergen" diff --git a/res/values-pl/strings.xml b/res/values-pl/strings.xml index c003376..0297a18 100644 --- a/res/values-pl/strings.xml +++ b/res/values-pl/strings.xml @@ -20,7 +20,6 @@ "Dodaj alarm" "Usuń alarm" "Włącz alarm" - "Wyłącz alarm" "Ten zegar zostanie usunięty." "Pokaż zegar" "Ukryj zegar" diff --git a/res/values-pt-rPT/strings.xml b/res/values-pt-rPT/strings.xml index b915994..1fb6e54 100644 --- a/res/values-pt-rPT/strings.xml +++ b/res/values-pt-rPT/strings.xml @@ -20,7 +20,6 @@ "Adicionar alarme" "Eliminar alarme" "Activar alarme" - "Desactivar alarme" "Este alarme será eliminado." "Mostrar relógio" "Ocultar relógio" diff --git a/res/values-pt/strings.xml b/res/values-pt/strings.xml index 0c98cf5..727ac2b 100644 --- a/res/values-pt/strings.xml +++ b/res/values-pt/strings.xml @@ -20,7 +20,6 @@ "Adicionar alarme" "Excluir alarme" "Ativar alarme" - "Desativar alarme" "Este alarme será excluído." "Mostrar relógio" "Ocultar relógio" diff --git a/res/values-ru/strings.xml b/res/values-ru/strings.xml index 276f05e..405aec9 100644 --- a/res/values-ru/strings.xml +++ b/res/values-ru/strings.xml @@ -20,7 +20,6 @@ "Добавить будильник" "Удалить будильник" "Включить будильник" - "Отключить будильник" "Сигнал будет удален." "Показать часы" "Спрятать часы" diff --git a/res/values-sv/strings.xml b/res/values-sv/strings.xml index ab13701..1b2bba7 100644 --- a/res/values-sv/strings.xml +++ b/res/values-sv/strings.xml @@ -20,7 +20,6 @@ "Lägg till alarm" "Ta bort alarm" "Aktivera alarmet" - "Inaktivera alarmet" "Alarmet tas bort." "Visa klocka" "Dölj klocka" diff --git a/res/values-tr/strings.xml b/res/values-tr/strings.xml index 85f9005..823e4c5 100644 --- a/res/values-tr/strings.xml +++ b/res/values-tr/strings.xml @@ -20,7 +20,6 @@ "Alarm ekle" "Alarmı sil" "Alarmı etkinleştir" - "Alarmı devre dışı bırak" "Bu alarm silinecek." "Saati göster" "Saati gizle" diff --git a/res/values-zh-rCN/strings.xml b/res/values-zh-rCN/strings.xml index 536acde..6a13aef 100644 --- a/res/values-zh-rCN/strings.xml +++ b/res/values-zh-rCN/strings.xml @@ -20,7 +20,6 @@ "添加闹钟" "取消闹钟" "启用闹钟" - "停用闹钟" "将会取消此闹钟。" "显示时钟" "隐藏时钟" diff --git a/res/values-zh-rTW/strings.xml b/res/values-zh-rTW/strings.xml index 703f398..7edac1f 100644 --- a/res/values-zh-rTW/strings.xml +++ b/res/values-zh-rTW/strings.xml @@ -22,7 +22,6 @@ "新增鬧鐘" "刪除鬧鐘" "啟用鬧鐘" - "停用鬧鐘" "刪除此鬧鐘?" "顯示時鐘" "隱藏時鐘" diff --git a/res/values/strings.xml b/res/values/strings.xml index ef2817e..d14b740 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -25,14 +25,17 @@ Add alarm + + Desk clock + + + Edit alarm + Delete alarm - Enable alarm - - - Disable alarm + Turn alarm on/off This alarm will be deleted. diff --git a/res/values/styles.xml b/res/values/styles.xml index 11a6550..3cfb5c9 100644 --- a/res/values/styles.xml +++ b/res/values/styles.xml @@ -54,7 +54,7 @@ diff --git a/src/com/android/deskclock/AlarmClock.java b/src/com/android/deskclock/AlarmClock.java index acf42b3..e872ead 100644 --- a/src/com/android/deskclock/AlarmClock.java +++ b/src/com/android/deskclock/AlarmClock.java @@ -192,6 +192,12 @@ public class AlarmClock extends Activity implements OnItemClickListener { } return true; + case R.id.edit_alarm: + Intent intent = new Intent(this, SetAlarm.class); + intent.putExtra(Alarms.ALARM_ID, id); + startActivity(intent); + return true; + default: break; } @@ -221,17 +227,7 @@ public class AlarmClock extends Activity implements OnItemClickListener { View addAlarm = findViewById(R.id.add_alarm); addAlarm.setOnClickListener(new View.OnClickListener() { public void onClick(View v) { - Uri uri = Alarms.addAlarm(getContentResolver()); - // FIXME: scroll to new item? - String segment = uri.getPathSegments().get(1); - int newId = Integer.parseInt(segment); - if (Log.LOGV) { - Log.v("In AlarmClock, new alarm id = " + newId); - } - Intent intent = - new Intent(AlarmClock.this, SetAlarm.class); - intent.putExtra(Alarms.ALARM_ID, newId); - startActivity(intent); + addNewAlarm(); } }); @@ -244,6 +240,18 @@ public class AlarmClock extends Activity implements OnItemClickListener { }); } + private void addNewAlarm() { + Uri uri = Alarms.addAlarm(getContentResolver()); + String segment = uri.getPathSegments().get(1); + int newId = Integer.parseInt(segment); + if (Log.LOGV) { + Log.v("In AlarmClock, new alarm id = " + newId); + } + Intent intent = new Intent(this, SetAlarm.class); + intent.putExtra(Alarms.ALARM_ID, newId); + startActivity(intent); + } + @Override protected void onDestroy() { super.onDestroy(); @@ -278,25 +286,30 @@ public class AlarmClock extends Activity implements OnItemClickListener { // Set the custom view on the menu. menu.setHeaderView(v); - // Change the text to "disable" if the alarm is already enabled. - if (alarm.enabled) { - menu.findItem(R.id.enable_alarm).setTitle(R.string.disable_alarm); - } } @Override public boolean onOptionsItemSelected(MenuItem item) { - if (item.getItemId() == R.id.menu_item_settings) { - startActivity(new Intent(this, SettingsActivity.class)); - return true; + switch (item.getItemId()) { + case R.id.menu_item_settings: + startActivity(new Intent(this, SettingsActivity.class)); + return true; + case R.id.menu_item_desk_clock: + startActivity(new Intent(this, DeskClock.class)); + return true; + case R.id.menu_item_add_alarm: + addNewAlarm(); + return true; + default: + break; } - return false; + return super.onOptionsItemSelected(item); } @Override public boolean onCreateOptionsMenu(Menu menu) { getMenuInflater().inflate(R.menu.alarm_list_menu, menu); - return true; + return super.onCreateOptionsMenu(menu); } public void onItemClick(AdapterView parent, View v, int pos, long id) {