From: Adam Lesinski Date: Tue, 14 Nov 2017 19:10:08 +0000 (-0800) Subject: Update the way OMS records details about overlays X-Git-Tag: android-x86-8.1-r1~6^2^2 X-Git-Url: http://git.osdn.net/view?p=android-x86%2Fpackages-apps-Settings.git;a=commitdiff_plain;h=aeea544e07ca92fedb99e4600ed1dbdef4ffc445 Update the way OMS records details about overlays Use flags, since we keep introducing boolean traits which would be wasteful to encode as booleans. Bug: 69383160 Test: builds Change-Id: Ic09ae1086c7afa039b5df11e4c8c968125784586 Merged-In: Ic09ae1086c7afa039b5df11e4c8c968125784586 (cherry picked from commit 9e19121a00b85d7618bf294f70afa0f205e3ac00) --- diff --git a/src/com/android/settings/display/ThemePreferenceController.java b/src/com/android/settings/display/ThemePreferenceController.java index 3bb58b15d0..5eeb3906c0 100644 --- a/src/com/android/settings/display/ThemePreferenceController.java +++ b/src/com/android/settings/display/ThemePreferenceController.java @@ -125,7 +125,7 @@ public class ThemePreferenceController extends AbstractPreferenceController impl private boolean isChangeableOverlay(String packageName) { try { PackageInfo pi = mPackageManager.getPackageInfo(packageName, 0); - return pi != null && !pi.isStaticOverlay; + return pi != null && (pi.overlayFlags & PackageInfo.FLAG_OVERLAY_STATIC) == 0; } catch (PackageManager.NameNotFoundException e) { return false; } diff --git a/tests/unit/src/com/android/settings/display/ThemePreferenceControllerTest.java b/tests/unit/src/com/android/settings/display/ThemePreferenceControllerTest.java index 69c8c54c67..8c6e8da0db 100644 --- a/tests/unit/src/com/android/settings/display/ThemePreferenceControllerTest.java +++ b/tests/unit/src/com/android/settings/display/ThemePreferenceControllerTest.java @@ -119,7 +119,7 @@ public class ThemePreferenceControllerTest { return info; }); PackageInfo pi = new PackageInfo(); - pi.isStaticOverlay = true; + pi.overlayFlags |= PackageInfo.FLAG_OVERLAY_STATIC; when(mMockPackageManager.getPackageInfo(eq("com.android.Theme1"), anyInt())).thenReturn(pi); when(mMockPackageManager.getPackageInfo(eq("com.android.Theme2"), anyInt())).thenReturn( new PackageInfo());