From 0276486e3caca82fa5e4ee3e32b202be90d71c50 Mon Sep 17 00:00:00 2001 From: Kazuhiro Fujieda Date: Sat, 29 Dec 2018 17:31:06 +0900 Subject: [PATCH] =?utf8?q?=E6=88=A6=E9=97=98=E5=BE=8C=E3=81=AEHP=E3=81=AE?= =?utf8?q?=E7=9F=9B=E7=9B=BE=E3=81=A8=E5=8B=9D=E5=88=A9=E5=88=A4=E5=AE=9A?= =?utf8?q?=E3=81=AE=E7=9F=9B=E7=9B=BE=E3=82=92=E4=B8=80=E5=BA=A6=E3=81=AB?= =?utf8?q?=E7=A2=BA=E8=AA=8D=E3=81=99=E3=82=8B?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit --- KancolleSniffer.Test/BattleTest.cs | 23 +++++++++++------------ KancolleSniffer/ErrorLog.cs | 6 +----- KancolleSniffer/Sniffer.cs | 2 +- 3 files changed, 13 insertions(+), 18 deletions(-) diff --git a/KancolleSniffer.Test/BattleTest.cs b/KancolleSniffer.Test/BattleTest.cs index 47d1c42..5eaf884 100644 --- a/KancolleSniffer.Test/BattleTest.cs +++ b/KancolleSniffer.Test/BattleTest.cs @@ -97,7 +97,7 @@ namespace KancolleSniffer.Test { var sniffer = new Sniffer(); SniffLogFile(sniffer, "practice_001"); - PAssert.That(() => !sniffer.IsBattleResultStatusError); + PAssert.That(() => !sniffer.IsBattleResultError); } /// @@ -108,7 +108,7 @@ namespace KancolleSniffer.Test { var sniffer = new Sniffer(); SniffLogFile(sniffer, "practice_002"); - PAssert.That(() => !sniffer.Battle.DisplayedResultRank.IsError); + PAssert.That(() => !sniffer.IsBattleResultError); } /// @@ -130,7 +130,7 @@ namespace KancolleSniffer.Test { var sniffer = new Sniffer(); SniffLogFile(sniffer, "combined_battle_001"); - PAssert.That(() => !sniffer.IsBattleResultStatusError); + PAssert.That(() => !sniffer.IsBattleResultError); } /// @@ -141,7 +141,7 @@ namespace KancolleSniffer.Test { var sniffer = new Sniffer(); SniffLogFile(sniffer, "combined_battle_002"); - PAssert.That(() => !sniffer.IsBattleResultStatusError); + PAssert.That(() => !sniffer.IsBattleResultError); } /// @@ -152,7 +152,7 @@ namespace KancolleSniffer.Test { var sniffer = new Sniffer(); SniffLogFile(sniffer, "combined_battle_003"); - PAssert.That(() => !sniffer.IsBattleResultStatusError); + PAssert.That(() => !sniffer.IsBattleResultError); } /// @@ -176,7 +176,7 @@ namespace KancolleSniffer.Test { var sniffer = new Sniffer(); SniffLogFile(sniffer, "sp_midnight_002"); - PAssert.That(() => !sniffer.Battle.DisplayedResultRank.IsError); + PAssert.That(() => !sniffer.IsBattleResultError); } /// @@ -187,7 +187,7 @@ namespace KancolleSniffer.Test { var sniffer = new Sniffer(); SniffLogFile(sniffer, "nighttoday_001"); - PAssert.That(() => !sniffer.Battle.DisplayedResultRank.IsError && !sniffer.IsBattleResultStatusError); + PAssert.That(() => !sniffer.IsBattleResultError); } /// @@ -211,7 +211,7 @@ namespace KancolleSniffer.Test var sniffer = new Sniffer(); SniffLogFile(sniffer, "escape_002"); PAssert.That(() => sniffer.Fleets[2].Ships[1].Escaped); - PAssert.That(() => !sniffer.IsBattleResultStatusError); + PAssert.That(() => !sniffer.IsBattleResultError); } /// @@ -255,7 +255,7 @@ namespace KancolleSniffer.Test { var sniffer = new Sniffer(); SniffLogFile(sniffer, "nelsontouch_001"); - PAssert.That(() => !sniffer.Battle.DisplayedResultRank.IsError); + PAssert.That(() => !sniffer.IsBattleResultError); PAssert.That(() => sniffer.Battle.Result.Friend.Main[0].SpecialAttack == ShipStatus.Attack.Fire); PAssert.That(() => sniffer.Fleets[0].Ships[0].SpecialAttack == ShipStatus.Attack.Fired); // ship_deckでフラグを引き継ぐ @@ -273,7 +273,7 @@ namespace KancolleSniffer.Test { var sniffer = new Sniffer(); SniffLogFile(sniffer, "nagatospecial_001"); - PAssert.That(() => !sniffer.Battle.DisplayedResultRank.IsError); + PAssert.That(() => !sniffer.IsBattleResultError); PAssert.That(() => sniffer.Battle.Result.Friend.Main[0].SpecialAttack == ShipStatus.Attack.Fire); PAssert.That(() => sniffer.Fleets[0].Ships[0].SpecialAttack == ShipStatus.Attack.Fired); } @@ -286,8 +286,7 @@ namespace KancolleSniffer.Test { var sniffer = new Sniffer(); SniffLogFile(sniffer, "ld_shooting_001"); - PAssert.That(() => !sniffer.IsBattleResultStatusError); - PAssert.That(() => !sniffer.Battle.DisplayedResultRank.IsError); + PAssert.That(() => !sniffer.IsBattleResultError); } } } \ No newline at end of file diff --git a/KancolleSniffer/ErrorLog.cs b/KancolleSniffer/ErrorLog.cs index 5bb606a..0c12769 100644 --- a/KancolleSniffer/ErrorLog.cs +++ b/KancolleSniffer/ErrorLog.cs @@ -18,7 +18,6 @@ using System.IO; using System.IO.Compression; using System.Linq; using System.Text; -using System.Text.RegularExpressions; using System.Windows.Forms; using KancolleSniffer.Model; using KancolleSniffer.Util; @@ -52,7 +51,7 @@ namespace KancolleSniffer } else if (_prevBattleState == BattleState.Result && // battleresultのあとのship_deckかportでのみエラー判定する - IsBattleResultError) + _sniffer.IsBattleResultError) { throw new BattleResultError(); } @@ -63,9 +62,6 @@ namespace KancolleSniffer } } - private bool IsBattleResultError => - _sniffer.Battle.DisplayedResultRank.IsError || _sniffer.IsBattleResultStatusError; - public string GenerateBattleErrorLog() { foreach (var logs in _battleApiLog) diff --git a/KancolleSniffer/Sniffer.cs b/KancolleSniffer/Sniffer.cs index cafc9e1..28dc70d 100644 --- a/KancolleSniffer/Sniffer.cs +++ b/KancolleSniffer/Sniffer.cs @@ -639,7 +639,7 @@ namespace KancolleSniffer public ShipInfo.ShipStatusPair[] BattleResultStatusDiff => _shipInfo.BattleResultDiff; - public bool IsBattleResultStatusError => _shipInfo.IsBattleResultError; + public bool IsBattleResultError => _shipInfo.IsBattleResultError || _battleInfo.DisplayedResultRank.IsError; public ShipStatus[] BattleStartStatus => _shipInfo.BattleStartStatus; -- 2.11.0