From 7d8ee8247bc2c042fd3fff6e3b311730b7c42d5a Mon Sep 17 00:00:00 2001 From: Florin Malita Date: Mon, 5 Jun 2006 15:34:33 -0700 Subject: [PATCH] [PPPOE]: Missing result check in __pppoe_xmit(). [backport of 2.6 commit 9bc18091a5e44a368827f539289b99788eb27d4e] skb_clone() may fail, we should check the result. Coverity CID: 1215. Signed-off-by: Florin Malita Signed-off-by: Andrew Morton Signed-off-by: David S. Miller Signed-off-by: Willy Tarreau --- drivers/net/pppoe.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/pppoe.c b/drivers/net/pppoe.c index 85bbc782..5af4d65b 100644 --- a/drivers/net/pppoe.c +++ b/drivers/net/pppoe.c @@ -907,6 +907,9 @@ int __pppoe_xmit(struct sock *sk, struct sk_buff *skb) * give dev_queue_xmit something it can free. */ skb2 = skb_clone(skb, GFP_ATOMIC); + + if (skb2 == NULL) + goto abort; } ph = (struct pppoe_hdr *) skb_push(skb2, sizeof(struct pppoe_hdr)); -- 2.11.0